From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Zhixu Zhao <zhixu001@126.com>,
rcy@google.com, rspringer@google.com, toddpoynor@google.com
Subject: Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c
Date: Wed, 15 Jul 2020 11:37:27 +0300 [thread overview]
Message-ID: <20200715083727.GY2549@kadam> (raw)
In-Reply-To: <20200715075755.GA2516028@kroah.com>
On Wed, Jul 15, 2020 at 09:57:55AM +0200, Greg KH wrote:
> On Wed, Jul 15, 2020 at 12:24:22AM -0700, Joe Perches wrote:
> > On Wed, 2020-07-15 at 09:17 +0200, Greg KH wrote:
> > > On Wed, Jul 15, 2020 at 07:44:40AM +0800, Zhixu Zhao wrote:
> > > > On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote:
> > > > > A coding alignment issue is found by checkpatch.pl.
> > > > > Fix it by using a temporary for gasket_dev->bar_data[bar_num].
> > > > >
> > > > > Signed-off-by: Zhixu Zhao <zhixu001@126.com>
> > > >
> > > > Hi, there~
> > > >
> > > > Does anybody have any further comments on this?
> > > > Can it be merged?
> > >
> > > I never saw the first version of this, are you sure it got sent to the
> > > mailing list? It's not in any archives anywhere.
> >
> > I saw it. It's here:
> > https://lore.kernel.org/lkml/20200617161127.32006-1-zhixu001@126.com/
>
> Ah, doh, sorry.
>
> Zhixu, please address the comments given to you on the series and resend
> it as a new version.
He responded but not as a reply to my email. It turns out I made a
mistake.
Anyway, just resend, Zhixu.
regards,
dan carpenter
next prev parent reply other threads:[~2020-07-15 8:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:11 [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c Zhixu Zhao
2020-06-17 19:10 ` Dan Carpenter
2020-07-15 10:38 ` Zhao
2020-06-18 13:44 ` Zhixu Zhao
2020-06-18 14:03 ` Dan Carpenter
2020-07-14 23:44 ` Zhixu Zhao
2020-07-15 7:17 ` Greg KH
2020-07-15 7:24 ` Joe Perches
2020-07-15 7:57 ` Greg KH
2020-07-15 8:37 ` Dan Carpenter [this message]
2020-07-15 9:04 ` Joe Perches
2020-07-15 10:45 ` Zhao
2020-07-15 11:06 ` Dan Carpenter
2020-07-15 13:33 ` [PATCH v3] " Zhixu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715083727.GY2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcy@google.com \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
--cc=zhixu001@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.