From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net-next] ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1 Date: Wed, 15 Jul 2020 20:54:42 +0200 Message-ID: <20200715185442.GA19665@salvia> References: <20200708161245.GB14873@salvia> <20200708161638.13584-1-kim.andrewsy@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Anastasov Cc: Andrew Sy Kim , Wensong Zhang , Simon Horman , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org On Wed, Jul 08, 2020 at 08:19:55PM +0300, Julian Anastasov wrote: > > Hello, > > On Wed, 8 Jul 2020, Andrew Sy Kim wrote: > > > When expire_nodest_conn=1 and a destination is deleted, IPVS does not > > expire the existing connections until the next matching incoming packet. > > If there are many connection entries from a single client to a single > > destination, many packets may get dropped before all the connections are > > expired (more likely with lots of UDP traffic). An optimization can be > > made where upon deletion of a destination, IPVS queues up delayed work > > to immediately expire any connections with a deleted destination. This > > ensures any reused source ports from a client (within the IPVS timeouts) > > are scheduled to new real servers instead of silently dropped. > > > > Signed-off-by: Andrew Sy Kim > > OK, patch content is same, subject has "ipvs:" prefix, > empty line after Signed-off-by is removed, so this patch can > be applied without any modifications. > > Signed-off-by: Julian Anastasov Applied, thanks.