Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding

[Rob Herring <robh@kernel.org>]

On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote:
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
> 
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
> 
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> 
> ---
> 
> The original binding has been merged through the clock tree, so it should
> be merged there.
> 
> Even though the original binding (and the DT) are using the simple-bus
> compatible, this creates some DTC warnings since the firmware really isn't
> a bus, so the node name doesn't match what a bus should have, none of the
> children have a reg property, #address-cells and #size-cells are missing,
> etc.
> 
> I can only guess that simple-bus was used to make the sub-devices probe,
> but maybe simple-mfd would be more appropriate here?

As these are not mmio devices, I think simple-mfd is better.

> ---
>  .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index b48ed875eb8e..17e4f20c8d39 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -10,6 +10,15 @@ maintainers:
>    - Eric Anholt <eric@anholt.net>
>    - Stefan Wahren <wahrenst@gmx.net>
>  
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: raspberrypi,bcm2835-firmware
> +
> +  required:
> +    - compatible
> +
>  properties:
>    compatible:
>      items:
> -- 
> 2.26.2
>