From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A68DC433E4 for ; Wed, 15 Jul 2020 21:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 759372065F for ; Wed, 15 Jul 2020 21:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgGOVYr (ORCPT ); Wed, 15 Jul 2020 17:24:47 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53619 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726356AbgGOVYq (ORCPT ); Wed, 15 Jul 2020 17:24:46 -0400 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 43E79E0003; Wed, 15 Jul 2020 21:24:44 +0000 (UTC) Date: Wed, 15 Jul 2020 23:24:43 +0200 From: Alexandre Belloni To: Lee Jones Cc: broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Radu Pirea , Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Message-ID: <20200715212443.GC23553@piout.net> References: <20200715150632.409077-1-lee.jones@linaro.org> <20200715150632.409077-13-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200715150632.409077-13-lee.jones@linaro.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi Lee, On 15/07/2020 16:06:30+0100, Lee Jones wrote: > It's there so why not use it. > Is that the correct resolution? Isn't the proper thing to do simply removing at91_usart_spi_dt_ids as the only way it will ever be probed is through drivers/mfd/at91-usart.c and I would think matching the driver name is enough. > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] > 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { > | ^~~~~~~~~~~~~~~~~~~~~ > > Cc: Radu Pirea > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Signed-off-by: Lee Jones > --- > drivers/spi/spi-at91-usart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c > index 88033422a42ae..d47a20be43ccd 100644 > --- a/drivers/spi/spi-at91-usart.c > +++ b/drivers/spi/spi-at91-usart.c > @@ -692,6 +692,7 @@ static struct platform_driver at91_usart_spi_driver = { > .driver = { > .name = "at91_usart_spi", > .pm = &at91_usart_spi_pm_ops, > + .of_match_table = at91_usart_spi_dt_ids, > }, > .probe = at91_usart_spi_probe, > .remove = at91_usart_spi_remove, > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC23C433E1 for ; Wed, 15 Jul 2020 21:26:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB86A2065F for ; Wed, 15 Jul 2020 21:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nLY6zmci" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB86A2065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IHpe560XO5Be2CfxXOGtuMRcfFE8tZUAoeEEtFIeEsI=; b=nLY6zmcigDvrvVvctSutXAGSQ YvC3oql4FxhXLM5KCCbTlDl9nQYMGyNzXCl0lOkYkBeL7WgQmD+pxB+LpZ0xopo44SJ90tpG8fMBt VYVCZmvF78PRrGQQ0Nizekg5vjNM9UMbnTQjBpCI+TgH3aZHhJhdsmZ7/Bx2c2Gm92VGucDOiqOtg zx2ENRDSumuNs8HFg7ONpi5z2NXYX2UypWBK9zFtwqd2AXoU3nNSCo1k7LttDrwQXREtB7YK3hv66 7f0cUyff1ET4TxKbLu0u9VeAEzi5lEnEgAibi8ljPUJUqWC23wdNQX+Mi+IMmSe7jphxAKGXf3E1B 6fjCCIqHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvotY-0005Hk-8R; Wed, 15 Jul 2020 21:24:52 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvotU-0005Gb-HP for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 21:24:49 +0000 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 43E79E0003; Wed, 15 Jul 2020 21:24:44 +0000 (UTC) Date: Wed, 15 Jul 2020 23:24:43 +0200 From: Alexandre Belloni To: Lee Jones Subject: Re: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Message-ID: <20200715212443.GC23553@piout.net> References: <20200715150632.409077-1-lee.jones@linaro.org> <20200715150632.409077-13-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200715150632.409077-13-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_172448_701125_F5166C0B X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radu Pirea , linux-kernel@vger.kernel.org, Ludovic Desroches , broonie@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGVlLAoKT24gMTUvMDcvMjAyMCAxNjowNjozMCswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g SXQncyB0aGVyZSBzbyB3aHkgbm90IHVzZSBpdC4KPiAKCklzIHRoYXQgdGhlIGNvcnJlY3QgcmVz b2x1dGlvbj8gSXNuJ3QgdGhlIHByb3BlciB0aGluZyB0byBkbyBzaW1wbHkKcmVtb3ZpbmcgYXQ5 MV91c2FydF9zcGlfZHRfaWRzIGFzIHRoZSBvbmx5IHdheSBpdCB3aWxsIGV2ZXIgYmUgcHJvYmVk IGlzCnRocm91Z2ggZHJpdmVycy9tZmQvYXQ5MS11c2FydC5jIGFuZCBJIHdvdWxkIHRoaW5rIG1h dGNoaW5nIHRoZSBkcml2ZXIKbmFtZSBpcyBlbm91Z2guCgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcg Vz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+IAo+ICBkcml2ZXJzL3NwaS9zcGktYXQ5MS11 c2FydC5jOjY4NDozNDogd2FybmluZzog4oCYYXQ5MV91c2FydF9zcGlfZHRfaWRz4oCZIGRlZmlu ZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJpYWJsZT1dCj4gIDY4NCB8IHN0YXRp YyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGF0OTFfdXNhcnRfc3BpX2R0X2lkc1tdID0gewo+ ICB8IF5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IAo+IENjOiBSYWR1IFBpcmVhIDxyYWR1X25pY29s YWUucGlyZWFAdXBiLnJvPgo+IENjOiBOaWNvbGFzIEZlcnJlIDxuaWNvbGFzLmZlcnJlQG1pY3Jv Y2hpcC5jb20+Cj4gQ2M6IEFsZXhhbmRyZSBCZWxsb25pIDxhbGV4YW5kcmUuYmVsbG9uaUBib290 bGluLmNvbT4KPiBDYzogTHVkb3ZpYyBEZXNyb2NoZXMgPGx1ZG92aWMuZGVzcm9jaGVzQG1pY3Jv Y2hpcC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9y Zz4KPiAtLS0KPiAgZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNhcnQuYyB8IDEgKwo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zcGkvc3Bp LWF0OTEtdXNhcnQuYyBiL2RyaXZlcnMvc3BpL3NwaS1hdDkxLXVzYXJ0LmMKPiBpbmRleCA4ODAz MzQyMmE0MmFlLi5kNDdhMjBiZTQzY2NkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3BpL3NwaS1h dDkxLXVzYXJ0LmMKPiArKysgYi9kcml2ZXJzL3NwaS9zcGktYXQ5MS11c2FydC5jCj4gQEAgLTY5 Miw2ICs2OTIsNyBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBhdDkxX3VzYXJ0X3Nw aV9kcml2ZXIgPSB7Cj4gIAkuZHJpdmVyID0gewo+ICAJCS5uYW1lID0gImF0OTFfdXNhcnRfc3Bp IiwKPiAgCQkucG0gPSAmYXQ5MV91c2FydF9zcGlfcG1fb3BzLAo+ICsJCS5vZl9tYXRjaF90YWJs ZSA9IGF0OTFfdXNhcnRfc3BpX2R0X2lkcywKPiAgCX0sCj4gIAkucHJvYmUgPSBhdDkxX3VzYXJ0 X3NwaV9wcm9iZSwKPiAgCS5yZW1vdmUgPSBhdDkxX3VzYXJ0X3NwaV9yZW1vdmUsCj4gLS0gCj4g Mi4yNS4xCj4gCgotLSAKQWxleGFuZHJlIEJlbGxvbmksIEJvb3RsaW4KRW1iZWRkZWQgTGludXgg YW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==