From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/4] fs/squashfs: add sources for zlib decompression
Date: Wed, 15 Jul 2020 21:37:49 +0200 [thread overview]
Message-ID: <20200715213749.0e509fcf@windsurf.home> (raw)
In-Reply-To: <20200709175148.17193-4-joaomarcos.costa@bootlin.com>
Hello Joao,
On Thu, 9 Jul 2020 19:51:47 +0200
Joao Marcos Costa <joaomarcos.costa@bootlin.com> wrote:
> Add zlib (v1.2.11) functions to U-Boot. SquashFS depends on those
> functions to decompress data from a raw disk image. The actual support
> for zlib into SquashFS sources will be added in a follow-up commit.
>
> Signed-off-by: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
The header of the commit title is wrong, this commit is not touching
fs/squashfs at all, but lib/zlib.
I think the rest of the commit title are also misleading: I believe
zlib decompression was already supported in U-Boot.
But looking at the code, lib/gunzip.c already has a function called
zunzip(), which seems to do pretty much the same thing: decompress from
a memory buffer into another memory buffer.
Are you sure you cannot use this existing zunzip() function ? zunzip()
is already used by UBIFS.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-07-15 19:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 17:51 [PATCH 0/4] Add support for the SquashFS filesystem Joao Marcos Costa
2020-07-09 17:51 ` [PATCH 1/4] fs/squashfs: new filesystem Joao Marcos Costa
2020-07-09 19:50 ` Rasmus Villemoes
2020-07-09 20:19 ` Joao Marcos Costa
2020-07-10 8:29 ` Thomas Petazzoni
2020-07-10 8:54 ` Rasmus Villemoes
2020-07-10 9:13 ` Thomas Petazzoni
2020-07-15 21:56 ` Tom Rini
2020-07-15 21:55 ` Tom Rini
2020-07-09 17:51 ` [PATCH 2/4] fs/squashfs: add filesystem commands Joao Marcos Costa
2020-07-09 17:51 ` [PATCH 3/4] fs/squashfs: add sources for zlib decompression Joao Marcos Costa
2020-07-15 19:37 ` Thomas Petazzoni [this message]
2020-07-09 17:51 ` [PATCH 4/4] fs/squashfs: add support " Joao Marcos Costa
2020-07-15 20:11 ` [PATCH 0/3] squashfs fixes Thomas Petazzoni
2020-07-15 20:11 ` [PATCH 1/3] cmd/sqfs.c, include/fs.h: fix build failures, don't expose do_sqfs_*() functions globally Thomas Petazzoni
2020-07-15 20:11 ` [PATCH 2/3] fs/squashfs: use "struct disk_partition" instead of "disk_partition_t" Thomas Petazzoni
2020-07-15 20:11 ` [PATCH 3/3] fs/squashfs: do not use CMD_RET_* defines in the filesystem code Thomas Petazzoni
2020-07-16 7:51 ` [PATCH 0/3] squashfs fixes Joao Marcos Costa
2020-07-16 8:33 ` Thomas Petazzoni
2020-07-15 20:22 ` [PATCH] fs/squashfs/sqfs.c: use sqfs_read_sblk() in sqfs_probe() Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715213749.0e509fcf@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.