From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A6EC433DF for ; Wed, 15 Jul 2020 21:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E7E32072E for ; Wed, 15 Jul 2020 21:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbgGOVom (ORCPT ); Wed, 15 Jul 2020 17:44:42 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:49211 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbgGOVol (ORCPT ); Wed, 15 Jul 2020 17:44:41 -0400 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1CA45E0005; Wed, 15 Jul 2020 21:44:38 +0000 (UTC) Date: Wed, 15 Jul 2020 23:44:38 +0200 From: Alexandre Belloni To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , Ludovic Desroches , Nicolas Ferre , Songjun Wu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH RESEND 1/3] usb: gadget: udc: atmel: remove outdated comment in usba_ep_disable() Message-ID: <20200715214438.GE23553@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 08/07/2020 20:04:09+0200, Michał Mirosław wrote: > Fixed commit removed the offending behaviour from the driver, but missed > the comment and associated test. Remove them now. > > Fixes: 38e58986e6fc ("usb: gadget: udc: atmel: don't disable enpdoints we don't own") > Signed-off-by: Michał Mirosław Acked-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index d69f61ff0181..9153e220848d 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -676,13 +676,7 @@ static int usba_ep_disable(struct usb_ep *_ep) > > if (!ep->ep.desc) { > spin_unlock_irqrestore(&udc->lock, flags); > - /* REVISIT because this driver disables endpoints in > - * reset_all_endpoints() before calling disconnect(), > - * most gadget drivers would trigger this non-error ... > - */ > - if (udc->gadget.speed != USB_SPEED_UNKNOWN) > - DBG(DBG_ERR, "ep_disable: %s not enabled\n", > - ep->ep.name); > + DBG(DBG_ERR, "ep_disable: %s not enabled\n", ep->ep.name); > return -EINVAL; > } > ep->ep.desc = NULL; > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B92C433E6 for ; Wed, 15 Jul 2020 21:46:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 901E92065D for ; Wed, 15 Jul 2020 21:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Qf274yX7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 901E92065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xsiMuZzyn0SB7E9kW/xWWo0winHoj6HwkrZvlkIBacY=; b=Qf274yX7GAq2sCEwtZo+U1GRg aS71PU5nTEGrE7u7I2tUjqokCUREiNXc8+jyhwNe2I/nz7wRTvoO029Mt6PTVt2VmPkfQIvaYLx9c HfymNLbCnbdase9AgIxwj83wF2saetpmL9MqGow4GwP4eFNoEzr4JswSZCisNTO96aXaq/4J28LT1 MHrS1PlpUm3oUshIWp1LwKqLH9w/vNeOnR7Dn/FDCaMLDRk0hhdyFF5UH2eZbUZmbdPxT8uNoT1il DazEimdPSMBopphVXNZeC36NXyRd24SNf/K8qONFXXVsscZnWyRHtD3Xg2Sx6ea3LtdQKAXfBvqPM QGlx/LInw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvpCm-0007Z0-2R; Wed, 15 Jul 2020 21:44:44 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvpCj-0007Yb-Ac for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 21:44:42 +0000 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1CA45E0005; Wed, 15 Jul 2020 21:44:38 +0000 (UTC) Date: Wed, 15 Jul 2020 23:44:38 +0200 From: Alexandre Belloni To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Subject: Re: [PATCH RESEND 1/3] usb: gadget: udc: atmel: remove outdated comment in usba_ep_disable() Message-ID: <20200715214438.GE23553@piout.net> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_174441_483387_D3E4BB30 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Songjun Wu , Cristian Birsan Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDgvMDcvMjAyMCAyMDowNDowOSswMjAwLCBNaWNoYcWCIE1pcm9zxYJhdyB3cm90ZToKPiBG aXhlZCBjb21taXQgcmVtb3ZlZCB0aGUgb2ZmZW5kaW5nIGJlaGF2aW91ciBmcm9tIHRoZSBkcml2 ZXIsIGJ1dCBtaXNzZWQKPiB0aGUgY29tbWVudCBhbmQgYXNzb2NpYXRlZCB0ZXN0LiBSZW1vdmUg dGhlbSBub3cuCj4gCj4gRml4ZXM6IDM4ZTU4OTg2ZTZmYyAoInVzYjogZ2FkZ2V0OiB1ZGM6IGF0 bWVsOiBkb24ndCBkaXNhYmxlIGVucGRvaW50cyB3ZSBkb24ndCBvd24iKQo+IFNpZ25lZC1vZmYt Ynk6IE1pY2hhxYIgTWlyb3PFgmF3IDxtaXJxLWxpbnV4QHJlcmUucW1xbS5wbD4KQWNrZWQtYnk6 IEFsZXhhbmRyZSBCZWxsb25pIDxhbGV4YW5kcmUuYmVsbG9uaUBib290bGluLmNvbT4KCj4gLS0t Cj4gIGRyaXZlcnMvdXNiL2dhZGdldC91ZGMvYXRtZWxfdXNiYV91ZGMuYyB8IDggKy0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRjLmMgYi9kcml2 ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRjLmMKPiBpbmRleCBkNjlmNjFmZjAxODEu LjkxNTNlMjIwODQ4ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVs X3VzYmFfdWRjLmMKPiArKysgYi9kcml2ZXJzL3VzYi9nYWRnZXQvdWRjL2F0bWVsX3VzYmFfdWRj LmMKPiBAQCAtNjc2LDEzICs2NzYsNyBAQCBzdGF0aWMgaW50IHVzYmFfZXBfZGlzYWJsZShzdHJ1 Y3QgdXNiX2VwICpfZXApCj4gIAo+ICAJaWYgKCFlcC0+ZXAuZGVzYykgewo+ICAJCXNwaW5fdW5s b2NrX2lycXJlc3RvcmUoJnVkYy0+bG9jaywgZmxhZ3MpOwo+IC0JCS8qIFJFVklTSVQgYmVjYXVz ZSB0aGlzIGRyaXZlciBkaXNhYmxlcyBlbmRwb2ludHMgaW4KPiAtCQkgKiByZXNldF9hbGxfZW5k cG9pbnRzKCkgYmVmb3JlIGNhbGxpbmcgZGlzY29ubmVjdCgpLAo+IC0JCSAqIG1vc3QgZ2FkZ2V0 IGRyaXZlcnMgd291bGQgdHJpZ2dlciB0aGlzIG5vbi1lcnJvciAuLi4KPiAtCQkgKi8KPiAtCQlp ZiAodWRjLT5nYWRnZXQuc3BlZWQgIT0gVVNCX1NQRUVEX1VOS05PV04pCj4gLQkJCURCRyhEQkdf RVJSLCAiZXBfZGlzYWJsZTogJXMgbm90IGVuYWJsZWRcbiIsCj4gLQkJCQkJZXAtPmVwLm5hbWUp Owo+ICsJCURCRyhEQkdfRVJSLCAiZXBfZGlzYWJsZTogJXMgbm90IGVuYWJsZWRcbiIsIGVwLT5l cC5uYW1lKTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCWVwLT5lcC5kZXNjID0gTlVM TDsKPiAtLSAKPiAyLjIwLjEKPiAKCi0tIApBbGV4YW5kcmUgQmVsbG9uaSwgQm9vdGxpbgpFbWJl ZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK