From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC4EC433E0 for ; Thu, 16 Jul 2020 07:56:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82F8620657 for ; Thu, 16 Jul 2020 07:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ctmn+yI/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725926AbgGPH4L (ORCPT ); Thu, 16 Jul 2020 03:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgGPH4K (ORCPT ); Thu, 16 Jul 2020 03:56:10 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 940B7C061755 for ; Thu, 16 Jul 2020 00:56:10 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o8so9202178wmh.4 for ; Thu, 16 Jul 2020 00:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=E3RYKNb85oZ0Zx4y7onyr244i3mIIOsmBXwDkItqE+k=; b=ctmn+yI/FZFifjCNYzMz9Bq9cteGr8LhZ9mVVlZ1Fug41fk3w7p/ReVoVuTtHDwyHV B9jbYA1ikUtXdtJzxEOhmVTJ8dYaZmDcYAIdt0i99dAaif664G3O2T42EYMdm68F75Q4 3x0Q+AuMzzXsczEVHbUMel3NhLKq0xsjzhbUn+SAzCdPB6IGCMiTpL+IN/5/ocn7PayG 4zQ/lGe9l1m8CqZEMl8VpRAe4W1RNOcb7vERHMDUuOtYD4YoBBCPOXHf0olaU8KeQ1hO 0OHLpM/7XjSSiHoohK6rOoLQl4iTtSjvcNYqLgT0G4cUzdcBZZYX8n0GlBThMlpDw0Iw /cmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=E3RYKNb85oZ0Zx4y7onyr244i3mIIOsmBXwDkItqE+k=; b=CVKp4oGT+4oWw/45T/UNhmEvUa3bLJ5vESGNfN2QqlbPodofnIKHFilss3BxNZ8j/9 0/tQ9Szr38ngK7KkKA4R3j5EuRxbE3x+/GQO8qutlpxGcsAE7ijHUgM4j++17ti/hg+k gZgcx/1IX5nBQJdqNRPWPkglYaaEp5cOXIiZ8/n5xZZZE1YCJyUgLc5qZyek0Bt7YUO2 zhFwHRVHzuXAXkttARbctr4PoLpmMFXijyv/6xxzIWN5Fdd8BnxFfkhtBGJOUgqeZxug ndJIBrJ2Oj7nkqepFelasMl0HuUe1VHM7h5gHH+9gSU6gDBzFaYsEFlvXiNaK+ST48WB lHjg== X-Gm-Message-State: AOAM531GACMhvReAds8iR9JvEsXRDXD2e9stn3rtLMOVnZImQPsxCWqY hlR3U5Xb3anwcXdsx11gQBSrHA== X-Google-Smtp-Source: ABdhPJw3VrvtHsivvIaotZC5ddMt77keOADIJTHX4XCZZ5qFOosY50Z87c19woDUrLHGVN9dOoqKuA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr3331097wmg.118.1594886169187; Thu, 16 Jul 2020 00:56:09 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id z8sm7302939wmg.39.2020.07.16.00.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 00:56:08 -0700 (PDT) Date: Thu, 16 Jul 2020 08:56:06 +0100 From: Lee Jones To: Alexandre Belloni Cc: broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Radu Pirea , Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Message-ID: <20200716075606.GM3165313@dell> References: <20200715150632.409077-1-lee.jones@linaro.org> <20200715150632.409077-13-lee.jones@linaro.org> <20200715212443.GC23553@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200715212443.GC23553@piout.net> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Wed, 15 Jul 2020, Alexandre Belloni wrote: > Hi Lee, > > On 15/07/2020 16:06:30+0100, Lee Jones wrote: > > It's there so why not use it. > > > > Is that the correct resolution? Isn't the proper thing to do simply > removing at91_usart_spi_dt_ids as the only way it will ever be probed is > through drivers/mfd/at91-usart.c and I would think matching the driver > name is enough. I'm 50/50 on this. Happy with whatever the authors/maintainers decide most appropriate. > > Fixes the following W=1 kernel build warning(s): > > > > drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] > > 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { > > | ^~~~~~~~~~~~~~~~~~~~~ > > > > Cc: Radu Pirea > > Cc: Nicolas Ferre > > Cc: Alexandre Belloni > > Cc: Ludovic Desroches > > Signed-off-by: Lee Jones > > --- > > drivers/spi/spi-at91-usart.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c > > index 88033422a42ae..d47a20be43ccd 100644 > > --- a/drivers/spi/spi-at91-usart.c > > +++ b/drivers/spi/spi-at91-usart.c > > @@ -692,6 +692,7 @@ static struct platform_driver at91_usart_spi_driver = { > > .driver = { > > .name = "at91_usart_spi", > > .pm = &at91_usart_spi_pm_ops, > > + .of_match_table = at91_usart_spi_dt_ids, > > }, > > .probe = at91_usart_spi_probe, > > .remove = at91_usart_spi_remove, > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4D9C433E2 for ; Thu, 16 Jul 2020 07:58:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1998E20760 for ; Thu, 16 Jul 2020 07:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J8vT8Tpw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ctmn+yI/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1998E20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gpeDI702yB5U671CymkdI82vJO1tjfVUllKfBjVqwCQ=; b=J8vT8TpwxP9ty8GifHTruZQMt R8sJMn5A+U7uBE5JIzzu61Bh5vzhyH2rnLBl/K2ONtZCgmzyoPPmPZ0jLckDfkWs6K5MyQ91WJmZu pyd8ND946lI+6wdGYTO3UJYDawgNPvmC5doW/QmaPWA22JcVlkYqqGCp9UYVVBH7jBEzopwZxoYvC oYhF4HXg/E0mLwi4FtCInZWpU83IsL4QI+4wcIYHZz+8hjGYb85/r4RI6EzfcxJYu6Iz8xYNwnk9y ogd8QHg7vCtVgasOLXaD5iCFobr3o3d+sDVpsHYqyC0SiGxZfdGOtidQjW3FVyiYXeo4eVm1ayMin 1GApPjrNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvykY-0001D7-70; Thu, 16 Jul 2020 07:56:14 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvykU-0001Ca-Oa for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 07:56:12 +0000 Received: by mail-wm1-x341.google.com with SMTP id w3so10375239wmi.4 for ; Thu, 16 Jul 2020 00:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=E3RYKNb85oZ0Zx4y7onyr244i3mIIOsmBXwDkItqE+k=; b=ctmn+yI/FZFifjCNYzMz9Bq9cteGr8LhZ9mVVlZ1Fug41fk3w7p/ReVoVuTtHDwyHV B9jbYA1ikUtXdtJzxEOhmVTJ8dYaZmDcYAIdt0i99dAaif664G3O2T42EYMdm68F75Q4 3x0Q+AuMzzXsczEVHbUMel3NhLKq0xsjzhbUn+SAzCdPB6IGCMiTpL+IN/5/ocn7PayG 4zQ/lGe9l1m8CqZEMl8VpRAe4W1RNOcb7vERHMDUuOtYD4YoBBCPOXHf0olaU8KeQ1hO 0OHLpM/7XjSSiHoohK6rOoLQl4iTtSjvcNYqLgT0G4cUzdcBZZYX8n0GlBThMlpDw0Iw /cmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=E3RYKNb85oZ0Zx4y7onyr244i3mIIOsmBXwDkItqE+k=; b=HGZSpunX3Q0xLvuXFuAoinJKFjMn48GrnyHtd//hj76uvA9Yrs7k7ojHcxosVh+mdC nl40cRyUhnn6L9UT6cpJxwWzhg/5HKtAH+st88+qfXNwUnTloLg9DP12RQnFrJ+iK0xE G8HX9pZuxu4yF6d09jG/o0+OJzSAizN7qT7iyOIpW3gtZWhUIRHbG5hvyJjFePxDdIR6 /MWE42DRrPuojqPafL/ebphthG3wR6TmEx/nQ3D2tu+bFmqJKWAYHyDInkgrqCf3G0K7 wGelexvEpsjFmkt7XJdkEoq1wYkyQy4FI+QqSGOJ/NxpyQPFMK2RNSxNyYDx9/UjzfYx fycA== X-Gm-Message-State: AOAM5327xRZw1to1DrYZr1JbuQyDXWoIBo/GgCGNcRznuzlz+EOxdOfZ 9mRVf1pGCB2/iRbF/j3Hccqrhg== X-Google-Smtp-Source: ABdhPJw3VrvtHsivvIaotZC5ddMt77keOADIJTHX4XCZZ5qFOosY50Z87c19woDUrLHGVN9dOoqKuA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr3331097wmg.118.1594886169187; Thu, 16 Jul 2020 00:56:09 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id z8sm7302939wmg.39.2020.07.16.00.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 00:56:08 -0700 (PDT) Date: Thu, 16 Jul 2020 08:56:06 +0100 From: Lee Jones To: Alexandre Belloni Subject: Re: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Message-ID: <20200716075606.GM3165313@dell> References: <20200715150632.409077-1-lee.jones@linaro.org> <20200715150632.409077-13-lee.jones@linaro.org> <20200715212443.GC23553@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200715212443.GC23553@piout.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_035611_095524_9E38B926 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radu Pirea , linux-kernel@vger.kernel.org, Ludovic Desroches , broonie@kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxNSBKdWwgMjAyMCwgQWxleGFuZHJlIEJlbGxvbmkgd3JvdGU6Cgo+IEhpIExlZSwK PiAKPiBPbiAxNS8wNy8yMDIwIDE2OjA2OjMwKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+IEl0 J3MgdGhlcmUgc28gd2h5IG5vdCB1c2UgaXQuCj4gPiAKPiAKPiBJcyB0aGF0IHRoZSBjb3JyZWN0 IHJlc29sdXRpb24/IElzbid0IHRoZSBwcm9wZXIgdGhpbmcgdG8gZG8gc2ltcGx5Cj4gcmVtb3Zp bmcgYXQ5MV91c2FydF9zcGlfZHRfaWRzIGFzIHRoZSBvbmx5IHdheSBpdCB3aWxsIGV2ZXIgYmUg cHJvYmVkIGlzCj4gdGhyb3VnaCBkcml2ZXJzL21mZC9hdDkxLXVzYXJ0LmMgYW5kIEkgd291bGQg dGhpbmsgbWF0Y2hpbmcgdGhlIGRyaXZlcgo+IG5hbWUgaXMgZW5vdWdoLgoKSSdtIDUwLzUwIG9u IHRoaXMuCgpIYXBweSB3aXRoIHdoYXRldmVyIHRoZSBhdXRob3JzL21haW50YWluZXJzIGRlY2lk ZSBtb3N0IGFwcHJvcHJpYXRlLgoKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBi dWlsZCB3YXJuaW5nKHMpOgo+ID4gCj4gPiAgZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNhcnQuYzo2 ODQ6MzQ6IHdhcm5pbmc6IOKAmGF0OTFfdXNhcnRfc3BpX2R0X2lkc+KAmSBkZWZpbmVkIGJ1dCBu b3QgdXNlZCBbLVd1bnVzZWQtY29uc3QtdmFyaWFibGU9XQo+ID4gIDY4NCB8IHN0YXRpYyBjb25z dCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGF0OTFfdXNhcnRfc3BpX2R0X2lkc1tdID0gewo+ID4gIHwg Xn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiAKPiA+IENjOiBSYWR1IFBpcmVhIDxyYWR1X25pY29s YWUucGlyZWFAdXBiLnJvPgo+ID4gQ2M6IE5pY29sYXMgRmVycmUgPG5pY29sYXMuZmVycmVAbWlj cm9jaGlwLmNvbT4KPiA+IENjOiBBbGV4YW5kcmUgQmVsbG9uaSA8YWxleGFuZHJlLmJlbGxvbmlA Ym9vdGxpbi5jb20+Cj4gPiBDYzogTHVkb3ZpYyBEZXNyb2NoZXMgPGx1ZG92aWMuZGVzcm9jaGVz QG1pY3JvY2hpcC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0Bs aW5hcm8ub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNhcnQuYyB8IDEg Kwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9zcGkvc3BpLWF0OTEtdXNhcnQuYyBiL2RyaXZlcnMvc3BpL3NwaS1hdDkxLXVz YXJ0LmMKPiA+IGluZGV4IDg4MDMzNDIyYTQyYWUuLmQ0N2EyMGJlNDNjY2QgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL3NwaS9zcGktYXQ5MS11c2FydC5jCj4gPiArKysgYi9kcml2ZXJzL3NwaS9z cGktYXQ5MS11c2FydC5jCj4gPiBAQCAtNjkyLDYgKzY5Miw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGxh dGZvcm1fZHJpdmVyIGF0OTFfdXNhcnRfc3BpX2RyaXZlciA9IHsKPiA+ICAJLmRyaXZlciA9IHsK PiA+ICAJCS5uYW1lID0gImF0OTFfdXNhcnRfc3BpIiwKPiA+ICAJCS5wbSA9ICZhdDkxX3VzYXJ0 X3NwaV9wbV9vcHMsCj4gPiArCQkub2ZfbWF0Y2hfdGFibGUgPSBhdDkxX3VzYXJ0X3NwaV9kdF9p ZHMsCj4gPiAgCX0sCj4gPiAgCS5wcm9iZSA9IGF0OTFfdXNhcnRfc3BpX3Byb2JlLAo+ID4gIAku cmVtb3ZlID0gYXQ5MV91c2FydF9zcGlfcmVtb3ZlLAo+IAoKLS0gCkxlZSBKb25lcyBb5p2O55C8 5pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9y ZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZh Y2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK