Re: [PATCH 4/4] MIPS: Loongson64: Reserve legacy MMIO space according to bridge type

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Thu, Jul 09, 2020 at 07:33:44PM +0800, Huacai Chen wrote:
> Define MMIO_LOWER_RESERVED as a constant is incorrect, because different
> PCHs (bridge types) have different legacy MMIO space size. According to
> the datasheets, the legacy MMIO space size of LS7A is 0x20000, and which
> of other PCHs is 0x4000. So it is necessary to reserve legacy MMIO space
> according to the bridge type.
> 
> Currently IO_SPACE_LIMIT is defined as 0xffff which is too small for the
> LS7A bridge, so increase it to 0xfffff for LOONGSON64.
> 
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  arch/mips/include/asm/io.h                     |  4 ++++
>  arch/mips/include/asm/mach-loongson64/spaces.h |  3 ---
>  arch/mips/loongson64/init.c                    | 18 ++++++++++++++----
>  3 files changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
> index 346fffd..7358372 100644
> --- a/arch/mips/include/asm/io.h
> +++ b/arch/mips/include/asm/io.h
> @@ -51,7 +51,11 @@
>  
>  /* ioswab[bwlq], __mem_ioswab[bwlq] are defined in mangle-port.h */
>  
> +#ifndef CONFIG_CPU_LOONGSON64
>  #define IO_SPACE_LIMIT 0xffff
> +#else
> +#define IO_SPACE_LIMIT 0xfffff
> +#endif

can you please move this #define to mach-generic/spaces.h and
override it in mach-loongson64/spaces.h ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]