From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF37C433E2 for ; Fri, 17 Jul 2020 07:06:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBB252076A for ; Fri, 17 Jul 2020 07:06:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="V09RZc3a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBulK0WZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBB252076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 79FCC1689; Fri, 17 Jul 2020 09:05:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 79FCC1689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594969577; bh=c9uRyhRfNKBUBBZyxKtUrxMndDLQydw/cULV5zWzdB0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V09RZc3aCT0Nrafli5yNROab5H9364hFne/XSLHkKuokZyW03wKufZB2AYzJMrwRM uAf+3OcFUlaL+Li9A6Q8plcwGplK/XnCew5aa/81PiR6J832VZP4PyKE2M+ObzuWrj Y6JBP/gFIXN6i/pLzaC5IFKku1Uo8vo0suvfz+cw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4203EF802BD; Fri, 17 Jul 2020 09:05:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8E23AF801EC; Thu, 16 Jul 2020 21:16:10 +0200 (CEST) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11A96F8014E for ; Thu, 16 Jul 2020 21:15:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11A96F8014E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBulK0WZ" Received: by mail-pf1-x441.google.com with SMTP id s26so4133819pfm.4 for ; Thu, 16 Jul 2020 12:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2R0hcRnXsJS4VXyiriDanEq/mQczbWkrFO+xv3Ye6s4=; b=ZBulK0WZzf/Y2plsJIiBiP9vBDDMB7cKE4nNyO7pI4jhAiFahLl13+wjjYl4AYx5BB otJeoT7KMXmj//B0s5TndSWJM7ep3jPNHzKSwrpR80GkT/ENBrVdogHDfc7FSXQgqchK la7hTG8ks3MzuTa72KfZtSagY7XpH9MYfx1mQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2R0hcRnXsJS4VXyiriDanEq/mQczbWkrFO+xv3Ye6s4=; b=Mo52gFUtd2yUUWZnwUXxbrcn9ocayyW+FEAzUBCnH7rOF/1flzNKtN+fWGa0ee5JXK s3Yoa86Sj7B0CFONpEQBeKbFp/Rktx/kDhBUgwIfSVKIlsdOcwD5OoLbtnbKBMLfhbuW NtX980F/TLi+31l0sPAgtC3i9AMZ41pmsugGnny5bSziJnsSreyTFGZLmVcPTBkJHyDV H7UACg+II3NTQPhAdcw+X6IFVELGPwmjJr6T87ig8WT0nYum5RIaHX3OjtWDs21ROUWe OUAlnp+bepQkO1ygmpYNdnU9QdXv5LNSNz1xCvfUzuS3Jb19PX9aIiCOg3FQednmHNRI Y3xw== X-Gm-Message-State: AOAM533Uc1Hf9DdghS8Zz4HYjRU/v07+Si4FVica6LOwIn8HYiTZ6ELf 6dylEA9H+CwPSsm1ddyO3CZg0A== X-Google-Smtp-Source: ABdhPJz1hoi+gTw0MHgO0dM+96Dp9MZSCNtNi6/yuZgpSobcItifHoGm+Bd2+MNyMCABANHPmkEEMg== X-Received: by 2002:a65:664a:: with SMTP id z10mr5423029pgv.352.1594926957331; Thu, 16 Jul 2020 12:15:57 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h15sm5618413pfo.192.2020.07.16.12.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 12:15:56 -0700 (PDT) Date: Thu, 16 Jul 2020 12:15:55 -0700 From: Kees Cook To: Matthew Wilcox Subject: Re: [PATCH 2/3] treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD() Message-ID: <202007161215.5C0CE54AB@keescook> References: <20200716030847.1564131-1-keescook@chromium.org> <20200716030847.1564131-3-keescook@chromium.org> <20200716112914.GK12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716112914.GK12769@casper.infradead.org> X-Mailman-Approved-At: Fri, 17 Jul 2020 09:05:03 +0200 Cc: Kuppuswamy Sathyanarayanan , "Rafael J. Wysocki" , Oscar Carter , Mitchell Blank Jr , kernel-hardening@lists.openwall.com, Peter Zijlstra , kgdb-bugreport@lists.sourceforge.net, Sebastian Andrzej Siewior , alsa-devel@alsa-project.org, Allen Pais , netdev@vger.kernel.org, Christian Gromm , Will Deacon , devel@driverdev.osuosl.org, Jonathan Corbet , Daniel Thompson , "David S. Miller" , Masahiro Yamada , Takashi Iwai , Julian Wiedmann , Christian Borntraeger , Nishka Dasgupta , Jiri Slaby , Jakub Kicinski , Guenter Roeck , Wambui Karuga , Vasily Gorbik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , linux-input@vger.kernel.org, Ursula Braun , Stephen Boyd , Chris Packham , Harald Freudenberger , Thomas Gleixner , Felipe Balbi , Kyungtae Kim , Greg Kroah-Hartman , Dmitry Torokhov , Douglas Anderson , Kevin Curtis , linux-usb@vger.kernel.org, Jason Wessel , Romain Perier , Karsten Graul X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jul 16, 2020 at 12:29:14PM +0100, Matthew Wilcox wrote: > On Wed, Jul 15, 2020 at 08:08:46PM -0700, Kees Cook wrote: > > This converts all the existing DECLARE_TASKLET() (and ...DISABLED) > > macros with DECLARE_TASKLET_OLD() in preparation for refactoring the > > tasklet callback type. All existing DECLARE_TASKLET() users had a "0" > > data argument, it has been removed here as well. > > > > Signed-off-by: Kees Cook > [...] > > 16 files changed, 26 insertions(+), 21 deletions(-) > > This is about 5% of what needs to change. There are 350 callers of > tasklet_init(), and that still takes a 'data' argument. Yup, please see the referenced tree. This "series" is just the ground-work for allowing the rest of the 350 patches to land with calls to the new tasklet_setup() API, and associated prototype and container_of() changes. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2744C433E2 for ; Thu, 16 Jul 2020 19:16:16 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 280132076D for ; Thu, 16 Jul 2020 19:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBulK0WZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 280132076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-19360-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 4033 invoked by uid 550); 16 Jul 2020 19:16:10 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 3999 invoked from network); 16 Jul 2020 19:16:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2R0hcRnXsJS4VXyiriDanEq/mQczbWkrFO+xv3Ye6s4=; b=ZBulK0WZzf/Y2plsJIiBiP9vBDDMB7cKE4nNyO7pI4jhAiFahLl13+wjjYl4AYx5BB otJeoT7KMXmj//B0s5TndSWJM7ep3jPNHzKSwrpR80GkT/ENBrVdogHDfc7FSXQgqchK la7hTG8ks3MzuTa72KfZtSagY7XpH9MYfx1mQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2R0hcRnXsJS4VXyiriDanEq/mQczbWkrFO+xv3Ye6s4=; b=kxgdtVcVHlYH8ag7Mi0WKZSwTuVHujLXlndzzqHKuReMePM3R3ottuaT6YBvR4Deav S2vHGscO2N5/3/qhWWPLLc3tL/xTQf9cB3TUzvTKfcu2vHvblTtuxBITxiSzD0POFktI 6/XSN8wcXqOh9EUmMk9y2HpixvtKQXfLlYHII1uRicb85WLGTzwZL98FbVkXLZv8UsP8 O4Hk7HmVKnLATRF787v0HM8yenpWwRecz7tBl5wrakLkPWPLUjfV0hA/YfQJbeDp+ROk xOjzWC5Dcr0/Pj7ZTS02mWF5X8r6xawFRi6CcLrBujrfqcDPwaSOnMjOP5ARnkh6vScr eijg== X-Gm-Message-State: AOAM530cowoFaP7w4Ph3kMJw7983bjSILn/4i9qzLpmjBzAEEIjw/bRM vTON+anBiRldKwkJBljanSgjCA== X-Google-Smtp-Source: ABdhPJz1hoi+gTw0MHgO0dM+96Dp9MZSCNtNi6/yuZgpSobcItifHoGm+Bd2+MNyMCABANHPmkEEMg== X-Received: by 2002:a65:664a:: with SMTP id z10mr5423029pgv.352.1594926957331; Thu, 16 Jul 2020 12:15:57 -0700 (PDT) Date: Thu, 16 Jul 2020 12:15:55 -0700 From: Kees Cook To: Matthew Wilcox Cc: Greg Kroah-Hartman , Thomas Gleixner , Allen Pais , Oscar Carter , Romain Perier , Dmitry Torokhov , Kevin Curtis , "David S. Miller" , Jakub Kicinski , Harald Freudenberger , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Jiri Slaby , Felipe Balbi , Jason Wessel , Daniel Thompson , Douglas Anderson , Mitchell Blank Jr , Julian Wiedmann , Karsten Graul , Ursula Braun , Jaroslav Kysela , Takashi Iwai , Christian Gromm , Nishka Dasgupta , Masahiro Yamada , Stephen Boyd , Wambui Karuga , Guenter Roeck , Chris Packham , Kyungtae Kim , Kuppuswamy Sathyanarayanan , Sebastian Andrzej Siewior , "Rafael J. Wysocki" , Jonathan Corbet , Peter Zijlstra , Will Deacon , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, alsa-devel@alsa-project.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH 2/3] treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD() Message-ID: <202007161215.5C0CE54AB@keescook> References: <20200716030847.1564131-1-keescook@chromium.org> <20200716030847.1564131-3-keescook@chromium.org> <20200716112914.GK12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716112914.GK12769@casper.infradead.org> On Thu, Jul 16, 2020 at 12:29:14PM +0100, Matthew Wilcox wrote: > On Wed, Jul 15, 2020 at 08:08:46PM -0700, Kees Cook wrote: > > This converts all the existing DECLARE_TASKLET() (and ...DISABLED) > > macros with DECLARE_TASKLET_OLD() in preparation for refactoring the > > tasklet callback type. All existing DECLARE_TASKLET() users had a "0" > > data argument, it has been removed here as well. > > > > Signed-off-by: Kees Cook > [...] > > 16 files changed, 26 insertions(+), 21 deletions(-) > > This is about 5% of what needs to change. There are 350 callers of > tasklet_init(), and that still takes a 'data' argument. Yup, please see the referenced tree. This "series" is just the ground-work for allowing the rest of the 350 patches to land with calls to the new tasklet_setup() API, and associated prototype and container_of() changes. -- Kees Cook