From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL
Date: Thu, 16 Jul 2020 15:38:03 +0300 [thread overview]
Message-ID: <20200716123803.GU6112@intel.com> (raw)
In-Reply-To: <20200716085540.2211-1-uma.shankar@intel.com>
On Thu, Jul 16, 2020 at 02:25:40PM +0530, Uma Shankar wrote:
> Fbc is causing random underruns in CI execution on TGL platforms.
> Disabling the same while the problem is being debugged and analyzed.
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 3a4f980788a6..1d6370b29b27 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1420,6 +1420,13 @@ void intel_fbc_handle_fifo_underrun_irq(struct drm_i915_private *dev_priv)
> */
> static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
> {
> + /*
> + * Fbc is causing random underruns in CI execution on TGL platforms.
> + * Disabling the same while the problem is being debugged and analyzed.
> + */
> + if (IS_TIGERLAKE(dev_priv))
> + return 0;
> +
> if (dev_priv->params.enable_fbc >= 0)
> return !!dev_priv->params.enable_fbc;
>
> --
> 2.22.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-16 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:55 [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL Uma Shankar
2020-07-16 8:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-16 10:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-07-16 12:38 ` Ville Syrjälä [this message]
2020-07-16 12:48 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-07-16 14:29 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716123803.GU6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.