From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24473C433E1 for ; Thu, 16 Jul 2020 12:48:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 007D720760 for ; Thu, 16 Jul 2020 12:48:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 007D720760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86C5B6E1F9; Thu, 16 Jul 2020 12:48:50 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1991A6E1F9 for ; Thu, 16 Jul 2020 12:48:49 +0000 (UTC) IronPort-SDR: vlI8WeN+7tLh87oIkaU9rfntZo1IegWo1U4zKFP0OciZnBHd5QMAfczkFMmXvIkrqF+UiIkWSR AohJ3vgKlZdw== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="234226147" X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="234226147" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 05:48:48 -0700 IronPort-SDR: mMYdAHbGCamHIy03w5N3IrgB4g438Ye+7APECRrgdFOQk+qN2c/ypYIRymb9COyMT/l9WP94XO 5GOr/WUu2uOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="326515949" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 16 Jul 2020 05:48:46 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 16 Jul 2020 15:48:45 +0300 Date: Thu, 16 Jul 2020 15:48:45 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Uma Shankar Message-ID: <20200716124845.GV6112@intel.com> References: <20200716085540.2211-1-uma.shankar@intel.com> <20200716123803.GU6112@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200716123803.GU6112@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/fbc: Disable fbc by default on TGL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jul 16, 2020 at 03:38:03PM +0300, Ville Syrj=E4l=E4 wrote: > On Thu, Jul 16, 2020 at 02:25:40PM +0530, Uma Shankar wrote: > > Fbc is causing random underruns in CI execution on TGL platforms. > > Disabling the same while the problem is being debugged and analyzed. > > = > > Cc: Stanislav Lisovskiy > > Cc: Ville Syrj=E4l=E4 > > Signed-off-by: Uma Shankar > = > Acked-by: Ville Syrj=E4l=E4 Scratch that... > = > > --- > > drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > = > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm= /i915/display/intel_fbc.c > > index 3a4f980788a6..1d6370b29b27 100644 > > --- a/drivers/gpu/drm/i915/display/intel_fbc.c > > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c > > @@ -1420,6 +1420,13 @@ void intel_fbc_handle_fifo_underrun_irq(struct d= rm_i915_private *dev_priv) > > */ > > static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > > { > > + /* > > + * Fbc is causing random underruns in CI execution on TGL platforms. > > + * Disabling the same while the problem is being debugged and analyze= d. > > + */ > > + if (IS_TIGERLAKE(dev_priv)) > > + return 0; ... looks lke this should be done *after* the modparam check below. Otherwise we can't enable fbc for testing via the modparam. > > + > > if (dev_priv->params.enable_fbc >=3D 0) > > return !!dev_priv->params.enable_fbc; > > = > > -- = > > 2.22.0 > = > -- = > Ville Syrj=E4l=E4 > Intel > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx