From: Jason Gunthorpe <jgg@nvidia.com>
To: liweihang <liweihang@huawei.com>
Cc: <dledford@redhat.com>, <leon@kernel.org>,
<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH for-rc] RDMA/hns: Fix wrong assignment of lp_pktn_ini in QPC
Date: Thu, 16 Jul 2020 09:56:16 -0300 [thread overview]
Message-ID: <20200716125616.GA2615760@nvidia.com> (raw)
In-Reply-To: <1594726138-49294-1-git-send-email-liweihang@huawei.com>
On Tue, Jul 14, 2020 at 07:28:58PM +0800, liweihang wrote:
> From: Weihang Li <liweihang@huawei.com>
>
> The RoCE Engine will schedule to another QP after one has sent
> (2 ^ lp_pktn_ini) packets. lp_pktn_ini is set in QPC and should be
> calculated from 2 factors:
> 1. current MTU as a integer
> 2. the RoCE Engine's maximum slice length 64KB
> But the driver use MTU as a enum ib_mtu and the max inline capability,
> the lp_pktn_ini will be much bigger than expected which may cause traffic
> of some QPs never get scheduled.
>
> Fixes: b713128de7a1 ("RDMA/hns: Adjust lp_pktn_ini dynamically")
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 34 +++++++++++++++++++-----------
> 1 file changed, 22 insertions(+), 12 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2020-07-16 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 11:28 [PATCH for-rc] RDMA/hns: Fix wrong assignment of lp_pktn_ini in QPC liweihang
2020-07-16 12:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716125616.GA2615760@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.