From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E61FC433EC for ; Thu, 16 Jul 2020 14:39:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BFC7207BC for ; Thu, 16 Jul 2020 14:39:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xRTuTBfa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729066AbgGPOjq (ORCPT ); Thu, 16 Jul 2020 10:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbgGPOjq (ORCPT ); Thu, 16 Jul 2020 10:39:46 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2E6C08C5C0 for ; Thu, 16 Jul 2020 07:39:45 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id w3so11842630wmi.4 for ; Thu, 16 Jul 2020 07:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=amD6wrTVFFwDbb/9Gfx9BmB+NGg+A9qoz+nxoVL9uN4=; b=xRTuTBfasRD7U+3n7RQKolbc3Bc4VHhuoEMK05/P8zvoGyzO5gW8v0aOgRwGxElcyu y89eoS5pzHxnGr5bEt0QhudSLUFK8Gup2vFYemqo/fWrMxdjuw5SRyzIAh938yqv2ipN gjxH+dr60+qqFEEhsCkw/G5yQ/vcnfsTLZgSu4Z5gmeyRNrY1d1Oa0t8IXw6HIrgcsZi GbRAkSFAO10W478H4GClKk84sWLv7J6mbEFZ3hlp3C+i59NmaNLrfnOWJ/rVqzfliV9t bXzgj3Y4Bp1CDV9s6TSHLhFgCLIdjDrmCYR1li5djNwJlnra6IxiFU76L2Tpm/rQKti3 kvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=amD6wrTVFFwDbb/9Gfx9BmB+NGg+A9qoz+nxoVL9uN4=; b=mU8wx3N1QhW9TvG28zlSXJKj9SfIwK32AgqaJByllK+8nTq5DhiftwMjsIQbtbWhLg yzNq7QArESxc1JimF4CqfxFQT6Bwz9lewTa8rLmtHJbHSPVs9rVmYyEDEUCNIIZovLcu zp2EY7FPt8cpfrru4xAcSFspRVXamzJFpgSiVDtP1Wa7P3li8Oi470S/TCnEFm8joiEu H1sE63EqKYmaBjlZhx0nVGGtKZyXsWvAO0u7l6acRN8xvVxbSIN9jo5nmzNv0xkXwZuV kj2m7yoogwBma6p2vyDc64pE3+gsnQiucGpjM2p9EwBWKroWzwUtD9wCga2nvoCyojcq GgIw== X-Gm-Message-State: AOAM532tFQmVZN2lqnunx3vuPkSqMYRhdH+y4xLpnqDaT0snn+hfzef+ iSWHFF0IObQPjcTUYHDNo+fF6w== X-Google-Smtp-Source: ABdhPJx3HKsrJ856ANN56k2CwqUedRnP671Th4Ufr3y+385WVcicQxrWUwEWf8EEiJ2bzYG/c3ZNLQ== X-Received: by 2002:a1c:a557:: with SMTP id o84mr4698422wme.42.1594910384285; Thu, 16 Jul 2020 07:39:44 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id c15sm8830382wme.23.2020.07.16.07.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 07:39:43 -0700 (PDT) Date: Thu, 16 Jul 2020 15:39:41 +0100 From: Lee Jones To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Daniel Thompson , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig , Peter Ujfalusi , Tomi Valkeinen Subject: Re: [PATCH v4 05/20] backlight: improve backlight_device documentation Message-ID: <20200716143941.GS3165313@dell> References: <20200703184546.144664-1-sam@ravnborg.org> <20200703184546.144664-6-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200703184546.144664-6-sam@ravnborg.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 03 Jul 2020, Sam Ravnborg wrote: > Improve the documentation for backlight_device and > adapt it to kernel-doc style. > > The updated documentation is more strict on how locking is used. > With the update neither update_lock nor ops_lock may be used > outside the backlight core. > This restriction was introduced to keep the locking simple > by keeping it in the core. > It was verified that this documents the current state by renaming > update_lock => bl_update_lock and ops_lock => bl_ops_lock. > The rename did not reveal any uses outside the backlight core. > The rename is NOT part of this patch. > > v3: > - Update changelog to explain locking details (Daniel) > > v2: > - Add short intro to all fields (Daniel) > - Updated description of update_lock (Daniel) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Emil Velikov > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > include/linux/backlight.h | 72 ++++++++++++++++++++++++++------------- > 1 file changed, 49 insertions(+), 23 deletions(-) Some of these do not apply cleanly. Please collect the *-bys already received, rebase and resubmit. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 05/20] backlight: improve backlight_device documentation Date: Thu, 16 Jul 2020 15:39:41 +0100 Message-ID: <20200716143941.GS3165313@dell> References: <20200703184546.144664-1-sam@ravnborg.org> <20200703184546.144664-6-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728949AbgGPOjq (ORCPT ); Thu, 16 Jul 2020 10:39:46 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAC48C061755 for ; Thu, 16 Jul 2020 07:39:45 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f18so11833541wml.3 for ; Thu, 16 Jul 2020 07:39:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20200703184546.144664-6-sam@ravnborg.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Daniel Thompson , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann On Fri, 03 Jul 2020, Sam Ravnborg wrote: > Improve the documentation for backlight_device and > adapt it to kernel-doc style. > > The updated documentation is more strict on how locking is used. > With the update neither update_lock nor ops_lock may be used > outside the backlight core. > This restriction was introduced to keep the locking simple > by keeping it in the core. > It was verified that this documents the current state by renaming > update_lock => bl_update_lock and ops_lock => bl_ops_lock. > The rename did not reveal any uses outside the backlight core. > The rename is NOT part of this patch. > > v3: > - Update changelog to explain locking details (Daniel) > > v2: > - Add short intro to all fields (Daniel) > - Updated description of update_lock (Daniel) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Emil Velikov > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > include/linux/backlight.h | 72 ++++++++++++++++++++++++++------------- > 1 file changed, 49 insertions(+), 23 deletions(-) Some of these do not apply cleanly. Please collect the *-bys already received, rebase and resubmit. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E374BC433ED for ; Thu, 16 Jul 2020 14:39:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B88E6206F4 for ; Thu, 16 Jul 2020 14:39:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xRTuTBfa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B88E6206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 493286EC67; Thu, 16 Jul 2020 14:39:47 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE5046EC67 for ; Thu, 16 Jul 2020 14:39:45 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id f139so11847887wmf.5 for ; Thu, 16 Jul 2020 07:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=amD6wrTVFFwDbb/9Gfx9BmB+NGg+A9qoz+nxoVL9uN4=; b=xRTuTBfasRD7U+3n7RQKolbc3Bc4VHhuoEMK05/P8zvoGyzO5gW8v0aOgRwGxElcyu y89eoS5pzHxnGr5bEt0QhudSLUFK8Gup2vFYemqo/fWrMxdjuw5SRyzIAh938yqv2ipN gjxH+dr60+qqFEEhsCkw/G5yQ/vcnfsTLZgSu4Z5gmeyRNrY1d1Oa0t8IXw6HIrgcsZi GbRAkSFAO10W478H4GClKk84sWLv7J6mbEFZ3hlp3C+i59NmaNLrfnOWJ/rVqzfliV9t bXzgj3Y4Bp1CDV9s6TSHLhFgCLIdjDrmCYR1li5djNwJlnra6IxiFU76L2Tpm/rQKti3 kvlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=amD6wrTVFFwDbb/9Gfx9BmB+NGg+A9qoz+nxoVL9uN4=; b=btUFm15tOwpE481jLQ/5vH8p4NqSt6rGLpjlU6Ha5qsVBNPjtckjgunCWvJWfMmDbE SIs3IdjcmEWNu76crxvbw4nHrAfN0Yz6RPFw5bGEtwE7LExbMgsJL9Go/sO0KxpwaRw2 jSKuTUOGlXHLzankER4TeF7a1aRDX8ENs27uJsD78S/ib6Aa7UJsbKLXtV9bb/haK46R LSI2X8Lpw6nKifKsf0NK2oN8UyrrqtB1SD1u6iGHgbhgtvKca4koC/GzpxwUif7QrwJk r5v87prYRf6Fv31IRoCAuW3y1SRBShfC6p9bSK0NSTHKlEhT1M6B9A/eT/nGyduvD6dN x8tA== X-Gm-Message-State: AOAM531UAXFnuQMB7yy6yPZG25C8ocv56JTfiGwJ1K3T6BoHWbsuYuxq ae4dQJhRGC7q64Nj4PXhziXp4Q== X-Google-Smtp-Source: ABdhPJx3HKsrJ856ANN56k2CwqUedRnP671Th4Ufr3y+385WVcicQxrWUwEWf8EEiJ2bzYG/c3ZNLQ== X-Received: by 2002:a1c:a557:: with SMTP id o84mr4698422wme.42.1594910384285; Thu, 16 Jul 2020 07:39:44 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id c15sm8830382wme.23.2020.07.16.07.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 07:39:43 -0700 (PDT) Date: Thu, 16 Jul 2020 15:39:41 +0100 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH v4 05/20] backlight: improve backlight_device documentation Message-ID: <20200716143941.GS3165313@dell> References: <20200703184546.144664-1-sam@ravnborg.org> <20200703184546.144664-6-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200703184546.144664-6-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Bjorn Andersson , Peter Ujfalusi , Thierry Reding , Daniel Thompson , Jonathan Corbet , Tomi Valkeinen , Uwe Kleine-Konig , linux-pwm@vger.kernel.org, Michael Hennerich , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, Support Opensource , Jingoo Han , Emil Velikov , Andy Gross , Thomas Zimmermann , patches@opensource.cirrus.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAwMyBKdWwgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBJbXByb3ZlIHRoZSBk b2N1bWVudGF0aW9uIGZvciBiYWNrbGlnaHRfZGV2aWNlIGFuZAo+IGFkYXB0IGl0IHRvIGtlcm5l bC1kb2Mgc3R5bGUuCj4gCj4gVGhlIHVwZGF0ZWQgZG9jdW1lbnRhdGlvbiBpcyBtb3JlIHN0cmlj dCBvbiBob3cgbG9ja2luZyBpcyB1c2VkLgo+IFdpdGggdGhlIHVwZGF0ZSBuZWl0aGVyIHVwZGF0 ZV9sb2NrIG5vciBvcHNfbG9jayBtYXkgYmUgdXNlZAo+IG91dHNpZGUgdGhlIGJhY2tsaWdodCBj b3JlLgo+IFRoaXMgcmVzdHJpY3Rpb24gd2FzIGludHJvZHVjZWQgdG8ga2VlcCB0aGUgbG9ja2lu ZyBzaW1wbGUKPiBieSBrZWVwaW5nIGl0IGluIHRoZSBjb3JlLgo+IEl0IHdhcyB2ZXJpZmllZCB0 aGF0IHRoaXMgZG9jdW1lbnRzIHRoZSBjdXJyZW50IHN0YXRlIGJ5IHJlbmFtaW5nCj4gdXBkYXRl X2xvY2sgPT4gYmxfdXBkYXRlX2xvY2sgYW5kIG9wc19sb2NrID0+IGJsX29wc19sb2NrLgo+IFRo ZSByZW5hbWUgZGlkIG5vdCByZXZlYWwgYW55IHVzZXMgb3V0c2lkZSB0aGUgYmFja2xpZ2h0IGNv cmUuCj4gVGhlIHJlbmFtZSBpcyBOT1QgcGFydCBvZiB0aGlzIHBhdGNoLgo+IAo+IHYzOgo+ICAg LSBVcGRhdGUgY2hhbmdlbG9nIHRvIGV4cGxhaW4gbG9ja2luZyBkZXRhaWxzIChEYW5pZWwpCj4g Cj4gdjI6Cj4gICAtIEFkZCBzaG9ydCBpbnRybyB0byBhbGwgZmllbGRzIChEYW5pZWwpCj4gICAt IFVwZGF0ZWQgZGVzY3JpcHRpb24gb2YgdXBkYXRlX2xvY2sgKERhbmllbCkKPiAKPiBTaWduZWQt b2ZmLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gUmV2aWV3ZWQtYnk6IEVt aWwgVmVsaWtvdiA8ZW1pbC5sLnZlbGlrb3ZAZ21haWwuY29tPgo+IENjOiBMZWUgSm9uZXMgPGxl ZS5qb25lc0BsaW5hcm8ub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNv bkBsaW5hcm8ub3JnPgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiAt LS0KPiAgaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaCB8IDcyICsrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwg MjMgZGVsZXRpb25zKC0pCgpTb21lIG9mIHRoZXNlIGRvIG5vdCBhcHBseSBjbGVhbmx5LgoKUGxl YXNlIGNvbGxlY3QgdGhlICotYnlzIGFscmVhZHkgcmVjZWl2ZWQsIHJlYmFzZSBhbmQgcmVzdWJt aXQuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERl dmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK