From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BA9C433E0 for ; Thu, 16 Jul 2020 16:10:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED78320739 for ; Thu, 16 Jul 2020 16:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED78320739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B6zjx1yhCzDr7k for ; Fri, 17 Jul 2020 02:10:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=msuchanek@suse.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B6zgH1RvBzDqC3 for ; Fri, 17 Jul 2020 02:07:42 +1000 (AEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4015EAB89; Thu, 16 Jul 2020 16:07:42 +0000 (UTC) Date: Thu, 16 Jul 2020 18:07:37 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Thomas Falcon Subject: Re: [PATCH net-next] ibmvnic: Increase driver logging Message-ID: <20200716160736.GI32107@kitsune.suse.cz> References: <1594857115-22380-1-git-send-email-tlfalcon@linux.ibm.com> <20200715170632.11f0bf19@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200715.182956.490791427431304861.davem@davemloft.net> <9c9d6e46-240b-8513-08e4-e1c7556cb3c8@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c9d6e46-240b-8513-08e4-e1c7556cb3c8@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drt@linux.ibm.com, kuba@kernel.org, linuxppc-dev@lists.ozlabs.org, David Miller , netdev@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote: > > On 7/15/20 8:29 PM, David Miller wrote: > > From: Jakub Kicinski > > Date: Wed, 15 Jul 2020 17:06:32 -0700 > > > > > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote: > > > > free_netdev(netdev); > > > > dev_set_drvdata(&dev->dev, NULL); > > > > + netdev_info(netdev, "VNIC client device has been successfully removed.\n"); > > > A step too far, perhaps. > > > > > > In general this patch looks a little questionable IMHO, this amount of > > > logging output is not commonly seen in drivers. All the the info > > > messages are just static text, not even carrying any extra information. > > > In an era of ftrace, and bpftrace, do we really need this? > > Agreed, this is too much. This is debugging, and thus suitable for tracing > > facilities, at best. > > Thanks for your feedback. I see now that I was overly aggressive with this > patch to be sure, but it would help with narrowing down problems at a first > glance, should they arise. The driver in its current state logs very little > of what is it doing without the use of additional debugging or tracing > facilities. Would it be worth it to pursue a less aggressive version or > would that be dead on arrival? What are acceptable driver operations to log > at this level? Also would it be advisable to add the messages as pr_dbg to be enabled on demand? Thanks Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D7CC433E2 for ; Thu, 16 Jul 2020 16:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6023D20739 for ; Thu, 16 Jul 2020 16:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgGPQHj (ORCPT ); Thu, 16 Jul 2020 12:07:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:33686 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728837AbgGPQHj (ORCPT ); Thu, 16 Jul 2020 12:07:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4015EAB89; Thu, 16 Jul 2020 16:07:42 +0000 (UTC) Date: Thu, 16 Jul 2020 18:07:37 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Thomas Falcon Cc: David Miller , kuba@kernel.org, drt@linux.ibm.com, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net-next] ibmvnic: Increase driver logging Message-ID: <20200716160736.GI32107@kitsune.suse.cz> References: <1594857115-22380-1-git-send-email-tlfalcon@linux.ibm.com> <20200715170632.11f0bf19@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200715.182956.490791427431304861.davem@davemloft.net> <9c9d6e46-240b-8513-08e4-e1c7556cb3c8@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c9d6e46-240b-8513-08e4-e1c7556cb3c8@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote: > > On 7/15/20 8:29 PM, David Miller wrote: > > From: Jakub Kicinski > > Date: Wed, 15 Jul 2020 17:06:32 -0700 > > > > > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote: > > > > free_netdev(netdev); > > > > dev_set_drvdata(&dev->dev, NULL); > > > > + netdev_info(netdev, "VNIC client device has been successfully removed.\n"); > > > A step too far, perhaps. > > > > > > In general this patch looks a little questionable IMHO, this amount of > > > logging output is not commonly seen in drivers. All the the info > > > messages are just static text, not even carrying any extra information. > > > In an era of ftrace, and bpftrace, do we really need this? > > Agreed, this is too much. This is debugging, and thus suitable for tracing > > facilities, at best. > > Thanks for your feedback. I see now that I was overly aggressive with this > patch to be sure, but it would help with narrowing down problems at a first > glance, should they arise. The driver in its current state logs very little > of what is it doing without the use of additional debugging or tracing > facilities. Would it be worth it to pursue a less aggressive version or > would that be dead on arrival? What are acceptable driver operations to log > at this level? Also would it be advisable to add the messages as pr_dbg to be enabled on demand? Thanks Michal