From: Pavel Machek <pavel@ucw.cz>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: add NCT6795D driver
Date: Fri, 17 Jul 2020 09:44:10 +0200 [thread overview]
Message-ID: <20200717074410.GA8895@amd> (raw)
In-Reply-To: <CAAVeFuJQCp7Fpqx3nUHMy29Jw1pLNoQtxRw3qxfEf3YKnrm0fw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
Hi!
> > >>> Add support for the LED feature of the NCT6795D chip found on some
> > >>> motherboards, notably MSI ones. The LEDs are typically used using a
> > >>> RGB connector so this driver creates one LED device for each color
> > >>> component.
> > >>
> > >> Ok, let me take a look. What entries does it present in /sys?
> > >
> > > Right now these 3 directories in /sys/class/leds:
> > >
> > > nct6795d:blue:
> > > nct6795d:green:
> > > nct6795d:red:
> > >
> > > with the usual suspects `brightness` and `max_brightness` in each. I
> > > am not 100% sure I got the names right so please let me know if that
> > > is not correct.
> >
> > You miss LED function, that should be in the second section.
third section?
> The reason for not having a function at the moment is that I took a
> look at include/dt-bindings/leds/common.h and could not find any
> function that could reasonably apply. This basically controls a RGB
> connector on the motherboard which serves no particular function - you
> can plug a RGB fan or anything else you want and control it in any
> fashion. Is there a function that applies to this use-case?
This is normally used for motherboard lightning, right? I believe this
is getting common on gaming boards, and we want common support for
that.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-17 7:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 13:41 [PATCH] leds: add NCT6795D driver Alexandre Courbot
2020-07-14 22:33 ` Pavel Machek
2020-07-15 1:54 ` Alexandre Courbot
2020-07-15 19:32 ` Jacek Anaszewski
2020-07-17 1:00 ` Alexandre Courbot
2020-07-17 7:44 ` Pavel Machek [this message]
2020-07-17 19:25 ` Jacek Anaszewski
2020-07-20 13:07 ` Alexandre Courbot
2020-07-20 13:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717074410.GA8895@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=gnurou@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.