All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	kan.liang@linux.intel.com, len.brown@intel.com
Subject: Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes
Date: Fri, 17 Jul 2020 10:33:28 +0200	[thread overview]
Message-ID: <20200717083328.GA528602@krava> (raw)
In-Reply-To: <20200716151859.6854-1-rui.zhang@intel.com>

On Thu, Jul 16, 2020 at 11:18:57PM +0800, Zhang Rui wrote:
> This fixes a problem introduced by
> commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface")
> that perf event sysfs attributes for psys RAPL domain are missing.
> 
> Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface")
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> Reviewed-by: Len Brown <len.brown@intel.com>
> ---
>  arch/x86/events/rapl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
> index 0f2bf59f4354..51ff9a3618c9 100644
> --- a/arch/x86/events/rapl.c
> +++ b/arch/x86/events/rapl.c
> @@ -665,7 +665,7 @@ static const struct attribute_group *rapl_attr_update[] = {
>  	&rapl_events_pkg_group,
>  	&rapl_events_ram_group,
>  	&rapl_events_gpu_group,
> -	&rapl_events_gpu_group,
> +	&rapl_events_psys_group,

I did copy & paste but did not change to psys :-\

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

>  	NULL,
>  };
>  
> -- 
> 2.17.1
> 


  parent reply	other threads:[~2020-07-17  8:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 15:18 [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes Zhang Rui
2020-07-16 15:18 ` [PATCH 2/3] perf/x86/rapl: Support multiple rapl unit quirks Zhang Rui
2020-07-16 15:18 ` [PATCH 3/3] perf/x86/rapl: Add support for Intel SPR platform Zhang Rui
2020-07-17  8:33 ` Jiri Olsa [this message]
2020-07-28 13:16   ` [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717083328.GA528602@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=kan.liang@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.