From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C7BEC433DF for ; Fri, 17 Jul 2020 09:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DEAA22B48 for ; Fri, 17 Jul 2020 09:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O4aJA02R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726238AbgGQJEt (ORCPT ); Fri, 17 Jul 2020 05:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgGQJEs (ORCPT ); Fri, 17 Jul 2020 05:04:48 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85E92C08C5C0 for ; Fri, 17 Jul 2020 02:04:48 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id j18so13884373wmi.3 for ; Fri, 17 Jul 2020 02:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fPSSCrAK7kPj/3cR+AEeJBFF+6hUfCRiIV39zPdcLSE=; b=O4aJA02RbEUNRYShZ9OCvGUwjUljzvi5eoJEED68ar8LSSGYFPgiHMpKHtBN7VyOp4 NOV9q9vwQxsgJAZL3OJlMdJkjfPMuQe2LGPv4co156NqoxrK+6SRZW8Wo+aCYGEODCp4 hvmOxM3Bes5RWZmIwLbajglchKuGZdob0pJuIM8YU9ncb7cs9TgGhk7HbZk9UQ8u/UEC mz+rCPoZGx70S04GkUp/As33ikyWh1KZl/FIMt36kT/ICYHeiZKV2oHVKOpRBJnGgbGX fmX86r+0n105cuNPh3O9ueYdMbPYpRqtxsEG7AgJkHuU6K5zzc5UrL6tOWiSqFDWYjxW sp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fPSSCrAK7kPj/3cR+AEeJBFF+6hUfCRiIV39zPdcLSE=; b=M42+tfKjeSNr5dTMI/P43FA+ABXQFp5TVPnzgOrF/vi9HbAoMONahfZaHDM3uu+2Kj K/EYRtas0jqf8kcwm/TSueY5elLSGPc4LMXkIvdhIYQM/EbYjY95YuXGy2+3Ppz1l1ye FefPndZErvPOqBwpHT/TMc4dsCxRV25Y1C5xtZR7id2ZVO1Z597Wj1ND29Bn4bWX8odw e256be2hr+JWHlJEn+lWoIVnA8TB9X76qGA/JN3uMQLcEkBiUUhHm73wnJNKeZTL27U2 RxdY07elKQzDrmp+aUCW7AcloTI9ZR2yys7H7scuCHXFoToX6l5DesHF0icpJojDzKcZ NMog== X-Gm-Message-State: AOAM533dGIOVf+HzF2Q2a2k6QIdokOX5EQHYfhpNAjkovtT0WHHUQ5bH F6ai82zUmYCs0Q6YicAeAcA6Uw== X-Google-Smtp-Source: ABdhPJzkK5qp5DNZw7zuFk95PVjoD11yTntrP86JXL7TaTDkweQMjN1bqTSOyXRfkbtW9F+epTqZBg== X-Received: by 2002:a1c:303:: with SMTP id 3mr8540077wmd.180.1594976687019; Fri, 17 Jul 2020 02:04:47 -0700 (PDT) Received: from dell ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id i67sm12821715wma.12.2020.07.17.02.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 02:04:46 -0700 (PDT) Date: Fri, 17 Jul 2020 10:04:44 +0100 From: Lee Jones To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver Message-ID: <20200717090444.GE3165313@dell> References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-3-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200706175353.16404-3-michael@walle.cc> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 06 Jul 2020, Michael Walle wrote: > There are I2C devices which contain several different functions but > doesn't require any special access functions. For these kind of drivers > an I2C regmap should be enough. > > Create an I2C driver which creates an I2C regmap and enumerates its > children. If a device wants to use this as its MFD core driver, it has > to add an individual compatible string. It may provide its own regmap > configuration. > > Subdevices can use dev_get_regmap() on the parent to get their regmap > instance. > > Signed-off-by: Michael Walle > --- > Changes since v4: > - new patch. Lee, please bear with me. I didn't want to delay the > new version (where a lot of remarks on the other patches were > addressed) even more, just because we haven't figured out how > to deal with the MFD part. So for now, I've included this one. > > drivers/mfd/Kconfig | 9 +++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/simple-mfd-i2c.c | 50 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+) > create mode 100644 drivers/mfd/simple-mfd-i2c.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 33df0837ab41..f1536a710aca 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE > To compile this driver as a module, choose M here: the > module will be called si476x-core. > > +config MFD_SIMPLE_MFD_I2C > + tristate "Simple regmap based I2C devices" > + depends on I2C > + select MFD_CORE > + select REGMAP_I2C > + help > + This is a consolidated driver for all MFD devices which are > + basically just a regmap bus driver. > + > config MFD_SM501 > tristate "Silicon Motion SM501" > depends on HAS_DMA > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index a60e5f835283..78d24a3e7c9e 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -264,3 +264,4 @@ obj-$(CONFIG_MFD_STMFX) += stmfx.o > obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > +obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > new file mode 100644 > index 000000000000..1fdca89964b1 > --- /dev/null > +++ b/drivers/mfd/simple-mfd-i2c.c > @@ -0,0 +1,49 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I'm pretty sure you do not require all of these headers. > +struct simple_mfd_i2c_config { > + const struct regmap_config *regmap_config; > +}; No need for this yet I feel. Let's keep it as simple as possible. > +static const struct regmap_config simple_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > +}; > + > +static int simple_mfd_i2c_probe(struct i2c_client *i2c) > +{ > + const struct regmap_config *regmap_config = &simple_regmap_config; > + const struct simple_mfd_i2c_config *config; > + struct regmap *regmap; > + > + config = device_get_match_data(&i2c->dev); Have this return regmap_config. > + if (config && config->regmap_config) > + regmap_config = config->regmap_config; > + > + regmap = devm_regmap_init_i2c(i2c, regmap_config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + return devm_of_platform_populate(&i2c->dev); > +} > + > +static const struct of_device_id simple_mfd_i2c_of_match[] = { > + {} > +}; > + > +static struct i2c_driver simple_mfd_i2c_driver = { > + .probe_new = simple_mfd_i2c_probe, > + .driver = { > + .name = "simple-mfd-i2c", > + .of_match_table = simple_mfd_i2c_of_match, > + }, > +}; > +builtin_i2c_driver(simple_mfd_i2c_driver); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver Date: Fri, 17 Jul 2020 10:04:44 +0100 Message-ID: <20200717090444.GE3165313@dell> References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-3-michael@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200706175353.16404-3-michael-QKn5cuLxLXY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Walle Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown List-Id: linux-pwm@vger.kernel.org On Mon, 06 Jul 2020, Michael Walle wrote: > There are I2C devices which contain several different functions but > doesn't require any special access functions. For these kind of drivers > an I2C regmap should be enough. > > Create an I2C driver which creates an I2C regmap and enumerates its > children. If a device wants to use this as its MFD core driver, it has > to add an individual compatible string. It may provide its own regmap > configuration. > > Subdevices can use dev_get_regmap() on the parent to get their regmap > instance. > > Signed-off-by: Michael Walle > --- > Changes since v4: > - new patch. Lee, please bear with me. I didn't want to delay the > new version (where a lot of remarks on the other patches were > addressed) even more, just because we haven't figured out how > to deal with the MFD part. So for now, I've included this one. > > drivers/mfd/Kconfig | 9 +++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/simple-mfd-i2c.c | 50 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+) > create mode 100644 drivers/mfd/simple-mfd-i2c.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 33df0837ab41..f1536a710aca 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE > To compile this driver as a module, choose M here: the > module will be called si476x-core. > > +config MFD_SIMPLE_MFD_I2C > + tristate "Simple regmap based I2C devices" > + depends on I2C > + select MFD_CORE > + select REGMAP_I2C > + help > + This is a consolidated driver for all MFD devices which are > + basically just a regmap bus driver. > + > config MFD_SM501 > tristate "Silicon Motion SM501" > depends on HAS_DMA > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index a60e5f835283..78d24a3e7c9e 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -264,3 +264,4 @@ obj-$(CONFIG_MFD_STMFX) += stmfx.o > obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > +obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > new file mode 100644 > index 000000000000..1fdca89964b1 > --- /dev/null > +++ b/drivers/mfd/simple-mfd-i2c.c > @@ -0,0 +1,49 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I'm pretty sure you do not require all of these headers. > +struct simple_mfd_i2c_config { > + const struct regmap_config *regmap_config; > +}; No need for this yet I feel. Let's keep it as simple as possible. > +static const struct regmap_config simple_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > +}; > + > +static int simple_mfd_i2c_probe(struct i2c_client *i2c) > +{ > + const struct regmap_config *regmap_config = &simple_regmap_config; > + const struct simple_mfd_i2c_config *config; > + struct regmap *regmap; > + > + config = device_get_match_data(&i2c->dev); Have this return regmap_config. > + if (config && config->regmap_config) > + regmap_config = config->regmap_config; > + > + regmap = devm_regmap_init_i2c(i2c, regmap_config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + return devm_of_platform_populate(&i2c->dev); > +} > + > +static const struct of_device_id simple_mfd_i2c_of_match[] = { > + {} > +}; > + > +static struct i2c_driver simple_mfd_i2c_driver = { > + .probe_new = simple_mfd_i2c_probe, > + .driver = { > + .name = "simple-mfd-i2c", > + .of_match_table = simple_mfd_i2c_of_match, > + }, > +}; > +builtin_i2c_driver(simple_mfd_i2c_driver); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F16C433E7 for ; Fri, 17 Jul 2020 09:07:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D06F2070E for ; Fri, 17 Jul 2020 09:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xWcSB/Jp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O4aJA02R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D06F2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6Cy3P2fEbEibNWUb8bpBqlr2y3XUhTjT/PWum86ZWNc=; b=xWcSB/JpggMnY4RTT+YOCMf6+ /YzUviXMAKvbEEvsa0jaQbobZxUVp53RxyfwicXARlOvS1O6kGsJzczN6/Gr2NiIo3cOEbSTYd2uT Nnv+QUzFDJ5QRJJ6ug0bIaOCuV/R312wGVQe0epHecw5msM1EqvUG8xdXPPhz0aGxkpPphnqhXUhF FeupFxzE0HeH/9du+gkd26h9ZcfXCaYTHQBfi0e7w2M1FV9YrX3PishcnKlTT1I4JARJbe0GF79IQ BHQnmBasjklecyL2vSWEpuGywgW99mIwPsIgneKhi2NgbMDDlENq0T/C/9G4Xt9Yr5VU+MgO27BuN BQNf+/1Yg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwMIn-0005Bp-Aq; Fri, 17 Jul 2020 09:05:09 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwMIS-00051M-8f for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 09:04:52 +0000 Received: by mail-wm1-x343.google.com with SMTP id g75so13872585wme.5 for ; Fri, 17 Jul 2020 02:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fPSSCrAK7kPj/3cR+AEeJBFF+6hUfCRiIV39zPdcLSE=; b=O4aJA02RbEUNRYShZ9OCvGUwjUljzvi5eoJEED68ar8LSSGYFPgiHMpKHtBN7VyOp4 NOV9q9vwQxsgJAZL3OJlMdJkjfPMuQe2LGPv4co156NqoxrK+6SRZW8Wo+aCYGEODCp4 hvmOxM3Bes5RWZmIwLbajglchKuGZdob0pJuIM8YU9ncb7cs9TgGhk7HbZk9UQ8u/UEC mz+rCPoZGx70S04GkUp/As33ikyWh1KZl/FIMt36kT/ICYHeiZKV2oHVKOpRBJnGgbGX fmX86r+0n105cuNPh3O9ueYdMbPYpRqtxsEG7AgJkHuU6K5zzc5UrL6tOWiSqFDWYjxW sp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fPSSCrAK7kPj/3cR+AEeJBFF+6hUfCRiIV39zPdcLSE=; b=ID4CU9TDkw+7TN/kZGaSjYzHKOvuoWOvV4t4byTy0obiImQ1Rz6ffO2sVdeqgj7M1V TG+O3dJgq+nnvbLJFegDgB8tAp9XlRuCOv34vhlS3u7VDOektX7a0rpW70eAvSWtjPDW +caFr4xVS99H9fHxUqH0R5s03e4mr0eAxVwzD5sVIM25Fdmef3NlZKi8bKBeYk3FEOQp RLDoHoe3mfZ4CAJwWfG/cW1mUgLV7RJiE3czU7ZMgdp+GHGXcLWvmm34Q1vN0OLpezQn HX55KipWC+ik7L3ZynLJ2PlYD/ivRr1oR7tD9+8Ny1/l0SR4tYeR31ASgC7WkZ7ecIdL CzjQ== X-Gm-Message-State: AOAM530g+MvJijf4ElcgoE/LGhuEQ8s6VuaFiwd1uUPk1H+M3X3w5Xhp JMyerjqrufHmHgJmJJ//AXYXhQ== X-Google-Smtp-Source: ABdhPJzkK5qp5DNZw7zuFk95PVjoD11yTntrP86JXL7TaTDkweQMjN1bqTSOyXRfkbtW9F+epTqZBg== X-Received: by 2002:a1c:303:: with SMTP id 3mr8540077wmd.180.1594976687019; Fri, 17 Jul 2020 02:04:47 -0700 (PDT) Received: from dell ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id i67sm12821715wma.12.2020.07.17.02.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 02:04:46 -0700 (PDT) Date: Fri, 17 Jul 2020 10:04:44 +0100 From: Lee Jones To: Michael Walle Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver Message-ID: <20200717090444.GE3165313@dell> References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-3-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200706175353.16404-3-michael@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_050449_284318_14D35587 X-CRM114-Status: GOOD ( 28.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Linus Walleij , Thierry Reding , Jason Cooper , Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , Shawn Guo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNiBKdWwgMjAyMCwgTWljaGFlbCBXYWxsZSB3cm90ZToKCj4gVGhlcmUgYXJlIEky QyBkZXZpY2VzIHdoaWNoIGNvbnRhaW4gc2V2ZXJhbCBkaWZmZXJlbnQgZnVuY3Rpb25zIGJ1dAo+ IGRvZXNuJ3QgcmVxdWlyZSBhbnkgc3BlY2lhbCBhY2Nlc3MgZnVuY3Rpb25zLiBGb3IgdGhlc2Ug a2luZCBvZiBkcml2ZXJzCj4gYW4gSTJDIHJlZ21hcCBzaG91bGQgYmUgZW5vdWdoLgo+IAo+IENy ZWF0ZSBhbiBJMkMgZHJpdmVyIHdoaWNoIGNyZWF0ZXMgYW4gSTJDIHJlZ21hcCBhbmQgZW51bWVy YXRlcyBpdHMKPiBjaGlsZHJlbi4gSWYgYSBkZXZpY2Ugd2FudHMgdG8gdXNlIHRoaXMgYXMgaXRz IE1GRCBjb3JlIGRyaXZlciwgaXQgaGFzCj4gdG8gYWRkIGFuIGluZGl2aWR1YWwgY29tcGF0aWJs ZSBzdHJpbmcuIEl0IG1heSBwcm92aWRlIGl0cyBvd24gcmVnbWFwCj4gY29uZmlndXJhdGlvbi4K PiAKPiBTdWJkZXZpY2VzIGNhbiB1c2UgZGV2X2dldF9yZWdtYXAoKSBvbiB0aGUgcGFyZW50IHRv IGdldCB0aGVpciByZWdtYXAKPiBpbnN0YW5jZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVs IFdhbGxlIDxtaWNoYWVsQHdhbGxlLmNjPgo+IC0tLQo+IENoYW5nZXMgc2luY2UgdjQ6Cj4gIC0g bmV3IHBhdGNoLiBMZWUsIHBsZWFzZSBiZWFyIHdpdGggbWUuIEkgZGlkbid0IHdhbnQgdG8gZGVs YXkgdGhlCj4gICAgbmV3IHZlcnNpb24gKHdoZXJlIGEgbG90IG9mIHJlbWFya3Mgb24gdGhlIG90 aGVyIHBhdGNoZXMgd2VyZQo+ICAgIGFkZHJlc3NlZCkgZXZlbiBtb3JlLCBqdXN0IGJlY2F1c2Ug d2UgaGF2ZW4ndCBmaWd1cmVkIG91dCBob3cKPiAgICB0byBkZWFsIHdpdGggdGhlIE1GRCBwYXJ0 LiBTbyBmb3Igbm93LCBJJ3ZlIGluY2x1ZGVkIHRoaXMgb25lLgo+IAo+ICBkcml2ZXJzL21mZC9L Y29uZmlnICAgICAgICAgIHwgIDkgKysrKysrKwo+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAg ICAgIHwgIDEgKwo+ICBkcml2ZXJzL21mZC9zaW1wbGUtbWZkLWkyYy5jIHwgNTAgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgNjAgaW5zZXJ0 aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZmQvc2ltcGxlLW1mZC1pMmMu Ywo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmlnIGIvZHJpdmVycy9tZmQvS2Nv bmZpZwo+IGluZGV4IDMzZGYwODM3YWI0MS4uZjE1MzZhNzEwYWNhIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbWZkL0tjb25maWcKPiArKysgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gQEAgLTExNjIs NiArMTE2MiwxNSBAQCBjb25maWcgTUZEX1NJNDc2WF9DT1JFCj4gIAkgIFRvIGNvbXBpbGUgdGhp cyBkcml2ZXIgYXMgYSBtb2R1bGUsIGNob29zZSBNIGhlcmU6IHRoZQo+ICAJICBtb2R1bGUgd2ls bCBiZSBjYWxsZWQgc2k0NzZ4LWNvcmUuCj4gIAo+ICtjb25maWcgTUZEX1NJTVBMRV9NRkRfSTJD Cj4gKwl0cmlzdGF0ZSAiU2ltcGxlIHJlZ21hcCBiYXNlZCBJMkMgZGV2aWNlcyIKPiArCWRlcGVu ZHMgb24gSTJDCj4gKwlzZWxlY3QgTUZEX0NPUkUKPiArCXNlbGVjdCBSRUdNQVBfSTJDCj4gKwlo ZWxwCj4gKwkgIFRoaXMgaXMgYSBjb25zb2xpZGF0ZWQgZHJpdmVyIGZvciBhbGwgTUZEIGRldmlj ZXMgd2hpY2ggYXJlCj4gKwkgIGJhc2ljYWxseSBqdXN0IGEgcmVnbWFwIGJ1cyBkcml2ZXIuCj4g Kwo+ICBjb25maWcgTUZEX1NNNTAxCj4gIAl0cmlzdGF0ZSAiU2lsaWNvbiBNb3Rpb24gU001MDEi Cj4gIAlkZXBlbmRzIG9uIEhBU19ETUEKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvTWFrZWZp bGUgYi9kcml2ZXJzL21mZC9NYWtlZmlsZQo+IGluZGV4IGE2MGU1ZjgzNTI4My4uNzhkMjRhM2U3 YzllIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9t ZmQvTWFrZWZpbGUKPiBAQCAtMjY0LDMgKzI2NCw0IEBAIG9iai0kKENPTkZJR19NRkRfU1RNRlgp IAkrPSBzdG1meC5vCj4gIG9iai0kKENPTkZJR19NRkRfS0hBREFTX01DVSkgCSs9IGtoYWRhcy1t Y3Uubwo+ICAKPiAgb2JqLSQoQ09ORklHX1NHSV9NRkRfSU9DMykJKz0gaW9jMy5vCj4gK29iai0k KENPTkZJR19NRkRfU0lNUExFX01GRF9JMkMpCSs9IHNpbXBsZS1tZmQtaTJjLm8KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9tZmQvc2ltcGxlLW1mZC1pMmMuYyBiL2RyaXZlcnMvbWZkL3NpbXBsZS1t ZmQtaTJjLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMC4uMWZk Y2E4OTk2NGIxCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvbWZkL3NpbXBsZS1tZmQt aTJjLmMKPiBAQCAtMCwwICsxLDQ5IEBACj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBH UEwtMi4wLW9ubHkKPiArI2luY2x1ZGUgPGxpbnV4L2kyYy5oPgo+ICsjaW5jbHVkZSA8bGludXgv aW50ZXJydXB0Lmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPiArI2luY2x1ZGUgPGxp bnV4L21mZC9jb3JlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9tb2RfZGV2aWNldGFibGUuaD4KPiAr I2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0u aD4KPiArI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgoKSSdtIHByZXR0eSBzdXJlIHlvdSBkbyBu b3QgcmVxdWlyZSBhbGwgb2YgdGhlc2UgaGVhZGVycy4KCj4gK3N0cnVjdCBzaW1wbGVfbWZkX2ky Y19jb25maWcgewo+ICsJY29uc3Qgc3RydWN0IHJlZ21hcF9jb25maWcgKnJlZ21hcF9jb25maWc7 Cj4gK307CgpObyBuZWVkIGZvciB0aGlzIHlldCBJIGZlZWwuCgpMZXQncyBrZWVwIGl0IGFzIHNp bXBsZSBhcyBwb3NzaWJsZS4KCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyBz aW1wbGVfcmVnbWFwX2NvbmZpZyA9IHsKPiArCS5yZWdfYml0cyA9IDgsCj4gKwkudmFsX2JpdHMg PSA4LAo+ICt9Owo+ICsKPiArc3RhdGljIGludCBzaW1wbGVfbWZkX2kyY19wcm9iZShzdHJ1Y3Qg aTJjX2NsaWVudCAqaTJjKQo+ICt7Cj4gKwljb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyAqcmVn bWFwX2NvbmZpZyA9ICZzaW1wbGVfcmVnbWFwX2NvbmZpZzsKPiArCWNvbnN0IHN0cnVjdCBzaW1w bGVfbWZkX2kyY19jb25maWcgKmNvbmZpZzsKPiArCXN0cnVjdCByZWdtYXAgKnJlZ21hcDsKPiAr Cj4gKwljb25maWcgPSBkZXZpY2VfZ2V0X21hdGNoX2RhdGEoJmkyYy0+ZGV2KTsKCkhhdmUgdGhp cyByZXR1cm4gcmVnbWFwX2NvbmZpZy4KCj4gKwlpZiAoY29uZmlnICYmIGNvbmZpZy0+cmVnbWFw X2NvbmZpZykKPiArCQlyZWdtYXBfY29uZmlnID0gY29uZmlnLT5yZWdtYXBfY29uZmlnOwo+ICsK PiArCXJlZ21hcCA9IGRldm1fcmVnbWFwX2luaXRfaTJjKGkyYywgcmVnbWFwX2NvbmZpZyk7Cj4g KwlpZiAoSVNfRVJSKHJlZ21hcCkpCj4gKwkJcmV0dXJuIFBUUl9FUlIocmVnbWFwKTsKPiArCj4g KwlyZXR1cm4gZGV2bV9vZl9wbGF0Zm9ybV9wb3B1bGF0ZSgmaTJjLT5kZXYpOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBzaW1wbGVfbWZkX2kyY19vZl9tYXRj aFtdID0gewo+ICsJe30KPiArfTsKPiArCj4gK3N0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBzaW1w bGVfbWZkX2kyY19kcml2ZXIgPSB7Cj4gKwkucHJvYmVfbmV3ID0gc2ltcGxlX21mZF9pMmNfcHJv YmUsCj4gKwkuZHJpdmVyID0gewo+ICsJCS5uYW1lID0gInNpbXBsZS1tZmQtaTJjIiwKPiArCQku b2ZfbWF0Y2hfdGFibGUgPSBzaW1wbGVfbWZkX2kyY19vZl9tYXRjaCwKPiArCX0sCj4gK307Cj4g K2J1aWx0aW5faTJjX2RyaXZlcihzaW1wbGVfbWZkX2kyY19kcml2ZXIpOwoKLS0gCkxlZSBKb25l cyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMK TGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBM aW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK