From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend
Date: Fri, 17 Jul 2020 17:34:25 +0530 [thread overview]
Message-ID: <20200717120425.20947-1-anshuman.gupta@intel.com> (raw)
While i915 device is in runtime suspend, DRM connector polling
causing device to wakeup from runtime suspend.
This harm overall cpu idle statistics, therefore
disabling polling while in runtime suspend.
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5fd5af4bc855..1229c72f19c9 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1595,6 +1595,8 @@ static int intel_runtime_suspend(struct device *kdev)
disable_rpm_wakeref_asserts(rpm);
+ drm_kms_helper_poll_disable(&dev_priv->drm);
+
/*
* We are safe here against re-faults, since the fault handler takes
* an RPM reference.
@@ -1699,6 +1701,8 @@ static int intel_runtime_resume(struct device *kdev)
*/
intel_gt_runtime_resume(&dev_priv->gt);
+ drm_kms_helper_poll_enable(&dev_priv->drm);
+
/*
* On VLV/CHV display interrupts are part of the display
* power well, so hpd is reinitialized from there. For
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-07-17 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 12:04 Anshuman Gupta [this message]
2020-07-17 12:25 ` [Intel-gfx] [RFC] drm/i915: Disable connector polling at runtime suspend Chris Wilson
2020-07-17 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-07-17 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-17 14:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-21 13:32 ` [Intel-gfx] [RFC] " Imre Deak
2020-07-21 16:34 ` Anshuman Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717120425.20947-1-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.