From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0365488784187618838==" MIME-Version: 1.0 From: Masami Hiramatsu To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 1/3] kgdb: Honour the kprobe blocklist when setting breakpoints Date: Fri, 17 Jul 2020 17:13:15 +0900 Message-ID: <20200717171315.bdb7b5b230b0ed5aeeab8f71@kernel.org> In-Reply-To: <202007170416.HyFlooXO%lkp@intel.com> List-Id: --===============0365488784187618838== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, 17 Jul 2020 04:48:52 +0800 kernel test robot wrote: > Hi Daniel, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on linus/master] > [also build test ERROR on kgdb/kgdb-next pmladek/for-next v5.8-rc5 next-2= 0200716] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Daniel-Thompson/kgdb-Hon= our-the-kprobe-blacklist-when-setting-breakpoints/20200716-232506 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t f8456690ba8eb18ea4714e68554e242a04f65cff > config: arm64-allyesconfig (attached as .config) > compiler: aarch64-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros= s ARCH=3Darm64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > >> drivers/net/wireless/intel/ipw2x00/ipw2100.c:3794:16: error: conflicti= ng types for 'show_registers' > 3794 | static ssize_t show_registers(struct device *d, struct device_= attribute *attr, > | ^~~~~~~~~~~~~~ > In file included from include/linux/kgdb.h:19, > from arch/arm64/include/asm/cacheflush.h:11, > from include/linux/highmem.h:12, > from include/linux/pagemap.h:11, > from include/linux/blkdev.h:16, > from include/linux/blk-cgroup.h:23, > from include/linux/writeback.h:14, > from include/linux/memcontrol.h:22, > from include/net/sock.h:53, > from include/linux/tcp.h:19, > from drivers/net/wireless/intel/ipw2x00/ipw2100.c:144: > include/linux/kprobes.h:230:13: note: previous declaration of 'show_re= gisters' was here > 230 | extern void show_registers(struct pt_regs *regs); > | ^~~~~~~~~~~~~~ It seems this function had been introduced before git, and forgot to remove= d from kprobes.h. OK, commit 57da8b960b9a ("x86: Avoid double stack traces with show_regs()")= renamed show_registers() to show_regs() but forgot to remove old prototype in kprob= es.h. Anyway, we should remove it because kprobes doesn't use it anymore. Thank you, -- = Masami Hiramatsu --===============0365488784187618838==--