From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
slongerbeam@gmail.com, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
linux-omap@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>, "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Tero Kristo" <t-kristo@ti.com>, "Nishanth Menon" <nm@ti.com>
Subject: Re: [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes
Date: Fri, 17 Jul 2020 23:48:29 +0300 [thread overview]
Message-ID: <20200717204829.GI5961@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200717132859.237120-8-jacopo+renesas@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Fri, Jul 17, 2020 at 03:28:53PM +0200, Jacopo Mondi wrote:
> The ov5640 does not support routing the clock signal to a different
> lane, and the property has value fixed to 0.
>
> Remove the property from the bindings and update its users
> accordingly.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
When we'll convert video-interface.txt to YAML, let's state clearly that
properties should not be specified when the hardware is configurable.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 6 ------
> arch/arm/boot/dts/dra72-evm-common.dtsi | 1 -
> arch/arm/boot/dts/dra76-evm.dts | 1 -
> arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-icore.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 1 -
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 -
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> 9 files changed, 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> index 8fd54575a1db..5e1662e848bd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> @@ -76,9 +76,6 @@ properties:
> bus-type:
> enum: [4, 5]
>
> - clock-lanes:
> - const: 0
> -
> data-lanes:
> description: |
> Should be set to <1> or <1 2> (one or two CSI-2 lanes supported).
> @@ -125,7 +122,6 @@ properties:
> required:
> - remote-endpoint
> - bus-type
> - - clock-lanes
> - data-lanes
>
> - if:
> @@ -134,7 +130,6 @@ properties:
> const: 5
> then:
> properties:
> - clock-lanes: false
> data-lanes: false
> required:
> - remote-endpoint
> @@ -182,7 +177,6 @@ examples:
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_from_ov5640>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> index aba7eb55525d..b5b31dc927d4 100644
> --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> @@ -288,7 +288,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts
> index ddf16e65ec7f..6fcb96abc41d 100644
> --- a/arch/arm/boot/dts/dra76-evm.dts
> +++ b/arch/arm/boot/dts/dra76-evm.dts
> @@ -421,7 +421,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> index dd5765778e87..a12d80a2403e 100644
> --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> @@ -275,7 +275,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index 2b1f275b8cc4..05bd332f527b 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -214,7 +214,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> index 5752abb48e68..5eb7fbf33069 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> @@ -383,7 +383,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 990f4cc345da..02f78b46a8fd 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -314,7 +314,6 @@ port {
> ov5640_to_mipi_csi2: endpoint {
> remote-endpoint = <&mipi_csi2_in>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 5c79ad5e7b5d..8c24fd468a22 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -628,7 +628,6 @@ camera_rear@3b {
> port {
> ov5640_ep: endpoint {
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> remote-endpoint = <&csiphy0_ep>;
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 33f4eceffbe5..dd6a636ba3af 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -255,7 +255,6 @@ port {
> csi2_cam0: endpoint {
> remote-endpoint = <&csi2_phy0>;
> bus-type = <4>;
> - clock-lanes = <0>;
> data-lanes = <1 2>;
> };
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-17 20:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 13:28 [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Jacopo Mondi
2020-07-17 13:28 ` [PATCH 01/13] " Jacopo Mondi
2020-07-17 19:28 ` Laurent Pinchart
2020-07-20 16:32 ` Rob Herring
2020-07-17 13:28 ` [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing Jacopo Mondi
2020-07-17 19:35 ` Laurent Pinchart
2020-07-22 8:14 ` Loic Poulain
2020-07-22 8:34 ` Jacopo Mondi
2020-07-17 13:28 ` [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation Jacopo Mondi
2020-07-17 19:38 ` Laurent Pinchart
2020-07-20 19:36 ` Rob Herring
2020-07-17 13:28 ` [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Jacopo Mondi
2020-07-17 19:39 ` Laurent Pinchart
2020-07-23 20:57 ` Rob Herring
2020-07-17 13:28 ` [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory Jacopo Mondi
2020-07-17 15:48 ` Fabio Estevam
2020-07-17 19:48 ` Laurent Pinchart
2020-07-20 19:45 ` Rob Herring
2020-07-17 13:28 ` [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Jacopo Mondi
2020-07-17 19:50 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Jacopo Mondi
2020-07-17 20:48 ` Laurent Pinchart [this message]
2020-07-20 19:47 ` Rob Herring
2020-07-17 13:28 ` [PATCH 08/13] dt-bindings: media: ov5640: Remove data-shift Jacopo Mondi
2020-07-17 20:57 ` Laurent Pinchart
2020-07-23 22:22 ` Sakari Ailus
2020-07-23 23:15 ` Laurent Pinchart
2020-07-25 21:18 ` Sakari Ailus
2020-07-25 21:31 ` Laurent Pinchart
2020-07-29 14:29 ` Sakari Ailus
2020-07-29 14:46 ` Laurent Pinchart
2020-07-30 16:22 ` Sakari Ailus
2020-07-30 16:32 ` Laurent Pinchart
2020-07-30 16:43 ` Sakari Ailus
2020-07-17 13:28 ` [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals Jacopo Mondi
2020-07-17 20:59 ` Laurent Pinchart
2020-07-20 19:50 ` Rob Herring
2020-07-17 13:28 ` [PATCH 10/13] dt-bindings: media: ov5640: Demote DVP required properties Jacopo Mondi
2020-07-17 21:00 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 11/13] media: i2c: ov5640: Initialize DVP polarities as default Jacopo Mondi
2020-07-17 21:02 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 12/13] MAINTAINERS: ov5640: Add bindings file Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 13/13] dt-bindings: media: ov5640: Add myself as co-maintainer Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 19:31 ` [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717204829.GI5961@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=agross@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bcousson@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.