From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82528C433E0 for ; Sat, 18 Jul 2020 15:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DA3B20829 for ; Sat, 18 Jul 2020 15:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086769; bh=A21zkqHie0c/lAiPqKuKHl7yFQhPCvHWm/szIOcC8P4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=x1G/wl6f5YBYnrrwnSELkSYew3khIiK6xVEIZQObmrySrRmQ9/0QrkxUbUdqW9XsL GxXfPLBqognbsyEIRn0r1xvMr3wY6H5L5YId8rOI6w2GcqDHuIiFG+7pKUkmkxPa6Z NFPvxmcy+NTJ96TGMzmetuJhIFOdL01gHnUnYpzM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbgGRPj2 (ORCPT ); Sat, 18 Jul 2020 11:39:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPj2 (ORCPT ); Sat, 18 Jul 2020 11:39:28 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D6A320734; Sat, 18 Jul 2020 15:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086768; bh=A21zkqHie0c/lAiPqKuKHl7yFQhPCvHWm/szIOcC8P4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lO5ZVtAlOZaL6KKjNTNbJgYH0XFIWMLluoB8yA2/WNO/UxJzUB0IUXCGTyhkE/uCb 2m0qSBTaqyydsys0ccpVJRz7LryF+wQdsg1AUhlChMTBzTBDQgPjuMV99XPGhoRagK wvIlIZRMutTBnzALdIoHdLs4EgmfAiES5vdpGkT4= Date: Sat, 18 Jul 2020 16:39:23 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Liam Girdwood , Mark Brown , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Silvan Murer , Maxime Roussin-Belanger Subject: Re: [PATCH 06/30] iio: dac: ltc2632: Fix formatting in kerneldoc struct header Message-ID: <20200718163923.07536fdd@archlinux> In-Reply-To: <20200717165538.3275050-7-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-7-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 17 Jul 2020 17:55:14 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format. >=20 > Fixes the following W=3D1 kernel build warning(s): >=20 > drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'pow= erdown_cache_mask' not described in 'ltc2632_state' > drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vre= f_mv' not described in 'ltc2632_state' > drivers/iio/dac/ltc2632.c:50: warning: Function parameter or member 'vre= f_reg' not described in 'ltc2632_state' >=20 > Cc: Liam Girdwood > Cc: Mark Brown > Cc: "Uwe Kleine-K=C3=B6nig" > Cc: Silvan Murer > Cc: Maxime Roussin-Belanger > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/dac/ltc2632.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/iio/dac/ltc2632.c b/drivers/iio/dac/ltc2632.c > index f891311f05cfe..733f13d3e5df4 100644 > --- a/drivers/iio/dac/ltc2632.c > +++ b/drivers/iio/dac/ltc2632.c > @@ -38,9 +38,9 @@ struct ltc2632_chip_info { > /** > * struct ltc2632_state - driver instance specific data > * @spi_dev: pointer to the spi_device struct > - * @powerdown_cache_mask used to show current channel powerdown state > - * @vref_mv used reference voltage (internal or external) > - * @vref_reg regulator for the reference voltage > + * @powerdown_cache_mask: used to show current channel powerdown state > + * @vref_mv: used reference voltage (internal or external) > + * @vref_reg: regulator for the reference voltage > */ > struct ltc2632_state { > struct spi_device *spi_dev; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CCBEC433E5 for ; Sat, 18 Jul 2020 15:40:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF03020734 for ; Sat, 18 Jul 2020 15:40:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="08OqFbuw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lO5ZVtAl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF03020734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iXuuUPnmq3c2YVeEJCBLAYLK94nc1iQNLlLqGP5VFJA=; b=08OqFbuwVyafmvf341gkfB2DA UlcEURKjzJ4ETi2/uEcQbVvnSOAsKszTpFDlxMRUm0FAcEuDvCMIb6lJR98ZHnSJCD/qvEnTNEHGI WSSvaEkKFqiDV10NRlcNn5RED/jnBT828f1kqz11osV+cg/+Zu56ofSLYFVHmpZsl4vjFjZTakuOP M074JzNoTK3jiWupfOaOK3Wsod1L288exqgP7xPZM8ff1xBtBZxgEi8DvLsrL5eNkdZeeScfW/lbF eYyethu2HQeC6QOzJhuNFHDhb5ayv722jQsAfhm7No9RCFVH1/vHaBznvMwcmJyXMrj5d2EUASe2U ZxKfNdcZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwovz-0006Om-LE; Sat, 18 Jul 2020 15:39:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwovw-0006O0-PR for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:39:29 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D6A320734; Sat, 18 Jul 2020 15:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086768; bh=A21zkqHie0c/lAiPqKuKHl7yFQhPCvHWm/szIOcC8P4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lO5ZVtAlOZaL6KKjNTNbJgYH0XFIWMLluoB8yA2/WNO/UxJzUB0IUXCGTyhkE/uCb 2m0qSBTaqyydsys0ccpVJRz7LryF+wQdsg1AUhlChMTBzTBDQgPjuMV99XPGhoRagK wvIlIZRMutTBnzALdIoHdLs4EgmfAiES5vdpGkT4= Date: Sat, 18 Jul 2020 16:39:23 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 06/30] iio: dac: ltc2632: Fix formatting in kerneldoc struct header Message-ID: <20200718163923.07536fdd@archlinux> In-Reply-To: <20200717165538.3275050-7-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-7-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_113928_940505_E21FAAC5 X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Silvan Murer , Maxime Roussin-Belanger , linux-iio@vger.kernel.org, Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNyBKdWwgMjAyMCAxNzo1NToxNCArMDEwMApMZWUgSm9uZXMgPGxlZS5qb25lc0Bs aW5hcm8ub3JnPiB3cm90ZToKCj4gS2VybmVsZG9jIGV4cGVjdHMgYXR0cmlidXRlcy9wYXJhbWV0 ZXJzIHRvIGJlIGluICdAKi46ICcgZm9ybWF0Lgo+IAo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0x IGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+IAo+ICBkcml2ZXJzL2lpby9kYWMvbHRjMjYzMi5j OjUwOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdwb3dlcmRvd25fY2Fj aGVfbWFzaycgbm90IGRlc2NyaWJlZCBpbiAnbHRjMjYzMl9zdGF0ZScKPiAgZHJpdmVycy9paW8v ZGFjL2x0YzI2MzIuYzo1MDogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAn dnJlZl9tdicgbm90IGRlc2NyaWJlZCBpbiAnbHRjMjYzMl9zdGF0ZScKPiAgZHJpdmVycy9paW8v ZGFjL2x0YzI2MzIuYzo1MDogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAn dnJlZl9yZWcnIG5vdCBkZXNjcmliZWQgaW4gJ2x0YzI2MzJfc3RhdGUnCj4gCj4gQ2M6IExpYW0g R2lyZHdvb2QgPGxnaXJkd29vZEBnbWFpbC5jb20+Cj4gQ2M6IE1hcmsgQnJvd24gPGJyb29uaWVA a2VybmVsLm9yZz4KPiBDYzogIlV3ZSBLbGVpbmUtS8O2bmlnIiA8dS5rbGVpbmUta29lbmlnQHBl bmd1dHJvbml4LmRlPgo+IENjOiBTaWx2YW4gTXVyZXIgPHNpbHZhbi5tdXJlckBnbWFpbC5jb20+ Cj4gQ2M6IE1heGltZSBSb3Vzc2luLUJlbGFuZ2VyIDxtYXhpbWUucm91c3NpbmJlbGFuZ2VyQGdt YWlsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn PgpBcHBsaWVkLgoKVGhhbmtzLAoKSm9uYXRoYW4KCj4gLS0tCj4gIGRyaXZlcnMvaWlvL2RhYy9s dGMyNjMyLmMgfCA2ICsrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lpby9kYWMvbHRjMjYzMi5j IGIvZHJpdmVycy9paW8vZGFjL2x0YzI2MzIuYwo+IGluZGV4IGY4OTEzMTFmMDVjZmUuLjczM2Yx M2QzZTVkZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9paW8vZGFjL2x0YzI2MzIuYwo+ICsrKyBi L2RyaXZlcnMvaWlvL2RhYy9sdGMyNjMyLmMKPiBAQCAtMzgsOSArMzgsOSBAQCBzdHJ1Y3QgbHRj MjYzMl9jaGlwX2luZm8gewo+ICAvKioKPiAgICogc3RydWN0IGx0YzI2MzJfc3RhdGUgLSBkcml2 ZXIgaW5zdGFuY2Ugc3BlY2lmaWMgZGF0YQo+ICAgKiBAc3BpX2RldjoJCQlwb2ludGVyIHRvIHRo ZSBzcGlfZGV2aWNlIHN0cnVjdAo+IC0gKiBAcG93ZXJkb3duX2NhY2hlX21hc2sJdXNlZCB0byBz aG93IGN1cnJlbnQgY2hhbm5lbCBwb3dlcmRvd24gc3RhdGUKPiAtICogQHZyZWZfbXYJCQl1c2Vk IHJlZmVyZW5jZSB2b2x0YWdlIChpbnRlcm5hbCBvciBleHRlcm5hbCkKPiAtICogQHZyZWZfcmVn CQlyZWd1bGF0b3IgZm9yIHRoZSByZWZlcmVuY2Ugdm9sdGFnZQo+ICsgKiBAcG93ZXJkb3duX2Nh Y2hlX21hc2s6CXVzZWQgdG8gc2hvdyBjdXJyZW50IGNoYW5uZWwgcG93ZXJkb3duIHN0YXRlCj4g KyAqIEB2cmVmX212OgkJCXVzZWQgcmVmZXJlbmNlIHZvbHRhZ2UgKGludGVybmFsIG9yIGV4dGVy bmFsKQo+ICsgKiBAdnJlZl9yZWc6CQlyZWd1bGF0b3IgZm9yIHRoZSByZWZlcmVuY2Ugdm9sdGFn ZQo+ICAgKi8KPiAgc3RydWN0IGx0YzI2MzJfc3RhdGUgewo+ICAJc3RydWN0IHNwaV9kZXZpY2Ug KnNwaV9kZXY7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=