All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: B K Karthik <bkkarthik@pesu.pes.edu>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues
Date: Sun, 19 Jul 2020 13:04:39 +0200	[thread overview]
Message-ID: <20200719110439.GA266150@kroah.com> (raw)
In-Reply-To: <CAAhDqq1LNQ=UfCaNojZ+wf2+njQ+7jD8Yvr1AG1TSrcByfMo+g@mail.gmail.com>

On Sun, Jul 19, 2020 at 05:35:04AM -0400, B K Karthik wrote:
> On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote:
> > > fixed multiple parentheses coding style issues reported by checkpatch.
> > >
> > > Signed-off-by: B K Karthik <karthik.bk2000@live.com>
> > > ---
> > >  drivers/staging/rtl8188eu/include/ieee80211.h |  4 +--
> > >  .../staging/rtl8188eu/include/osdep_service.h |  4 +--
> > >  drivers/staging/rtl8188eu/include/wifi.h      | 34 +++++++++----------
> > >  3 files changed, 21 insertions(+), 21 deletions(-)
> >
> > You can never add warnings to the build, like this patch did.  Always
> > test-build your patches at the very least...
> 
> understood, I will definitely do that.
> but these warnings are (mostly) [-Wunused-value] and [-Wformat].
> that should not have (?) occurred due to the usage of parentheses.

They are not there _before_ your patch, and only show up _after_ your
patch, so perhaps your patch is wrong?  :)

thanks,

greg k-h

      reply	other threads:[~2020-07-19 11:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  9:16 [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues B K Karthik
2020-07-18 11:36 ` kernel test robot
2020-07-18 11:36   ` kernel test robot
2020-07-18 16:07 ` kernel test robot
2020-07-18 16:07   ` kernel test robot
2020-07-19  9:26 ` Greg Kroah-Hartman
2020-07-19  9:35   ` B K Karthik
2020-07-19 11:04     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200719110439.GA266150@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=bkkarthik@pesu.pes.edu \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.