From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev <netdev@vger.kernel.org>, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH ethtool] Fix segfault with cable test and ./configure --disable-netlink
Date: Mon, 20 Jul 2020 02:31:11 +0200 [thread overview]
Message-ID: <20200720003111.GN1383417@lunn.ch> (raw)
In-Reply-To: <20200720001251.5nwf7nhcivl6b4yk@lion.mk-sys.cz>
On Mon, Jul 20, 2020 at 02:12:51AM +0200, Michal Kubecek wrote:
> On Fri, Jul 17, 2020 at 12:05:09AM +0200, Andrew Lunn wrote:
> > When the netlink interface code is disabled, a stub version of
> > netlink_run_handler() is used. This stub version needs to handle the
> > case when there is no possibility for a command to fall back to the
> > IOCTL call. The two cable tests commands have no such fallback, and if
> > we don't handle this, ethtool tries to jump through a NULL pointer
> > resulting in a segfault.
> >
> > Reported-by: Chris Healy <cphealy@gmail.com>
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> Applied, thank you. I'll need to be more thorough with teseting the
> --disable-netlink builds.
Hi Michal
Yes. We are all focused on retlink, and missed the backwards
compatibility issues like this.
Andrew
prev parent reply other threads:[~2020-07-20 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 22:05 [PATCH ethtool] Fix segfault with cable test and ./configure --disable-netlink Andrew Lunn
2020-07-20 0:12 ` Michal Kubecek
2020-07-20 0:31 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720003111.GN1383417@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.