From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF6BC433E1 for ; Mon, 20 Jul 2020 08:28:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 664E621775 for ; Mon, 20 Jul 2020 08:28:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="u7nt3GoC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725845AbgGTI2P (ORCPT ); Mon, 20 Jul 2020 04:28:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgGTI2O (ORCPT ); Mon, 20 Jul 2020 04:28:14 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3D63C061794; Mon, 20 Jul 2020 01:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O6HfgQ+/4qiZLGt2UojtUQ3Ga/x/jgpuR6s1a87yytM=; b=u7nt3GoCT7WBM27aXRtZnWNUD bXmH223IdV7epuWwcz8hui1tkCQJvtfRu5hvQZkEMVcZmE60DFtMY8VD0hNJF0UubpeKhjIsXV0KV wQml0xJTy9YZPIFESQKbMFRQY60X5KxoYD+m9vVq/30t4DlNFeJ74X0DZFJ31zENrDfg0+5XChBMX 87NF0WKQXOkI7CpKZnM+RFs8y8HtoYgi00zTMK9U3om7Pv5aPxBmcCtvotb9ASctJZcL52BbW6iaN ag23tbDPGsTcJCtj6GmQypV1xEXZSJxh7N56EzdK+u3BZNeqU0YuZqMpVsbmrfqihoSQCkOba0Wvx SXgUBjiBg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41816) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxR9b-0002m6-AD; Mon, 20 Jul 2020 09:28:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jxR9X-0004pY-Ga; Mon, 20 Jul 2020 09:28:03 +0100 Date: Mon, 20 Jul 2020 09:28:03 +0100 From: Russell King - ARM Linux admin To: Icenowy Zheng Cc: Ondrej Jirman , Amit Kucheria , "open list:ALLWINNER THERMAL DRIVER" , Yangtao Li , Daniel Lezcano , open list , Maxime Ripard , Vasily Khoruzhick , linux-sunxi@googlegroups.com, Zhang Rui , Chen-Yu Tsai , "moderated list:ARM/Allwinner sunXi SoC support" Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails Message-ID: <20200720082803.GS1551@shell.armlinux.org.uk> References: <20200708105527.868987-1-megous@megous.com> <20200708110301.GB1551@shell.armlinux.org.uk> <86689f81367716e3f88ec363edd0d302deca0a1f.camel@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86689f81367716e3f88ec363edd0d302deca0a1f.camel@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jul 20, 2020 at 03:55:26PM +0800, Icenowy Zheng wrote: > 在 2020-07-08星期三的 12:03 +0100，Russell King - ARM Linux admin写道： > > On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > > > I noticed several mobile Linux distributions failing to enable the > > > thermal regulation correctly, because the kernel is silent > > > when thermal driver fails to probe. Add enough error reporting > > > to debug issues and warn users in case thermal sensor is failing > > > to probe. > > > > > > Failing to notify users means, that SoC can easily overheat under > > > load. > > > > > > Signed-off-by: Ondrej Jirman > > > --- > > > drivers/thermal/sun8i_thermal.c | 55 ++++++++++++++++++++++++++--- > > > ---- > > > 1 file changed, 43 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/thermal/sun8i_thermal.c > > > b/drivers/thermal/sun8i_thermal.c > > > index 74d73be16496..9065e79ae743 100644 > > > --- a/drivers/thermal/sun8i_thermal.c > > > +++ b/drivers/thermal/sun8i_thermal.c > > > @@ -287,8 +287,12 @@ static int sun8i_ths_calibrate(struct > > > ths_device *tmdev) > > > > > > calcell = devm_nvmem_cell_get(dev, "calibration"); > > > if (IS_ERR(calcell)) { > > > + dev_err(dev, "Failed to get calibration nvmem cell > > > (%ld)\n", > > > + PTR_ERR(calcell)); > > > > Consider using: > > > > dev_err(dev, "Failed to get calibration nvmem cell > > (%pe)\n", > > calcell); > > > > which means the kernel can print the symbolic errno value. > > Oh interesting format here. > > When we need to deal with a int return value, is it "%e"? No, because that will lose the ability for the compiler to check the format string and arguments correspond. All the extensions are documented at Documentation/core-api/printk-formats.rst. Use %pe and ERR_PTR(...) to print an integer -ve errno return value. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FADC433DF for ; Mon, 20 Jul 2020 08:32:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6719521775 for ; Mon, 20 Jul 2020 08:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pfy/pjWX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="u7nt3GoC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6719521775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/5V57N1+q8HsXpiUrXV5aKn8ZFl8DKesdgOPFul9MlI=; b=pfy/pjWX25AJV8Wuc3+angNfd eXs76YOSPq0Cn3YBJZZmLja4hdLjJwb3sB2/GseecaBIuX24m1WWSfr/IXqc01eEqr345ZFV4Q71P CSzYEkFFY7v7/cImRiUwBb5PWNvxP9ya1C5wyGvXrxqo36awmPC8PmU97TegOzpCCSYpy0uiYSZU9 Mv2fqu5L6aQbuk7gBdYexHkBAWOApebffEZlCLKjNV1yQUNAWgOcBAxKjuSNupSvj37xg9moTxD9k /OJzijIUqsPTWTEW5itjL5h36DqJ9NUmY9cH2RR2V1LxrqeoDGl2A0YKPWA1Ddm7S6BYkVsnVabZI qBvmrhp4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxRCm-0005Jw-J8; Mon, 20 Jul 2020 08:31:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxRCk-0005BQ-4j for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 08:31:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O6HfgQ+/4qiZLGt2UojtUQ3Ga/x/jgpuR6s1a87yytM=; b=u7nt3GoCT7WBM27aXRtZnWNUD bXmH223IdV7epuWwcz8hui1tkCQJvtfRu5hvQZkEMVcZmE60DFtMY8VD0hNJF0UubpeKhjIsXV0KV wQml0xJTy9YZPIFESQKbMFRQY60X5KxoYD+m9vVq/30t4DlNFeJ74X0DZFJ31zENrDfg0+5XChBMX 87NF0WKQXOkI7CpKZnM+RFs8y8HtoYgi00zTMK9U3om7Pv5aPxBmcCtvotb9ASctJZcL52BbW6iaN ag23tbDPGsTcJCtj6GmQypV1xEXZSJxh7N56EzdK+u3BZNeqU0YuZqMpVsbmrfqihoSQCkOba0Wvx SXgUBjiBg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41816) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxR9b-0002m6-AD; Mon, 20 Jul 2020 09:28:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jxR9X-0004pY-Ga; Mon, 20 Jul 2020 09:28:03 +0100 Date: Mon, 20 Jul 2020 09:28:03 +0100 From: Russell King - ARM Linux admin To: Icenowy Zheng Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails Message-ID: <20200720082803.GS1551@shell.armlinux.org.uk> References: <20200708105527.868987-1-megous@megous.com> <20200708110301.GB1551@shell.armlinux.org.uk> <86689f81367716e3f88ec363edd0d302deca0a1f.camel@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86689f81367716e3f88ec363edd0d302deca0a1f.camel@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_043122_202814_D04E8661 X-CRM114-Status: GOOD ( 19.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , Amit Kucheria , "open list:ALLWINNER THERMAL DRIVER" , Yangtao Li , Daniel Lezcano , open list , Maxime Ripard , Vasily Khoruzhick , linux-sunxi@googlegroups.com, Zhang Rui , Chen-Yu Tsai , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdWwgMjAsIDIwMjAgYXQgMDM6NTU6MjZQTSArMDgwMCwgSWNlbm93eSBaaGVuZyB3 cm90ZToKPiDlnKggMjAyMC0wNy0wOOaYn+acn+S4ieeahCAxMjowMyArMDEwMO+8jFJ1c3NlbGwg S2luZyAtIEFSTSBMaW51eCBhZG1pbuWGmemBk++8mgo+ID4gT24gV2VkLCBKdWwgMDgsIDIwMjAg YXQgMTI6NTU6MjdQTSArMDIwMCwgT25kcmVqIEppcm1hbiB3cm90ZToKPiA+ID4gSSBub3RpY2Vk IHNldmVyYWwgbW9iaWxlIExpbnV4IGRpc3RyaWJ1dGlvbnMgZmFpbGluZyB0byBlbmFibGUgdGhl Cj4gPiA+IHRoZXJtYWwgcmVndWxhdGlvbiBjb3JyZWN0bHksIGJlY2F1c2UgdGhlIGtlcm5lbCBp cyBzaWxlbnQKPiA+ID4gd2hlbiB0aGVybWFsIGRyaXZlciBmYWlscyB0byBwcm9iZS4gQWRkIGVu b3VnaCBlcnJvciByZXBvcnRpbmcKPiA+ID4gdG8gZGVidWcgaXNzdWVzIGFuZCB3YXJuIHVzZXJz IGluIGNhc2UgdGhlcm1hbCBzZW5zb3IgaXMgZmFpbGluZwo+ID4gPiB0byBwcm9iZS4KPiA+ID4g Cj4gPiA+IEZhaWxpbmcgdG8gbm90aWZ5IHVzZXJzIG1lYW5zLCB0aGF0IFNvQyBjYW4gZWFzaWx5 IG92ZXJoZWF0IHVuZGVyCj4gPiA+IGxvYWQuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBP bmRyZWogSmlybWFuIDxtZWdvdXNAbWVnb3VzLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJz L3RoZXJtYWwvc3VuOGlfdGhlcm1hbC5jIHwgNTUgKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0KPiA+ID4gLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDEy IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGhlcm1hbC9z dW44aV90aGVybWFsLmMKPiA+ID4gYi9kcml2ZXJzL3RoZXJtYWwvc3VuOGlfdGhlcm1hbC5jCj4g PiA+IGluZGV4IDc0ZDczYmUxNjQ5Ni4uOTA2NWU3OWFlNzQzIDEwMDY0NAo+ID4gPiAtLS0gYS9k cml2ZXJzL3RoZXJtYWwvc3VuOGlfdGhlcm1hbC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvdGhlcm1h bC9zdW44aV90aGVybWFsLmMKPiA+ID4gQEAgLTI4Nyw4ICsyODcsMTIgQEAgc3RhdGljIGludCBz dW44aV90aHNfY2FsaWJyYXRlKHN0cnVjdAo+ID4gPiB0aHNfZGV2aWNlICp0bWRldikKPiA+ID4g IAo+ID4gPiAgCWNhbGNlbGwgPSBkZXZtX252bWVtX2NlbGxfZ2V0KGRldiwgImNhbGlicmF0aW9u Iik7Cj4gPiA+ICAJaWYgKElTX0VSUihjYWxjZWxsKSkgewo+ID4gPiArCQlkZXZfZXJyKGRldiwg IkZhaWxlZCB0byBnZXQgY2FsaWJyYXRpb24gbnZtZW0gY2VsbAo+ID4gPiAoJWxkKVxuIiwKPiA+ ID4gKwkJCVBUUl9FUlIoY2FsY2VsbCkpOwo+ID4gCj4gPiBDb25zaWRlciB1c2luZzoKPiA+IAo+ ID4gCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBnZXQgY2FsaWJyYXRpb24gbnZtZW0gY2VsbAo+ ID4gKCVwZSlcbiIsCj4gPiAJCQljYWxjZWxsKTsKPiA+IAo+ID4gd2hpY2ggbWVhbnMgdGhlIGtl cm5lbCBjYW4gcHJpbnQgdGhlIHN5bWJvbGljIGVycm5vIHZhbHVlLgo+IAo+IE9oIGludGVyZXN0 aW5nIGZvcm1hdCBoZXJlLgo+IAo+IFdoZW4gd2UgbmVlZCB0byBkZWFsIHdpdGggYSBpbnQgcmV0 dXJuIHZhbHVlLCBpcyBpdCAiJWUiPwoKTm8sIGJlY2F1c2UgdGhhdCB3aWxsIGxvc2UgdGhlIGFi aWxpdHkgZm9yIHRoZSBjb21waWxlciB0byBjaGVjayB0aGUKZm9ybWF0IHN0cmluZyBhbmQgYXJn dW1lbnRzIGNvcnJlc3BvbmQuICBBbGwgdGhlIGV4dGVuc2lvbnMgYXJlCmRvY3VtZW50ZWQgYXQg RG9jdW1lbnRhdGlvbi9jb3JlLWFwaS9wcmludGstZm9ybWF0cy5yc3QuCgpVc2UgJXBlIGFuZCBF UlJfUFRSKC4uLikgdG8gcHJpbnQgYW4gaW50ZWdlciAtdmUgZXJybm8gcmV0dXJuIHZhbHVlLgoK LS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVs b3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDQwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50 IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=