From: Boris Brezillon <boris.brezillon@collabora.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
linux-mtd@lists.infradead.org, nicolas.ferre@microchip.com,
miquel.raynal@bootlin.com
Subject: Re: [PATCH v4 5/6] mtd: rawnand: atmel: Convert the driver to exec_op()
Date: Mon, 20 Jul 2020 13:52:54 +0200 [thread overview]
Message-ID: <20200720135254.7475dc96@collabora.com> (raw)
In-Reply-To: <20200720042759.1482341-6-tudor.ambarus@microchip.com>
On Mon, 20 Jul 2020 07:27:58 +0300
Tudor Ambarus <tudor.ambarus@microchip.com> wrote:
> +static int atmel_smc_nand_exec_op(struct atmel_nand *nand,
> + const struct nand_operation *op,
> + bool check_only)
> +{
> + struct atmel_nand_controller *nc;
> + unsigned int i;
> + int ret = 0;
> +
> + if (check_only)
> + return 0;
> +
> + nc = to_nand_controller(nand->base.controller);
0day bots complained about this unused var when I submitted v3.
> + atmel_nand_select_target(nand, op->cs);
> + gpiod_set_value(nand->activecs->csgpio, 0);
> + for (i = 0; i < op->ninstrs; i++) {
> + ret = atmel_smc_nand_exec_instr(nand, &op->instrs[i]);
> + if (ret)
> + break;
> + }
> + gpiod_set_value(nand->activecs->csgpio, 1);
> +
> + return ret;
> +}
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-07-20 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 4:27 [PATCH v4 0/6] mtd: rawnand: atmel: Convert the driver to exec_op() Tudor Ambarus
2020-07-20 4:27 ` [PATCH v4 1/6] mtd: rawnand: atmel: Enable the NFC controller at probe time Tudor Ambarus
2020-07-20 4:27 ` [PATCH v4 2/6] mtd: rawnand: atmel: Drop redundant nand_read_page_op() Tudor Ambarus
2020-07-20 4:27 ` [PATCH v4 3/6] mtd: rawnand: atmel: Use nand_{write,read}_data_op() Tudor Ambarus
2020-07-20 4:27 ` [PATCH v4 4/6] mtd: rawnand: atmel: Use nand_prog_page_end_op() Tudor Ambarus
2020-07-20 4:27 ` [PATCH v4 5/6] mtd: rawnand: atmel: Convert the driver to exec_op() Tudor Ambarus
2020-07-20 11:52 ` Boris Brezillon [this message]
2020-07-20 4:27 ` [PATCH v4 6/6] mtd: rawnand: atmel: Get rid of the legacy interface implementation Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720135254.7475dc96@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.