From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E37C433DF for ; Mon, 20 Jul 2020 14:09:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AB1620B1F for ; Mon, 20 Jul 2020 14:09:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DN92FHAf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AB1620B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZsAGAPwYiU8MZK+5MTjpE1em04A6dfJ2SEk8waFyw1I=; b=DN92FHAfyXu/a+YfaRecDVpki QrEwo1ett4qlgGCAXn3w6pLdQxprIpzUBSdvKk9pzdT7NqVAhO4677GVLJKXWWyBCmAGS0afily3c zQcx+aZ7yMuYJv3LKmBtY36WkdQfJrr+RQzFuQR6ogpo7ZsUzoSzFb7j54mfZ4PYfUI0uAaGarMGa Gc7Wi/uOIWeatE+rmC2R4PbX3w+rbu3ioWE7hMhO7g3isjRkIyGwQwYxZAjOrvgAE80z+JJDh/gUu Lfc0VkNNOtHwJXJKZbQ8uoUgZtaiqy/pRnLZwwO3/AODDhlsr+LWGOZso5DPOn8gf+t8X4vZiv58h h5ThRAcnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxWTh-0008Fg-Rt; Mon, 20 Jul 2020 14:09:13 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxWTf-0008Ev-AQ for linux-nvme@lists.infradead.org; Mon, 20 Jul 2020 14:09:12 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 94C3F68BFE; Mon, 20 Jul 2020 16:09:08 +0200 (CEST) Date: Mon, 20 Jul 2020 16:09:08 +0200 From: Christoph Hellwig To: Logan Gunthorpe Subject: Re: [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Message-ID: <20200720140908.GE4627@lst.de> References: <20200716203319.16022-1-logang@deltatee.com> <20200716203319.16022-6-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200716203319.16022-6-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_100911_475271_5427B6EA X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , Jens Axboe , Keith Busch , Max Gurtovoy , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jul 16, 2020 at 02:33:15PM -0600, Logan Gunthorpe wrote: > nvme_ctrl_get_by_path() is analagous to blkdev_get_by_path() except it > gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0). > It makes use of filp_open() to open the file and uses the private > data to obtain a pointer to the struct nvme_ctrl. If the fops of the > file do not match, -EINVAL is returned. > > The purpose of this function is to support NVMe-OF target passthru. This looks generally good. However since the early days of this patchset we've grown symbol namespaces, and the EXPORT_SYMBOL_NS_GPL macro, which are what we really should use here and for the other exports. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06838C433E0 for ; Mon, 20 Jul 2020 14:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC82722C9C for ; Mon, 20 Jul 2020 14:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbgGTOJL (ORCPT ); Mon, 20 Jul 2020 10:09:11 -0400 Received: from verein.lst.de ([213.95.11.211]:47155 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgGTOJL (ORCPT ); Mon, 20 Jul 2020 10:09:11 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 94C3F68BFE; Mon, 20 Jul 2020 16:09:08 +0200 (CEST) Date: Mon, 20 Jul 2020 16:09:08 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Jens Axboe , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates Subject: Re: [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Message-ID: <20200720140908.GE4627@lst.de> References: <20200716203319.16022-1-logang@deltatee.com> <20200716203319.16022-6-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716203319.16022-6-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2020 at 02:33:15PM -0600, Logan Gunthorpe wrote: > nvme_ctrl_get_by_path() is analagous to blkdev_get_by_path() except it > gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0). > It makes use of filp_open() to open the file and uses the private > data to obtain a pointer to the struct nvme_ctrl. If the fops of the > file do not match, -EINVAL is returned. > > The purpose of this function is to support NVMe-OF target passthru. This looks generally good. However since the early days of this patchset we've grown symbol namespaces, and the EXPORT_SYMBOL_NS_GPL macro, which are what we really should use here and for the other exports.