From: Rob Herring <robh@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: yanfei.li@ingenic.com, devicetree@vger.kernel.org,
dongsheng.qiu@ingenic.com, zhenwenjin@gmail.com,
aric.pzqi@ingenic.com, paul@crapouillou.net,
rick.tyliu@ingenic.com, daniel.lezcano@linaro.org,
tglx@linutronix.de, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, sernia.zhou@foxmail.com
Subject: Re: [PATCH v9 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings.
Date: Mon, 20 Jul 2020 10:33:49 -0600 [thread overview]
Message-ID: <20200720163349.GA2626388@bogus> (raw)
In-Reply-To: <20200720151106.112807-2-zhouyanjie@wanyeetech.com>
On Mon, 20 Jul 2020 23:11:05 +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the OST bindings for the X10000 SoC from Ingenic.
>
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>
> Notes:
> v1->v2:
> No change.
>
> v2->v3:
> Fix wrong parameters in "clocks".
>
> v3->v4:
> 1.Rename "ingenic,ost.yaml" to "ingenic,sysost.yaml".
> 2.Rename "ingenic,ost.h" to "ingenic,sysost.h".
> 3.Modify the description in "ingenic,sysost.yaml".
>
> v4->v5:
> No change.
>
> v5->v6:
> 1.Drop "oneOf" and the blank line.
> 2.Add "additionalProperties: false".
>
> v6->v7:
> No change.
>
> v7->v8:
> No change.
>
> v8->v9:
> Fix warning while applying.
> Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> .../devicetree/bindings/timer/ingenic,sysost.yaml | 63 ++++++++++++++++++++++
> include/dt-bindings/clock/ingenic,sysost.h | 12 +++++
> 2 files changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
> create mode 100644 include/dt-bindings/clock/ingenic,sysost.h
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: properties: '#address-cells' is a dependency of '#size-cells'
Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/timer/ingenic,sysost.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/timer/ingenic,sysost.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1332465
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-07-20 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 15:11 [PATCH v9 0/2] Add support for the OST in Ingenic X1000 周琰杰 (Zhou Yanjie)
2020-07-20 15:11 ` [PATCH v9 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings 周琰杰 (Zhou Yanjie)
2020-07-20 16:33 ` Rob Herring [this message]
2020-07-20 15:11 ` [PATCH v9 2/2] clocksource: Ingenic: Add support for the Ingenic X1000 OST 周琰杰 (Zhou Yanjie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720163349.GA2626388@bogus \
--to=robh@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=tglx@linutronix.de \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.