All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Maor Gottlieb <maorg@mellanox.com>,
	Artemy Kovalyov <artemyko@mellanox.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/mlx5: Add missing srcu_read_lock in ODP implicit flow
Date: Mon, 20 Jul 2020 19:53:26 +0300	[thread overview]
Message-ID: <20200720165326.GD1080481@unreal> (raw)
In-Reply-To: <20200720143105.GM2021248@mellanox.com>

On Mon, Jul 20, 2020 at 11:31:05AM -0300, Jason Gunthorpe wrote:
> On Sun, Jul 19, 2020 at 09:57:47AM +0300, Leon Romanovsky wrote:
> > From: Maor Gottlieb <maorg@mellanox.com>
> >
> > According to the locking scheme, mlx5_ib_update_xlt should be called
> > with srcu_read_lock().
> > This fixes the below LOCKDEP trace.
> >
> > [  861.917222] WARNING: CPU: 1 PID: 1130 at
> > drivers/infiniband/hw/mlx5/odp.c:132 mlx5_odp_populate_xlt+0x175/0x180
> > [mlx5_ib]
>
> Why do I keep getting patches with oops reports word wrapped??
>
> Do not wrap oops.
>
> Do not include timestamp in oops.
>
> Trim useless informatin

I'll try my best.

This note for INTERNAL review, please DON'T trim anything from OOPS, I
don't want to lose information just because someone was too extatic.

Thanks

  reply	other threads:[~2020-07-20 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19  6:57 [PATCH rdma-next] RDMA/mlx5: Add missing srcu_read_lock in ODP implicit flow Leon Romanovsky
2020-07-20 14:31 ` Jason Gunthorpe
2020-07-20 16:53   ` Leon Romanovsky [this message]
2020-07-24 19:51 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720165326.GD1080481@unreal \
    --to=leon@kernel.org \
    --cc=artemyko@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maorg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.