Re: [PATCH 00/35] multipath-tools series part I: minor changes

[Benjamin Marzinski <bmarzins@redhat.com>]

On Thu, Jul 09, 2020 at 12:15:45PM +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
> Hi Christophe, hi Ben,
> 
> This is part I of a larger patch series for multpath-tools I've been preparing.
> It contains self-contained fixes and cleanups, and unit test additions.
> 
> The full series will also be available here:
> https://github.com/mwilck/multipath-tools/tree/ups/submit-2007
> 
> There are tags in that repo for each part of the series.
> This part is tagged "submit-200709-1".

For the part, with the exception of patches 8 & 12
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
 
> It's based on 0.8.4, plus the following set of previously
> submitted and reviewed patches:
> 
>  - libmultipath: add device to hwtable.c (Steve Schremmer)
>  - [PATCH v3 0/7] Fix muitpath/multipathd flush issue (v3 7-part series, Ben)
>  - [PATCH v2 0/4] misc patches (v2 4-part series, Ben)
>  - multipath: Fix compiler warnings when built without systemd. (Marius Bakke)
>  - [PATCH v2 0/3] multipath: change default devnode blacklist
>    (v2 3-part series, Ben)
>  - multipath: add "-e" option to enable foreign libraries (me)
>  - libmultipath: set "enable_foreign" to NONE by default (me)
>  - libmultipath: fix condlog NULL argument in uevent_get_env_var (Ben)
>  - fix boolean value with json-c 0.14 (Christian Hesse) 
>  - [PATCH v3 0/6] multipath: path validation library prep work
>    (v3 6-part series, me)
>  - [PATCH 0/2] More minor libmultipath fixes (2-part series, me)
>  - [PATCH 00/11] Minor fixes for multipath-tools (11-part series, me)
>  - libmpathpersist: depend on libmultipath (Christian Hesse)
>  - [PATCH v2 0/2] multipath-tools: fixes for kpartx.rules and skip_kpartx
>    (v2 2-part series, me)
>  - libmultipath: allow force reload with no active paths (Ben)
>  - libmutipath: don't close fd on dm_lib_release (Ben)
>  - libmultipath: assign variable to make gcc happy (Ben)
>  - [PATCH v2 0/4] libmpathpersist allocation size fixes (v2 4-part series, me)
> 
> You can find a full tree of the code this is based on here:
> https://github.com/openSUSE/multipath-tools/tree/upstream-queue
> 
> Regards, Martin
> 
> 
> Martin Wilck (35):
>   multipath-tools tests/util: separate group for bitmask tests
>   multipath-tools tests/directio: fix missing initializers
>   tests: __wrap_dlog: use check_expected()
>   multipath tools tests: add strchop() test
>   libmultipath: improve strchop()
>   multipath-tools tests: add test for devt2devname
>   libmultipath: devt2devname(): simplify using libudev
>   libmultipath: create bitfield abstraction
>   libmultipath: use bitfields in group_by_match()
>   libmultipath: util: constify function arguments
>   multipath-tools tests: add unit tests for strlcat
>   libmultipath: strlcpy()/strlcat(): use restrict qualifier
>   libmultipath: constify blacklist code
>   libmultipath: rlookup_binding(): remove newline in log message
>   libmultipath: fix missing initializer warning from clang 3.9
>   libmultipath: fix gcc -Wstringop-overflow warning
>   libmultipath: remove uevent listener failback
>   libmultipath: uevent: use static linkage where possible
>   libmultipath: uevent: inline trivial functions
>   libmultipath: decrease log level of "SCSI target" log message
>   libmultipath: get_udev_uid(): more appropriate error code
>   libmultipath: get_uid(): improve log message on udev failure
>   libmultipath: make sysfs_pathinfo() static and use const
>   libmultipath: pathinfo(): improve a log message
>   libmultipath: pathinfo(): don't filter emtpy devnode names
>   libmultipath: io_err_stat_handle_pathfail(): less error conditions
>   libmultipath: improve libdm logging
>   libmultipath: snprint_devices(): use udev_enumerate
>   libmultipath: snprint_devices(): print hidden/foreign status
>   libmultipath: alloc_path(): initialize pp->initialized
>   libmultipath: alloc_path_with_pathinfo(): treat devname overflow as
>     error
>   libmultipath: log table params in addmap()
>   multipathd: remove set_multipath_wwid()
>   kpartx: print an error message if removing a partition fails
>   kpartx: add missing newline
> 
>  kpartx/devmapper.c               |   2 +-
>  kpartx/kpartx.c                  |   2 +
>  libmultipath/alias.c             |   2 +-
>  libmultipath/blacklist.c         |  34 +-
>  libmultipath/blacklist.h         |  17 +-
>  libmultipath/checkers/directio.c |   2 +-
>  libmultipath/configure.c         |  11 +-
>  libmultipath/defaults.h          |   2 +
>  libmultipath/devmapper.c         |  27 +-
>  libmultipath/discovery.c         |  30 +-
>  libmultipath/dmparser.c          |   2 +-
>  libmultipath/io_err_stat.c       |  25 +-
>  libmultipath/parser.c            |   2 +-
>  libmultipath/pgpolicies.c        |  12 +-
>  libmultipath/print.c             |  90 ++---
>  libmultipath/print.h             |   2 +-
>  libmultipath/propsel.c           |   6 +
>  libmultipath/structs.c           |   1 +
>  libmultipath/uevent.c            | 324 ++---------------
>  libmultipath/uevent.h            |  47 ++-
>  libmultipath/util.c              | 168 ++++-----
>  libmultipath/util.h              |  73 +++-
>  multipathd/main.c                |  14 +-
>  tests/Makefile                   |   3 +-
>  tests/alias.c                    |   4 +-
>  tests/devt.c                     | 192 ++++++++++
>  tests/directio.c                 |  28 +-
>  tests/test-log.c                 |   5 +-
>  tests/uevent.c                   |   4 -
>  tests/util.c                     | 586 ++++++++++++++++++++++++++++---
>  30 files changed, 1081 insertions(+), 636 deletions(-)
>  create mode 100644 tests/devt.c
> 
> -- 
> 2.26.2