From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Chu Lin <linchuyuan@google.com>,
belgaied@google.com, jasonling@google.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, zhongqil@google.com
Subject: Re: [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding
Date: Mon, 20 Jul 2020 16:27:25 -0600 [thread overview]
Message-ID: <20200720222725.GA3061855@bogus> (raw)
In-Reply-To: <20200719222222.GA78762@roeck-us.net>
On Sun, Jul 19, 2020 at 03:22:22PM -0700, Guenter Roeck wrote:
> On Fri, Jul 10, 2020 at 12:42:58AM +0000, Chu Lin wrote:
> > Problem:
> > adm1272 and adm1278 supports temperature sampling. The
> > current way of enabling it requires the user manually unbind the device
> > from the driver, flip the temperature sampling control bit and then bind
> > the device back to the driver. It would be nice if we can control this in a
> > better way by reading the dt.
> >
> > Solution:
> > Introducing device tree binding adm1272-adm1278-temp1-en. If the
> > flag is set, flip the temp1_en control bit on probing.
> >
> > Testing:
> > make dt_binding_check
> >
> > Signed-off-by: Chu Lin <linchuyuan@google.com>
> > ---
> > Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > index 1ecd03f3da4d..4403fe30f005 100644
> > --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> > @@ -15,6 +15,8 @@ Optional properties:
> >
> > - shunt-resistor-micro-ohms
> > Shunt resistor value in micro-Ohm
> > +- adm1272-adm1278-temp1-en
> > + Enable temperature sampling. This is supported on adm1272 and adm1278
>
> I suspect this should be something like "analog,temp1-enable".
Yes.
> Either case,
> I would suggest to resend the series and copy DT maintainers at least on
> this patch.
Only the DT list matters.
Rob
prev parent reply other threads:[~2020-07-20 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 0:42 [PATCH] dt-bindings: hwmon: adm1272: add adm1272-adm1275-temp1-en binding Chu Lin
2020-07-13 19:24 ` Chu Lin
2020-07-14 14:03 ` Guenter Roeck
2020-07-19 22:22 ` Guenter Roeck
2020-07-20 3:12 ` Chu Lin
2020-07-20 22:27 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720222725.GA3061855@bogus \
--to=robh@kernel.org \
--cc=belgaied@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jasonling@google.com \
--cc=jdelvare@suse.com \
--cc=linchuyuan@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=zhongqil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.