From: Johan Hovold <johan@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, George Spelvin <lkml@sdf.org>
Subject: Re: [PATCH] USB: serial: iuu_phoenix: fix led-activity helpers
Date: Tue, 21 Jul 2020 09:27:10 +0200 [thread overview]
Message-ID: <20200721072710.GD3634@localhost> (raw)
In-Reply-To: <20200716090503.GA1548743@kroah.com>
On Thu, Jul 16, 2020 at 11:05:03AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jul 16, 2020 at 10:50:55AM +0200, Johan Hovold wrote:
> > The set-led command is eight bytes long and starts with a command byte
> > followed by six bytes of RGB data and ends with a byte encoding a
> > frequency (see iuu_led() and iuu_rgbf_fill_buffer()).
> >
> > The led activity helpers had a few long-standing bugs which corrupted
> > the command packets by inserting a second command byte and thereby
> > offsetting the RGB data and dropping the frequency in non-xmas mode.
> >
> > In xmas mode, a related off-by-one error left the frequency field
> > uninitialised.
> >
> > Fixes: 60a8fc017103 ("USB: add iuu_phoenix driver")
> > Reported-by: George Spelvin <lkml@sdf.org>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for reviewing. Now applied for -next.
Johan
prev parent reply other threads:[~2020-07-21 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:50 [PATCH] USB: serial: iuu_phoenix: fix led-activity helpers Johan Hovold
2020-07-16 9:05 ` Greg KH
2020-07-21 7:27 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721072710.GD3634@localhost \
--to=johan@kernel.org \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=lkml@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.