From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Tue, 21 Jul 2020 08:00:22 +0000 Subject: Re: [PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity' Message-Id: <20200721080022.GA41608@ravnborg.org> List-Id: References: <20200721073919.925935-1-lee.jones@linaro.org> In-Reply-To: <20200721073919.925935-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lee Jones Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Lee. On Tue, Jul 21, 2020 at 08:39:19AM +0100, Lee Jones wrote: > Fixes the following kernel build warning: > > drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’: > drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable ‘intensity’ [-Wunused-variable] > 62 | int intensity = bd->props.brightness; > | ^~~~~~~~~ > > Cc: Sam Ravnborg > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics") > Signed-off-by: Lee Jones Thanks for fixing this. The driver only build for X86 so the warnings was lost in other build noise. One more thing to improve before next submission - sorry for this. Reviewed-by: Sam Ravnborg > --- > drivers/video/backlight/cr_bllcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c > index a24d42e1ea3cd..4ad0a72531fe2 100644 > --- a/drivers/video/backlight/cr_bllcd.c > +++ b/drivers/video/backlight/cr_bllcd.c > @@ -59,7 +59,6 @@ struct cr_panel { > > static int cr_backlight_set_intensity(struct backlight_device *bd) > { > - int intensity = bd->props.brightness; > u32 addr = gpio_bar + CRVML_PANEL_PORT; > u32 cur = inl(addr); > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B037DC433E5 for ; Tue, 21 Jul 2020 08:01:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F7A720709 for ; Tue, 21 Jul 2020 08:01:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yLk8RIWQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F7A720709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ladhGgbcNwDlnurEu1yffYJeUadzxahOL4aDsSJ25xk=; b=yLk8RIWQVuvWl9uZskQA61Z2J B9JidQQH+Kqu0gs4avPjtH/MgHMaqrVvdAjpIPtHARAiEVw310ew+Gb6Y6QBhf+nMmPiIgRGkW7pS vm4ZiZV5Il+lw+YLzPWNKxVWwkj/IgmccvapFhoRPyd+hrD0gBuLxRzc3rEznxJWzxpWqDvZxgBir UN3EDfi9W0vep1G6r6HAViBNSZMTbzSf9CBlB8GxIfgIpygHQgTWkkVmywsoD0vXBile7+0BlEt4b LtKl48QL7735klVcSrqfqRgrbbF67P0vHIXoCtXc88p23yJFZYIjHvmN9ygwrTVd1h0VFvI+cbOL7 Ul8qBIw1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxnCY-0006pP-Ck; Tue, 21 Jul 2020 08:00:38 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxnCV-0006nx-SP for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 08:00:36 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 002392005C; Tue, 21 Jul 2020 10:00:23 +0200 (CEST) Date: Tue, 21 Jul 2020 10:00:22 +0200 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity' Message-ID: <20200721080022.GA41608@ravnborg.org> References: <20200721073919.925935-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200721073919.925935-1-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=hD80L64hAAAA:8 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=8YDWVOxWXuGqFK3bR7oA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 a=AjGcO6oz07-iQ99wixmX:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_040036_063617_3B45D97E X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Daniel Thompson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGVlLgoKT24gVHVlLCBKdWwgMjEsIDIwMjAgYXQgMDg6Mzk6MTlBTSArMDEwMCwgTGVlIEpv bmVzIHdyb3RlOgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcga2VybmVsIGJ1aWxkIHdhcm5pbmc6Cj4g Cj4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmM6IEluIGZ1bmN0aW9uIOKAmGNy X2JhY2tsaWdodF9zZXRfaW50ZW5zaXR54oCZOgo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9j cl9ibGxjZC5jOjYyOjY6IHdhcm5pbmc6IHVudXNlZCB2YXJpYWJsZSDigJhpbnRlbnNpdHnigJkg Wy1XdW51c2VkLXZhcmlhYmxlXQo+ICA2MiB8IGludCBpbnRlbnNpdHkgPSBiZC0+cHJvcHMuYnJp Z2h0bmVzczsKPiAgfCBefn5+fn5+fn4KPiAKPiBDYzogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJv cmcub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3Jn Pgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiBDYzogQmFydGxvbWll aiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgo+IENjOiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9y Zwo+IEZpeGVzOiAyNGQzNDYxN2MyNGYgKCJiYWNrbGlnaHQ6IGNyX2JsbGNkOiBJbnRyb2R1Y2Ug Z3Bpby1iYWNrbGlnaHQgc2VtYW50aWNzIikKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxl ZS5qb25lc0BsaW5hcm8ub3JnPgoKVGhhbmtzIGZvciBmaXhpbmcgdGhpcy4KVGhlIGRyaXZlciBv bmx5IGJ1aWxkIGZvciBYODYgc28gdGhlIHdhcm5pbmdzIHdhcyBsb3N0IGluIG90aGVyIGJ1aWxk Cm5vaXNlLgpPbmUgbW9yZSB0aGluZyB0byBpbXByb3ZlIGJlZm9yZSBuZXh0IHN1Ym1pc3Npb24g LSBzb3JyeSBmb3IgdGhpcy4KClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9y Zy5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9jcl9ibGxjZC5jIHwgMSAt Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9j cl9ibGxjZC5jCj4gaW5kZXggYTI0ZDQyZTFlYTNjZC4uNGFkMGE3MjUzMWZlMiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9jcl9ibGxjZC5jCj4gKysrIGIvZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvY3JfYmxsY2QuYwo+IEBAIC01OSw3ICs1OSw2IEBAIHN0cnVjdCBjcl9w YW5lbCB7Cj4gIAo+ICBzdGF0aWMgaW50IGNyX2JhY2tsaWdodF9zZXRfaW50ZW5zaXR5KHN0cnVj dCBiYWNrbGlnaHRfZGV2aWNlICpiZCkKPiAgewo+IC0JaW50IGludGVuc2l0eSA9IGJkLT5wcm9w cy5icmlnaHRuZXNzOwo+ICAJdTMyIGFkZHIgPSBncGlvX2JhciArIENSVk1MX1BBTkVMX1BPUlQ7 Cj4gIAl1MzIgY3VyID0gaW5sKGFkZHIpOwo+ICAKPiAtLSAKPiAyLjI1LjEKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C8FC433E0 for ; Tue, 21 Jul 2020 08:00:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0415B206E3 for ; Tue, 21 Jul 2020 08:00:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0415B206E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78D686E506; Tue, 21 Jul 2020 08:00:29 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D56E6E506 for ; Tue, 21 Jul 2020 08:00:28 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 002392005C; Tue, 21 Jul 2020 10:00:23 +0200 (CEST) Date: Tue, 21 Jul 2020 10:00:22 +0200 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity' Message-ID: <20200721080022.GA41608@ravnborg.org> References: <20200721073919.925935-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200721073919.925935-1-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=hD80L64hAAAA:8 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=8YDWVOxWXuGqFK3bR7oA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 a=AjGcO6oz07-iQ99wixmX:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGVlLgoKT24gVHVlLCBKdWwgMjEsIDIwMjAgYXQgMDg6Mzk6MTlBTSArMDEwMCwgTGVlIEpv bmVzIHdyb3RlOgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcga2VybmVsIGJ1aWxkIHdhcm5pbmc6Cj4g Cj4gIGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmM6IEluIGZ1bmN0aW9uIOKAmGNy X2JhY2tsaWdodF9zZXRfaW50ZW5zaXR54oCZOgo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9j cl9ibGxjZC5jOjYyOjY6IHdhcm5pbmc6IHVudXNlZCB2YXJpYWJsZSDigJhpbnRlbnNpdHnigJkg Wy1XdW51c2VkLXZhcmlhYmxlXQo+ICA2MiB8IGludCBpbnRlbnNpdHkgPSBiZC0+cHJvcHMuYnJp Z2h0bmVzczsKPiAgfCBefn5+fn5+fn4KPiAKPiBDYzogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJv cmcub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3Jn Pgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiBDYzogQmFydGxvbWll aiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgo+IENjOiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9y Zwo+IEZpeGVzOiAyNGQzNDYxN2MyNGYgKCJiYWNrbGlnaHQ6IGNyX2JsbGNkOiBJbnRyb2R1Y2Ug Z3Bpby1iYWNrbGlnaHQgc2VtYW50aWNzIikKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxl ZS5qb25lc0BsaW5hcm8ub3JnPgoKVGhhbmtzIGZvciBmaXhpbmcgdGhpcy4KVGhlIGRyaXZlciBv bmx5IGJ1aWxkIGZvciBYODYgc28gdGhlIHdhcm5pbmdzIHdhcyBsb3N0IGluIG90aGVyIGJ1aWxk Cm5vaXNlLgpPbmUgbW9yZSB0aGluZyB0byBpbXByb3ZlIGJlZm9yZSBuZXh0IHN1Ym1pc3Npb24g LSBzb3JyeSBmb3IgdGhpcy4KClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9y Zy5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9jcl9ibGxjZC5jIHwgMSAt Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9j cl9ibGxjZC5jCj4gaW5kZXggYTI0ZDQyZTFlYTNjZC4uNGFkMGE3MjUzMWZlMiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9jcl9ibGxjZC5jCj4gKysrIGIvZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvY3JfYmxsY2QuYwo+IEBAIC01OSw3ICs1OSw2IEBAIHN0cnVjdCBjcl9w YW5lbCB7Cj4gIAo+ICBzdGF0aWMgaW50IGNyX2JhY2tsaWdodF9zZXRfaW50ZW5zaXR5KHN0cnVj dCBiYWNrbGlnaHRfZGV2aWNlICpiZCkKPiAgewo+IC0JaW50IGludGVuc2l0eSA9IGJkLT5wcm9w cy5icmlnaHRuZXNzOwo+ICAJdTMyIGFkZHIgPSBncGlvX2JhciArIENSVk1MX1BBTkVMX1BPUlQ7 Cj4gIAl1MzIgY3VyID0gaW5sKGFkZHIpOwo+ICAKPiAtLSAKPiAyLjI1LjEKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF2AC433E2 for ; Tue, 21 Jul 2020 08:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CD02208E4 for ; Tue, 21 Jul 2020 08:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728106AbgGUIAa (ORCPT ); Tue, 21 Jul 2020 04:00:30 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:59986 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgGUIAa (ORCPT ); Tue, 21 Jul 2020 04:00:30 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 002392005C; Tue, 21 Jul 2020 10:00:23 +0200 (CEST) Date: Tue, 21 Jul 2020 10:00:22 +0200 From: Sam Ravnborg To: Lee Jones Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity' Message-ID: <20200721080022.GA41608@ravnborg.org> References: <20200721073919.925935-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200721073919.925935-1-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=hD80L64hAAAA:8 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=8YDWVOxWXuGqFK3bR7oA:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 a=Vxmtnl_E_bksehYqCbjh:22 a=AjGcO6oz07-iQ99wixmX:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee. On Tue, Jul 21, 2020 at 08:39:19AM +0100, Lee Jones wrote: > Fixes the following kernel build warning: > > drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’: > drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable ‘intensity’ [-Wunused-variable] > 62 | int intensity = bd->props.brightness; > | ^~~~~~~~~ > > Cc: Sam Ravnborg > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics") > Signed-off-by: Lee Jones Thanks for fixing this. The driver only build for X86 so the warnings was lost in other build noise. One more thing to improve before next submission - sorry for this. Reviewed-by: Sam Ravnborg > --- > drivers/video/backlight/cr_bllcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c > index a24d42e1ea3cd..4ad0a72531fe2 100644 > --- a/drivers/video/backlight/cr_bllcd.c > +++ b/drivers/video/backlight/cr_bllcd.c > @@ -59,7 +59,6 @@ struct cr_panel { > > static int cr_backlight_set_intensity(struct backlight_device *bd) > { > - int intensity = bd->props.brightness; > u32 addr = gpio_bar + CRVML_PANEL_PORT; > u32 cur = inl(addr); > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel