From: Mike Rapoport <rppt@linux.ibm.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-xtensa@linux-xtensa.org, Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xtensa: fix closing endif comment
Date: Tue, 21 Jul 2020 13:24:09 +0300 [thread overview]
Message-ID: <20200721102042.GD802087@linux.ibm.com> (raw)
In-Reply-To: <20200721024751.1257-1-jcmvbkbc@gmail.com>
On Mon, Jul 20, 2020 at 07:47:51PM -0700, Max Filippov wrote:
> Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
> allocation") introduced the following build warning for xtensa
> arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
> #endif directive [-Wendif-labels]
> Fix #endif comment.
Oops :)
> Cc: Mike Rapoport <rppt@linux.ibm.com>
> Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/xtensa/include/asm/pgalloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
> index 699a8fdf9005..d3a22da4d2c9 100644
> --- a/arch/xtensa/include/asm/pgalloc.h
> +++ b/arch/xtensa/include/asm/pgalloc.h
> @@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
> }
>
> #define pmd_pgtable(pmd) pmd_page(pmd)
> -#endif CONFIG_MMU
> +#endif /* CONFIG_MMU */
>
> #endif /* _XTENSA_PGALLOC_H */
> --
> 2.20.1
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2020-07-21 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 2:47 [PATCH] xtensa: fix closing endif comment Max Filippov
2020-07-28 2:38 ` Max Filippov
2020-07-21 10:24 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721102042.GD802087@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.