From: Kees Cook <keescook@chromium.org>
To: David Howells <dhowells@redhat.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
David Windsor <dwindsor@gmail.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
Elena Reshetova <elena.reshetova@intel.com>,
Paul Moore <paul@paul-moore.com>,
edumazet@google.com, paulmck@kernel.org, shakeelb@google.com,
James Morris <jamorris@linux.microsoft.com>,
alex.huangjianhui@huawei.com, dylix.dailei@huawei.com,
chenzefeng2@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t
Date: Tue, 21 Jul 2020 11:44:53 -0700 [thread overview]
Message-ID: <202007211144.A68C31D@keescook> (raw)
In-Reply-To: <544539.1595328664@warthog.procyon.org.uk>
On Tue, Jul 21, 2020 at 11:51:04AM +0100, David Howells wrote:
> Kees Cook <keescook@chromium.org> wrote:
>
> > > Should mm->mm_users also be replaced by refcount_t?
> >
> > I'll say "yes". :)
> > https://lore.kernel.org/lkml/1487671124-11188-1-git-send-email-elena.reshetova@intel.com/
> >
> > > In addition, is it better to change all variables that use
> > > atomic_dec_and_test to control the release process to refconut_t?
> >
> > For the most part, yes. The following may find a lot of them:
> > scripts/coccinelle/api/atomic_as_refcounter.cocci
>
> I've been gradually undoing some of the conversions as there's no equivalent
> of atomic_add_return() and atomic_dec_return() that allow me to log the
> altered refcount through a tracepoint.
Please do not _undo_ the changes; just add the API you need.
--
Kees Cook
next prev parent reply other threads:[~2020-07-21 18:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 18:34 [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t Kees Cook
2020-06-12 18:34 ` [PATCH 1/3] nsproxy: convert nsproxy.count " Kees Cook
2020-06-12 18:34 ` [PATCH 2/3] groups: convert group_info.usage " Kees Cook
2020-06-15 0:57 ` [groups] 67467ae141: will-it-scale.per_process_ops 4.3% improvement kernel test robot
2020-06-15 0:57 ` kernel test robot
2020-06-12 18:34 ` [PATCH 3/3] creds: convert cred.usage to refcount_t Kees Cook
2020-06-15 2:02 ` Xiaoming Ni
2020-06-15 2:10 ` [PATCH 0/3] Convert nsproxy, groups, and creds " Xiaoming Ni
2020-06-15 3:55 ` Kees Cook
2020-06-15 5:35 ` Reshetova, Elena
2020-06-15 18:08 ` Kees Cook
2020-06-18 7:39 ` Reshetova, Elena
2020-07-21 11:02 ` David Howells
2020-07-21 10:51 ` David Howells
2020-07-21 18:44 ` Kees Cook [this message]
2020-07-21 19:51 ` Peter Zijlstra
2020-07-28 10:56 ` David Howells
2020-07-29 11:11 ` [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value peterz
2020-07-29 11:37 ` peterz
2020-07-29 19:29 ` Kees Cook
2020-07-29 19:30 ` Kees Cook
2020-07-29 20:41 ` David Howells
2020-07-29 20:52 ` Kees Cook
2020-08-27 7:54 ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-09-21 11:22 ` [RFC][PATCH] " Will Deacon
2021-01-26 11:25 ` David Howells
2020-07-28 11:01 ` [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007211144.A68C31D@keescook \
--to=keescook@chromium.org \
--cc=alex.huangjianhui@huawei.com \
--cc=chenzefeng2@huawei.com \
--cc=dhowells@redhat.com \
--cc=dwindsor@gmail.com \
--cc=dylix.dailei@huawei.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=ishkamiel@gmail.com \
--cc=jamorris@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.