From: Jean Delvare <jdelvare@suse.de>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: wsa@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for v5.9] i2c: Replace HTTP links with HTTPS ones
Date: Tue, 21 Jul 2020 11:50:29 +0200 [thread overview]
Message-ID: <20200721115029.5669984b@endymion> (raw)
In-Reply-To: <20200719193553.61319-1-grandmaster@al2klimov.de>
Hi Alexander,
On Sun, 19 Jul 2020 21:35:53 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> (...)
> Documentation/i2c/busses/i2c-ali1535.rst | 2 +-
> Documentation/i2c/busses/i2c-ali15x3.rst | 2 +-
> Documentation/i2c/busses/i2c-piix4.rst | 4 ++--
> drivers/i2c/busses/i2c-ali1535.c | 2 +-
> drivers/i2c/busses/i2c-ali15x3.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
The diffstat above does not match the changes below (specifically
i2c-piix4.rst is NOT modified by your actual patch).
> diff --git a/Documentation/i2c/busses/i2c-ali1535.rst b/Documentation/i2c/busses/i2c-ali1535.rst
> index 6941064730dc..3fe2bad63597 100644
> --- a/Documentation/i2c/busses/i2c-ali1535.rst
> +++ b/Documentation/i2c/busses/i2c-ali1535.rst
> @@ -28,7 +28,7 @@ Additionally, the sequencing of the SMBus transactions has been modified to
> be more consistent with the sequencing recommended by the manufacturer and
> observed through testing. These changes are reflected in this driver and
> can be identified by comparing this driver to the i2c-ali15x3 driver. For
> -an overview of these chips see http://www.acerlabs.com
> +an overview of these chips see https://www.acerlabs.com
> (...)
A quick visit to this website shows that it is dead and useless. The
closest thing nowadays would be https://www.ali.com.tw/ however as far
as I know ALI sold their x86 chipset business to Nvidia in 2006. I
couldn't find information about these old chipsets on either website
though, so I believe that the best course of action would be to strip
the links and surrounding sentences.
I understand this is beyond the scope of your current project. Do you
want me to take care of that?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-07-21 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 19:35 [PATCH for v5.9] i2c: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-21 9:50 ` Jean Delvare [this message]
2020-07-21 17:56 ` Alexander A. Klimov
2020-08-05 9:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721115029.5669984b@endymion \
--to=jdelvare@suse.de \
--cc=grandmaster@al2klimov.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.