From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 21 Jul 2020 14:47:11 +0000 Subject: Re: [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity' Message-Id: <20200721144711.GF621928@dell> List-Id: References: <20200721134841.33893-1-weiyongjun1@huawei.com> In-Reply-To: <20200721134841.33893-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Wei Yongjun Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Hulk Robot , Sam Ravnborg On Tue, 21 Jul 2020, Wei Yongjun wrote: > Gcc report unused-variable warning as follows: > > drivers/video/backlight/cr_bllcd.c:62:6: warning: > unused variable 'intensity' [-Wunused-variable] > 62 | int intensity = bd->props.brightness; > | ^~~~~~~~~ > > After commit 24d34617c24f ("backlight: cr_bllcd: Introduce > gpio-backlight semantics"), this variable is never used, this > commit removing it. > > Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/video/backlight/cr_bllcd.c | 1 - > 1 file changed, 1 deletion(-) Thanks for the patch, but this has already been fixed. > diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c > index a24d42e1ea3c..4ad0a72531fe 100644 > --- a/drivers/video/backlight/cr_bllcd.c > +++ b/drivers/video/backlight/cr_bllcd.c > @@ -59,7 +59,6 @@ struct cr_panel { > > static int cr_backlight_set_intensity(struct backlight_device *bd) > { > - int intensity = bd->props.brightness; > u32 addr = gpio_bar + CRVML_PANEL_PORT; > u32 cur = inl(addr); > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794F0C433E0 for ; Tue, 21 Jul 2020 14:47:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50D4520717 for ; Tue, 21 Jul 2020 14:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FZlxfbBz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50D4520717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BED366E59F; Tue, 21 Jul 2020 14:47:18 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30EF66E5A9 for ; Tue, 21 Jul 2020 14:47:17 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id g10so2359743wmc.1 for ; Tue, 21 Jul 2020 07:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fNGxz0EZnvsEYVO1d5B3FCu46i18q7LLNyU2Zb0GsXw=; b=FZlxfbBzMv/Mv99bS4q6XH2M9JQIzudAk8C+E9ynRtLRrlX+FFqRTkY6dUUJTYVsx9 MbwQz4rp3eDGY+uDX/JEllnSNunccztui3HhWwSzWhUtXNWe6A578ErRwy6TFgtQbIY6 wyNiTkrJ9rzJmvTWpye+mu3S49o+qB5+w/hvsS/+u6kdFvsS5aRuDajMVSEkwV+Kk7Sq qqLf+fmbamozD6zTBYAHp4OlhWXRl9EO/4rW2H//ctPY7jHXtp0c0q3u6WZzWFqCR06A Ns7hAnG9p0XM18hzRwptDvr/Y70R9is31f9lNp2/uqwTiPM9h2XP2U7EWC4/rZObBP1B go0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fNGxz0EZnvsEYVO1d5B3FCu46i18q7LLNyU2Zb0GsXw=; b=hysX7Bxx3h+VkH2iCECfNbBK61nuB/eQlTS9iDOIteYzdW9Nd69NgukOHHqgP61Wiv yOpEz4H98Nf9aWFNIx0fwi6Lwqg9+/lXwWyMaU/WAbDCnUnT5nGf0eemIYTYAV2Rsa2B KRkdn7RCIqjMTYc+s5j2OkAOfO85372EHdEMcXV/ikJo35lex3u/jr41eYtjjySCcnLi OmgAaNSSRnS40BLtyXYUpLVmX7phEvBHD7o1o3XXuFNlu7wg1mytqAS3eQ45cqa/z91c p/semeqZJAltSjk5QE1fBa0eFM6VRXlP78u3aGxkaXdUb0oCGnuO4SlAYLbmIrTSHDsH 9nSA== X-Gm-Message-State: AOAM531Jcu/vbvpzvfALgTiaXsFPeQ3hGf5Wa7xhPu4fuhcWS07/vgJr N6SiTt84jEZwQe7yQX777anK7Q== X-Google-Smtp-Source: ABdhPJxElqrmQU4NxdvdqG6pNVbw5C9a920GKqPa8jgL90mmqhRnnOi+UUmFOIFCOVpkQwnSzyvuXg== X-Received: by 2002:a1c:59c2:: with SMTP id n185mr4607804wmb.104.1595342835775; Tue, 21 Jul 2020 07:47:15 -0700 (PDT) Received: from dell ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id y17sm21855229wrh.63.2020.07.21.07.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 07:47:15 -0700 (PDT) Date: Tue, 21 Jul 2020 15:47:11 +0100 From: Lee Jones To: Wei Yongjun Subject: Re: [PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity' Message-ID: <20200721144711.GF621928@dell> References: <20200721134841.33893-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200721134841.33893-1-weiyongjun1@huawei.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Hulk Robot , Sam Ravnborg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAyMSBKdWwgMjAyMCwgV2VpIFlvbmdqdW4gd3JvdGU6Cgo+IEdjYyByZXBvcnQgdW51 c2VkLXZhcmlhYmxlIHdhcm5pbmcgYXMgZm9sbG93czoKPiAKPiBkcml2ZXJzL3ZpZGVvL2JhY2ts aWdodC9jcl9ibGxjZC5jOjYyOjY6IHdhcm5pbmc6Cj4gIHVudXNlZCB2YXJpYWJsZSAnaW50ZW5z aXR5JyBbLVd1bnVzZWQtdmFyaWFibGVdCj4gICAgNjIgfCAgaW50IGludGVuc2l0eSA9IGJkLT5w cm9wcy5icmlnaHRuZXNzOwo+ICAgICAgIHwgICAgICBefn5+fn5+fn4KPiAKPiBBZnRlciBjb21t aXQgMjRkMzQ2MTdjMjRmICgiYmFja2xpZ2h0OiBjcl9ibGxjZDogSW50cm9kdWNlCj4gZ3Bpby1i YWNrbGlnaHQgc2VtYW50aWNzIiksIHRoaXMgdmFyaWFibGUgaXMgbmV2ZXIgdXNlZCwgdGhpcwo+ IGNvbW1pdCByZW1vdmluZyBpdC4KPiAKPiBGaXhlczogMjRkMzQ2MTdjMjRmICgiYmFja2xpZ2h0 OiBjcl9ibGxjZDogSW50cm9kdWNlIGdwaW8tYmFja2xpZ2h0IHNlbWFudGljcyIpCj4gUmVwb3J0 ZWQtYnk6IEh1bGsgUm9ib3QgPGh1bGtjaUBodWF3ZWkuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFdl aSBZb25nanVuIDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3ZpZGVv L2JhY2tsaWdodC9jcl9ibGxjZC5jIHwgMSAtCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9u KC0pCgpUaGFua3MgZm9yIHRoZSBwYXRjaCwgYnV0IHRoaXMgaGFzIGFscmVhZHkgYmVlbiBmaXhl ZC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmMgYi9k cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9jcl9ibGxjZC5jCj4gaW5kZXggYTI0ZDQyZTFlYTNjLi40 YWQwYTcyNTMxZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvY3JfYmxs Y2QuYwo+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2NyX2JsbGNkLmMKPiBAQCAtNTks NyArNTksNiBAQCBzdHJ1Y3QgY3JfcGFuZWwgewo+ICAKPiAgc3RhdGljIGludCBjcl9iYWNrbGln aHRfc2V0X2ludGVuc2l0eShzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqYmQpCj4gIHsKPiAtCWlu dCBpbnRlbnNpdHkgPSBiZC0+cHJvcHMuYnJpZ2h0bmVzczsKPiAgCXUzMiBhZGRyID0gZ3Bpb19i YXIgKyBDUlZNTF9QQU5FTF9QT1JUOwo+ICAJdTMyIGN1ciA9IGlubChhZGRyKTsKPiAgCj4gCgot LSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3Bl ciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNv Q3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK