From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE36DC433E1 for ; Tue, 21 Jul 2020 15:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA875206E3 for ; Tue, 21 Jul 2020 15:14:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tRaTWoQi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgGUPOU (ORCPT ); Tue, 21 Jul 2020 11:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728089AbgGUPOT (ORCPT ); Tue, 21 Jul 2020 11:14:19 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADDA8C061794 for ; Tue, 21 Jul 2020 08:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3zmi5bZC7KrJcoI9j/XuatFI8VhMfbgZYpubyNYqZP8=; b=tRaTWoQinQH1O2pREmbQu9Svn I+XlS9i1vL3UizYE9PSGEFiQJHSe6o6KWQVRl1TAPsChseO1lv/57SoZ13Rv5Hoa7vt6DEPx4XWdL YF+c8s3Ss8MHPlbhgRrAVz82nUMDh0auOBtE+wv3GlLG9AbYTeSaZ/7Dsa9q8BQIV5/fPvvBrhctw 8e9vF5FBudlJSebsaDAndm/jqfBaoHWjr+RzqAIz68cYcODOSx+c17d+sgUE0Ov/RnUHV7F3I+mva w+wWgcOl3UIFLKfiUC9NIFwaZ8y/P3NxZZSUDIRnKOGVn8NrdptLJsmp7QmmFnLCrcViHkJ8dbHER pZ3+W/bhw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42360) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxtyE-0004Tb-Am; Tue, 21 Jul 2020 16:14:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jxtyE-00066B-0b; Tue, 21 Jul 2020 16:14:18 +0100 Date: Tue, 21 Jul 2020 16:14:17 +0100 From: Russell King - ARM Linux admin To: Chuck Lever Cc: linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org Subject: Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) Message-ID: <20200721151417.GU1605@shell.armlinux.org.uk> References: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org A build of my tree by Olof's autobuilder revealed a problem concerning a couple of platforms - this is based on v5.8-rc3: On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote: > arm.mps2_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > > arm.xcep_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] The issue is that as the #if concerned is used to determine whether code that calls flush_dcache_page() (and therefore ensures data integrity) is omitted - and in the above cases it will be omitted. On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in asm/cacheflush.h, but for some reason, it seems that net/sunrpc/svcsock.c is not seeing that. Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to ensure it picks up the definition of this preprocessor symbol? It looks like this was introduced by: commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8 Author: Chuck Lever Date: Wed May 20 17:30:12 2020 -0400 SUNRPC: Refactor svc_recvfrom() Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6827C433E3 for ; Tue, 21 Jul 2020 15:15:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83009206E3 for ; Tue, 21 Jul 2020 15:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mwTEMTlO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="tRaTWoQi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83009206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IHwAtZ1ZiTKbY1+7N+xhk7eL327eGF9jXM1nG0lFPPs=; b=mwTEMTlOSD2JkUEt30XpES8AY T0q3VmNtPHOZfJ0cJtCSFf/r1eu038xHy3smehkDm1+/6OFHA+J3cKHyzePew/8RHu/70YeYI7FMu YHgLSF43sW4F5tgQmWYTK+f8IFC7YiQ42Ikne1lyBxAIQbv8bQKol+dbMJuPq0i/uWQ/vzl/eDy6z Gfcyg+HxNMAz6YUi/a3TGiXLATrFhfG6UMH/REzYfxg2/Bpfs/RaD7c9bTcHQasLh3zupBFNoRYOu iAVd8TOY1Q5OGzP/heF+4iNVpfox2HLqYRbyG/dl7VWExVBEajR8HMRs6ce4rOIgpegdlgFdDi9m+ cZYT6Au6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxtyH-0000k5-OQ; Tue, 21 Jul 2020 15:14:21 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxtyF-0000jb-NP for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 15:14:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3zmi5bZC7KrJcoI9j/XuatFI8VhMfbgZYpubyNYqZP8=; b=tRaTWoQinQH1O2pREmbQu9Svn I+XlS9i1vL3UizYE9PSGEFiQJHSe6o6KWQVRl1TAPsChseO1lv/57SoZ13Rv5Hoa7vt6DEPx4XWdL YF+c8s3Ss8MHPlbhgRrAVz82nUMDh0auOBtE+wv3GlLG9AbYTeSaZ/7Dsa9q8BQIV5/fPvvBrhctw 8e9vF5FBudlJSebsaDAndm/jqfBaoHWjr+RzqAIz68cYcODOSx+c17d+sgUE0Ov/RnUHV7F3I+mva w+wWgcOl3UIFLKfiUC9NIFwaZ8y/P3NxZZSUDIRnKOGVn8NrdptLJsmp7QmmFnLCrcViHkJ8dbHER pZ3+W/bhw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42360) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxtyE-0004Tb-Am; Tue, 21 Jul 2020 16:14:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jxtyE-00066B-0b; Tue, 21 Jul 2020 16:14:18 +0100 Date: Tue, 21 Jul 2020 16:14:17 +0100 From: Russell King - ARM Linux admin To: Chuck Lever Subject: Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) Message-ID: <20200721151417.GU1605@shell.armlinux.org.uk> References: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_111419_788618_DA1C253D X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nfs@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org A build of my tree by Olof's autobuilder revealed a problem concerning a couple of platforms - this is based on v5.8-rc3: On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote: > arm.mps2_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > > arm.xcep_defconfig: > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] > net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef] The issue is that as the #if concerned is used to determine whether code that calls flush_dcache_page() (and therefore ensures data integrity) is omitted - and in the above cases it will be omitted. On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in asm/cacheflush.h, but for some reason, it seems that net/sunrpc/svcsock.c is not seeing that. Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to ensure it picks up the definition of this preprocessor symbol? It looks like this was introduced by: commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8 Author: Chuck Lever Date: Wed May 20 17:30:12 2020 -0400 SUNRPC: Refactor svc_recvfrom() Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel