From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9362FC433E4 for ; Tue, 21 Jul 2020 17:14:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CCE92065D for ; Tue, 21 Jul 2020 17:14:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BfUN0WIP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IzLyoyL+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CCE92065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jok/ceZCiPK2atwRMEfhcMJgZpFuYDkmw3hrfZemtrA=; b=BfUN0WIPEtvo8iRk8lqcJm7lB hUQdTJs1VFyx3n2+49cq9bhPsoPvAU04vuyIheOQp9ZhBTwA54cDhYMgy/NPD58woygnq8deuffJM 1WUpI5lYrkYNmUNHwZ31H1TMN5j60ejTqTcwlAqHYoMMc0+86nzSIihBPn56ZsqRc2VBkK2cITiRW IDP5GfDqufAA4cqSfw0Uo0IqXsol/8JirGSTwP2tvRMdgU+b98dR3yaY4iCDJBHeQO8K7jOHMgE46 +B72zucSg0soLT6L520L+rrKmMYc3QNgjsfW/33qKwYrW0ynKrtJqprYa75NVUY4vS/sHfmvaKigF BQ/xdbsrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxvoc-0000K3-Dg; Tue, 21 Jul 2020 17:12:30 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxvoZ-0000J5-EY for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 17:12:28 +0000 Received: by mail-pf1-x443.google.com with SMTP id 1so11040801pfn.9 for ; Tue, 21 Jul 2020 10:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vgoZoKuMP6lEje0UO1KgSrV513xxJsKAXnaDS9dbTHo=; b=IzLyoyL+pq6Hsw7jU8Q2e2fkhNUoXW6wVvqJU+fNZaKO8CmCRrlgj1bD+nyMZuF1+B hYFQvzWZV3pj2tNlBSKjoV9pD23SBLFcUSWDn/jmmW44kmWN7hLgqkD7iJQhN/1W5Jp7 MIOJ4U4BltkuponoqUh8nEBhz76fY0sw2e+LpKaQ+0nuRLjKcAHYvQ3mITNhcIl74pDk 2L/zoy6fElWNZnRsEEDkPBGzXhmhbUBnvoGLDm/tSnNNlajJ2WdBJmMOIR/joDrgJCKo +fEFSLcPTi+5FcofQAsEkdbDU/Fc39fjhq5c4RD+N0UZLf0dsJtrR6z0Qrn5igw30Yvx WIvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vgoZoKuMP6lEje0UO1KgSrV513xxJsKAXnaDS9dbTHo=; b=rvkJw2dIauZQktTENHMIK5WQa2d3WTjPXR5zw6EIJd5+lpu0FMwsF0l0Sr6twAFEUm vgnk8DXRSUBB5ism7WWsxj0R7iBTTabVbXZ6yBSSgModAkd2R7FZ8EArwrUH6pmPcVfV UZWitTTi0FtEQ2ju7HJQ5NAT++qStyzZATqH8tRXE2UQB2++RVuoqoF4P0XfZpxRffrZ 7gNSmbAd1EuZZEiq4VPEZ5xre9/fnP+bLFH9iYqW5+4wqP/d+3LWxrvexok7eGU6MIwQ 2sSKwrNPUg6hsfLXXemfPdc7/RqkBYQaTiEJevws42sVmhWZSzymv0wSy6bbK9hMDejF bQtQ== X-Gm-Message-State: AOAM530IzRqIsQIyaEwgDKxuodsw5SPyOQ7cqM2R4ERRibhLhKnAOqM8 CzUp/lBwI0xKQ0eFzfPeLhDXmg== X-Google-Smtp-Source: ABdhPJw37KwxI6ULQZXyOsB8/qIkGxCeCmjDwgQnhVcoEIFuE9dyuxOEvMSe0hUZG9p6TUTaPHiP+w== X-Received: by 2002:a63:d143:: with SMTP id c3mr23114049pgj.306.1595351541490; Tue, 21 Jul 2020 10:12:21 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id r2sm20639441pfh.106.2020.07.21.10.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 10:12:20 -0700 (PDT) Date: Tue, 21 Jul 2020 11:12:18 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH] coresight: stm: support marked packet Message-ID: <20200721171218.GA1217536@xps15> References: <20200719062712.29133-1-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200719062712.29133-1-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_131227_779305_64C73A05 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Suzuki K Poulose , Alexander Shishkin , coresight@lists.linaro.org, Mao Jinlong , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tingwei, On Sun, Jul 19, 2020 at 02:27:12PM +0800, Tingwei Zhang wrote: > STP_PACKET_MARKED is not supported by STM currently. > Add STM_FLAG_MARKED to support marked packet in STM. > > Signed-off-by: Tingwei Zhang > --- > drivers/hwtracing/coresight/coresight-stm.c | 11 +++++++---- > include/uapi/linux/coresight-stm.h | 1 + > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index b908ca104645..36fb1838b1d1 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -412,6 +412,7 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > void __iomem *ch_addr; > struct stm_drvdata *drvdata = container_of(stm_data, > struct stm_drvdata, stm); > + unsigned int stm_flags; > > if (!(drvdata && local_read(&drvdata->mode))) > return -EACCES; > @@ -421,8 +422,10 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > > ch_addr = stm_channel_addr(drvdata, channel); > > - flags = (flags == STP_PACKET_TIMESTAMPED) ? STM_FLAG_TIMESTAMPED : 0; > - flags |= test_bit(channel, drvdata->chs.guaranteed) ? > + stm_flags = (flags & STP_PACKET_TIMESTAMPED) ? > + STM_FLAG_TIMESTAMPED : 0; > + stm_flags |= (flags & STP_PACKET_MARKED) ? STM_FLAG_MARKED : 0; Looking at the STM programmer's manual there is a marked area for data packets only. Clearing the marked bit for non-data access ends up in a reserved area and yet here it is set invariably. Out of curiosity, what kind of use case are you using this for? Thanks, Mathieu > + stm_flags |= test_bit(channel, drvdata->chs.guaranteed) ? > STM_FLAG_GUARANTEED : 0; > > if (size > drvdata->write_bytes) > @@ -432,7 +435,7 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > > switch (packet) { > case STP_PACKET_FLAG: > - ch_addr += stm_channel_off(STM_PKT_TYPE_FLAG, flags); > + ch_addr += stm_channel_off(STM_PKT_TYPE_FLAG, stm_flags); > > /* > * The generic STM core sets a size of '0' on flag packets. > @@ -444,7 +447,7 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > break; > > case STP_PACKET_DATA: > - ch_addr += stm_channel_off(STM_PKT_TYPE_DATA, flags); > + ch_addr += stm_channel_off(STM_PKT_TYPE_DATA, stm_flags); > stm_send(ch_addr, payload, size, > drvdata->write_bytes); > break; > diff --git a/include/uapi/linux/coresight-stm.h b/include/uapi/linux/coresight-stm.h > index 8847dbf24151..7ff3709c01b8 100644 > --- a/include/uapi/linux/coresight-stm.h > +++ b/include/uapi/linux/coresight-stm.h > @@ -5,6 +5,7 @@ > #include > > #define STM_FLAG_TIMESTAMPED _BITUL(3) > +#define STM_FLAG_MARKED _BITUL(4) > #define STM_FLAG_GUARANTEED _BITUL(7) > > /* > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel