From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] meye: fix missing pm_mchip_mode field
Date: Wed, 22 Jul 2020 11:38:33 +0530 [thread overview]
Message-ID: <20200722060833.GA1365@gmail.com> (raw)
In-Reply-To: <6c163ae3-5aff-e44c-95b5-4eedc73ccc93@xs4all.nl>
On Tue, Jul 21, 2020 at 11:32:29PM +0200, Hans Verkuil wrote:
> After patch 9c4a8489ab7c ("media: meye: use generic power management")
> the pm_mchip_mode field should now always be present, even if CONFIG_PM
> is not set.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 9c4a8489ab7c ("media: meye: use generic power management")
> ---
> diff --git a/drivers/media/pci/meye/meye.h b/drivers/media/pci/meye/meye.h
> index c957d9b55f89..5fa6552cf93d 100644
> --- a/drivers/media/pci/meye/meye.h
> +++ b/drivers/media/pci/meye/meye.h
> @@ -305,9 +305,7 @@ struct meye {
> u16 colour;
> struct meye_params params; /* additional parameters */
> unsigned long in_use; /* set to 1 if the device is in use */
> -#ifdef CONFIG_PM
> u8 pm_mchip_mode; /* old mchip mode */
> -#endif
> };
>
> #endif
Thank you so much for the fix.
--Vaibhav Gupta
prev parent reply other threads:[~2020-07-22 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 21:32 [PATCH] meye: fix missing pm_mchip_mode field Hans Verkuil
2020-07-22 6:08 ` Vaibhav Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722060833.GA1365@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.