From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v6 2/3] leds: initial support for Turris Omnia LEDs
Date: Wed, 22 Jul 2020 09:15:42 +0200 [thread overview]
Message-ID: <20200722071542.GB8984@amd> (raw)
In-Reply-To: <20200721125922.10979-3-marek.behun@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
Hi!
> +
> +/*
> + * On the front panel of the Turris Omnia router there is also a button which can be used to control
> + * the intensity of all the LEDs at once, so that if they are too bright, user can dim them.
> + * The microcontroller cycles between 8 levels of this global brightness (from 100% to 0%), but this
> + * setting can have any integer value between 0 and 100. It is therefore convenient to be able to
> + * change this setting from software.
> + * We expose this setting via a sysfs attribute file called "brightness". This file lives in the
> + * device directory of the LED controller, not an individual LED, so it should not confuse users.
> + */
Lets keep comments formatted to 80 columns. This overflew my screen
and is unreadable.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-22 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 12:59 [PATCH v6 0/3] Add Turris Omnia LEDs driver Marek Behún
2020-07-21 12:59 ` [PATCH v6 1/3] dt-bindings: leds: add cznic,turris-omnia-leds binding Marek Behún
2020-07-21 12:59 ` [PATCH v6 2/3] leds: initial support for Turris Omnia LEDs Marek Behún
2020-07-22 7:15 ` Pavel Machek [this message]
2020-07-22 10:34 ` Marek Behun
2020-07-21 12:59 ` [PATCH v6 3/3] Documentation: ABI: leds-turris-omnia: document sysfs attribute Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722071542.GB8984@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.