From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Bingbu Cao <bingbu.cao@intel.com>
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
senozhatsky@chromium.org, bingbu.cao@linux.intel.com,
qingwu.zhang@intel.com
Subject: Re: [PATCH] media: i2c: ov2740: get OTP data ready before nvmem registration
Date: Wed, 22 Jul 2020 17:20:41 +0900 [thread overview]
Message-ID: <20200722082041.GA42181@google.com> (raw)
In-Reply-To: <1595326295-25213-1-git-send-email-bingbu.cao@intel.com>
On (20/07/21 18:11), Bingbu Cao wrote:
> The OTP data was not ready after registered as nvmem device, it is
> risky as the nvmem read may happen once the device exists, this patch
> get the OTP data ready before registering the nvmem device. OTP data
> missing should not break the normal camera sensor probe, so use a
> warning instead of an error message.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Signed-off-by: Qingwu Zhang <qingwu.zhang@intel.com>
> Suggested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Looks good to me,
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
-ss
prev parent reply other threads:[~2020-07-22 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:11 [PATCH] media: i2c: ov2740: get OTP data ready before nvmem registration Bingbu Cao
2020-07-22 8:20 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722082041.GA42181@google.com \
--to=senozhatsky@chromium.org \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=qingwu.zhang@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.