From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: kishon@ti.com, vkoul@kernel.org, geert+renesas@glider.be,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] phy: renesas: rcar-gen3-usb2: exit if request_irq() failed
Date: Wed, 22 Jul 2020 10:28:45 +0200 [thread overview]
Message-ID: <20200722082845.GB1030@ninjato> (raw)
In-Reply-To: <1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On Fri, Jul 17, 2020 at 08:44:57PM +0900, Yoshihiro Shimoda wrote:
> To avoid unexpected behaviors, it's better to exit if request_irq()
> failed.
>
> Suggested-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Makes sense to me.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-22 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 11:44 [PATCH v3 0/2] phy: renesas: rcar-gen3-usb2: fix an issue and minor update Yoshihiro Shimoda
2020-07-17 11:44 ` [PATCH v3 1/2] phy: renesas: rcar-gen3-usb2: move irq registration to init Yoshihiro Shimoda
2020-07-22 8:27 ` Wolfram Sang
2020-07-17 11:44 ` [PATCH v3 2/2] phy: renesas: rcar-gen3-usb2: exit if request_irq() failed Yoshihiro Shimoda
2020-07-22 8:28 ` Wolfram Sang [this message]
2020-07-20 6:33 ` [PATCH v3 0/2] phy: renesas: rcar-gen3-usb2: fix an issue and minor update Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722082845.GB1030@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.