From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, "Tomáš Golembiovský" <tgolembi@redhat.com>,
qemu-devel@nongnu.org, "Michael Roth" <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/4] qga/commands-posix: Move the udev code from the pci to the generic function
Date: Wed, 22 Jul 2020 10:18:38 +0100 [thread overview]
Message-ID: <20200722091838.GG2323046@redhat.com> (raw)
In-Reply-To: <20200722044028.4059-4-thuth@redhat.com>
On Wed, Jul 22, 2020 at 06:40:27AM +0200, Thomas Huth wrote:
> The libudev-related code is independent from the other pci-related code
> and can be re-used for non-pci devices (like ccw devices on s390x). Thus
> move this part to the generic function.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qga/commands-posix.c | 62 +++++++++++++++++++++++---------------------
> 1 file changed, 33 insertions(+), 29 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-22 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 4:40 [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices Thomas Huth
2020-07-22 4:40 ` [PATCH v2 1/4] qga/qapi-schema: Document -1 for invalid PCI address fields Thomas Huth
2020-07-22 4:40 ` [PATCH v2 2/4] qga/commands-posix: Rework build_guest_fsinfo_for_real_device() function Thomas Huth
2020-07-22 9:19 ` Daniel P. Berrangé
2020-07-22 4:40 ` [PATCH v2 3/4] qga/commands-posix: Move the udev code from the pci to the generic function Thomas Huth
2020-07-22 9:18 ` Daniel P. Berrangé [this message]
2020-07-22 4:40 ` [PATCH v2 4/4] qga/commands-posix: Support fsinfo for non-PCI virtio devices, too Thomas Huth
2020-07-22 9:18 ` Daniel P. Berrangé
2020-07-27 23:29 ` [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722091838.GG2323046@redhat.com \
--to=berrange@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=tgolembi@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.