Re: [PATCH 2/2] USB: Fix source path in header

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jul 22, 2020 at 11:58:54AM +0200, Bastien Nocera wrote:
> On Wed, 2020-07-22 at 11:51 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jul 22, 2020 at 11:46:28AM +0200, Bastien Nocera wrote:
> > > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > 
> > I can't take patches without any changelog text at all, sorry.
> 
> The subject line isn't clear enough?

Maybe, maybe not, doesn't mean you shouldn't also write some text about
why you did what you did.

> > > ---
> > >  drivers/usb/core/driver.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> > > index a6187dd2186c..bd346e683af3 100644
> > > --- a/drivers/usb/core/driver.c
> > > +++ b/drivers/usb/core/driver.c
> > > @@ -1,6 +1,6 @@
> > >  // SPDX-License-Identifier: GPL-2.0
> > >  /*
> > > - * drivers/usb/driver.c - most of the driver model stuff for usb
> > > + * drivers/usb/core/driver.c - most of the driver model stuff for
> > > usb
> > 
> > Just drop the whole file name, it's not needed at all.
> 
> And the description after or just the filename?

The description is fine to keep.

thanks,

greg k-h