From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F20AC433E6 for ; Wed, 22 Jul 2020 12:49:02 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62F5B206E3 for ; Wed, 22 Jul 2020 12:49:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F5B206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3F78786968; Wed, 22 Jul 2020 12:49:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LJZIAjNv-1HN; Wed, 22 Jul 2020 12:49:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id A71DD86972; Wed, 22 Jul 2020 12:49:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8FC4AC004E; Wed, 22 Jul 2020 12:49:00 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 146DBC004C for ; Wed, 22 Jul 2020 12:48:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E1F5E20478 for ; Wed, 22 Jul 2020 12:48:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EiKQsbfRhLQ5 for ; Wed, 22 Jul 2020 12:48:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id 0A098203BA for ; Wed, 22 Jul 2020 12:48:58 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 682032C8; Wed, 22 Jul 2020 14:48:56 +0200 (CEST) Date: Wed, 22 Jul 2020 14:48:55 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices Message-ID: <20200722124854.GZ27672@8bytes.org> References: <20200713131426.GQ27672@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jonathan.lemon@gmail.com, dwmw2@infradead.org, hch@lst.de, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote: > Oh bother - yes, this could have been masking all manner of bugs. That > system will presumably also break if you managed to exhaust the 32-bit IOVA > space such that the allocator moved up to the higher range anyway, or if you > passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I > guess those are cases that simply nobody's run into yet. > > Does the firmware actually report any upper address constraint such that > Sebastian's IVRS aperture patches might help? No, it doesn't. I am not sure what the best way is to get these issues found and fixed. I doubt they will be getting fixed when the allocation pattern isn't changed, maybe we can put your changes behind a config variable and start testing/reporting bugs/etc. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9140CC433E2 for ; Wed, 22 Jul 2020 12:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73DC2206E3 for ; Wed, 22 Jul 2020 12:49:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732154AbgGVMtA (ORCPT ); Wed, 22 Jul 2020 08:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgGVMs7 (ORCPT ); Wed, 22 Jul 2020 08:48:59 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FB65C0619DC; Wed, 22 Jul 2020 05:48:59 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 682032C8; Wed, 22 Jul 2020 14:48:56 +0200 (CEST) Date: Wed, 22 Jul 2020 14:48:55 +0200 From: Joerg Roedel To: Robin Murphy Cc: hch@lst.de, iommu@lists.linux-foundation.org, jonathan.lemon@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices Message-ID: <20200722124854.GZ27672@8bytes.org> References: <20200713131426.GQ27672@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote: > Oh bother - yes, this could have been masking all manner of bugs. That > system will presumably also break if you managed to exhaust the 32-bit IOVA > space such that the allocator moved up to the higher range anyway, or if you > passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I > guess those are cases that simply nobody's run into yet. > > Does the firmware actually report any upper address constraint such that > Sebastian's IVRS aperture patches might help? No, it doesn't. I am not sure what the best way is to get these issues found and fixed. I doubt they will be getting fixed when the allocation pattern isn't changed, maybe we can put your changes behind a config variable and start testing/reporting bugs/etc. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036E3C433EA for ; Wed, 22 Jul 2020 12:50:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C719B20771 for ; Wed, 22 Jul 2020 12:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HPOjVw9e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C719B20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gCyX9zRxFrFdSwKKyujZ8IvjMQ7c1Y3XOP5mNwKR5S8=; b=HPOjVw9esA+DDeDabaI42g/Yo V11zXMW1Xb138mYHJk7qMHQzOWOna6lbLI3qXX64qGf9yg6FEmAwCKnA/isQQ3AhF0/ZBvXh2hykU VcR5/mrCZpxrTWa6WXeMqMLiqEa+bJGBCYMxC9zghHLvldNU/GMODqWi9D15+KhGbyez4rAAVSvGq 9xo2Xb/QLbn1WPd0tRXEMX0wRgYtffuzIDtmYlAAeAONbr8o722RMRkMcVu512yGF8msknd6xUqaz w/S8+Dsp8TrCWVzaOVHMDk7BZHTE2qgFR+oigDZvqDhgBuu22/UoKkzODp7kulOriskUYnq6spzhw gDtH9b7Kg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyEBH-000184-DJ; Wed, 22 Jul 2020 12:49:07 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyEBE-00016V-NU for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 12:49:05 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 682032C8; Wed, 22 Jul 2020 14:48:56 +0200 (CEST) Date: Wed, 22 Jul 2020 14:48:55 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices Message-ID: <20200722124854.GZ27672@8bytes.org> References: <20200713131426.GQ27672@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_084904_878707_C11A313D X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jonathan.lemon@gmail.com, dwmw2@infradead.org, hch@lst.de, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote: > Oh bother - yes, this could have been masking all manner of bugs. That > system will presumably also break if you managed to exhaust the 32-bit IOVA > space such that the allocator moved up to the higher range anyway, or if you > passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I > guess those are cases that simply nobody's run into yet. > > Does the firmware actually report any upper address constraint such that > Sebastian's IVRS aperture patches might help? No, it doesn't. I am not sure what the best way is to get these issues found and fixed. I doubt they will be getting fixed when the allocation pattern isn't changed, maybe we can put your changes behind a config variable and start testing/reporting bugs/etc. Regards, Joerg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel