From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9695FC433E8 for ; Wed, 22 Jul 2020 14:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 728E820771 for ; Wed, 22 Jul 2020 14:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595426736; bh=iloCKMSR9b1tfTvy/7rJoAq1rMiDVjg+2iSq3QdT19U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JnF+sTrA2Nbt2bY4UdhLrXdd37oZBtVnNEQz4L7FFIbjbRgFkhjhnnvE1v7hXq2OH fosecdTGpx1Y97urg08WeADXHo3Y6d3KtjHl+Idl8AJLs69VDAb0DVGKu5rx4hzRdL iD947Po62Dy1jJOc2/UgB2Hr2NnRO00NHhJZBvqA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732511AbgGVOFc (ORCPT ); Wed, 22 Jul 2020 10:05:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:37710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728837AbgGVOFb (ORCPT ); Wed, 22 Jul 2020 10:05:31 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A985205CB; Wed, 22 Jul 2020 14:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595426730; bh=iloCKMSR9b1tfTvy/7rJoAq1rMiDVjg+2iSq3QdT19U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iNeeTwj3TjCoEzSr90MvRIkmt/LcCd92oxk5dJb0VzqASUTyQLM+pe7WqjMEeJNMG Y4VfbbE9YN4YiWrBOJmYU55zvAncU0xsd8XHsQdaRBOUwEprSWaR/7ldZncgeYLoXu op/ZtUkB8cyVJE6ry2C54BdykodXWFHClDXjQw8w= Date: Wed, 22 Jul 2020 16:05:26 +0200 From: Mauro Carvalho Chehab To: Rahul Gottipati Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: atomisp: Fix coding style issue - correct multiline comments Message-ID: <20200722160526.5b83341e@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Wed, 22 Jul 2020 17:00:52 +0530 Rahul Gottipati escreveu: > This fixes some coding style issues of multiline comments to > correct a few checkpatch.pl warnings. > > Signed-off-by: Rahul Gottipati > --- > Changes in v2: > Distributed changes across 2 patches instead of the previous 1. > drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > index 9cdcbe774229..5bf3a86f98f8 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > @@ -1281,7 +1281,8 @@ static int atomisp_qbuf(struct file *file, void *fh, struct v4l2_buffer *buf) > * But the capture number cannot be determined by HAL. > * So HAL only sets the capture number to be 1 and queue multiple > * buffers. Atomisp driver needs to check this case and re-trigger > - * CSS to do capture when new buffer is queued. */ > + * CSS to do capture when new buffer is queued. > + */ > if (asd->continuous_mode->val && > atomisp_subdev_source_pad(vdev) > == ATOMISP_SUBDEV_PAD_SOURCE_CAPTURE && > @@ -1806,7 +1807,7 @@ static int atomisp_streamon(struct file *file, void *fh, > /* > * set freq to max when streaming count > 1 which indicate > * dual camera would run > - */ > + */ > if (atomisp_streaming_count(isp) > 1) { > if (atomisp_freq_scaling(isp, > ATOMISP_DFS_MODE_MAX, false) < 0) > @@ -2438,7 +2439,8 @@ static int atomisp_g_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ On media (and on several subsystems), we keep the first line in blank, on multi-line comments: /* * input_lock is not need for the Camera related IOCTLs * The input_lock downgrade the FPS of 3A */ > ret = atomisp_camera_g_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; > @@ -2521,7 +2523,8 @@ static int atomisp_camera_s_ext_ctrls(struct file *file, void *fh, > v4l2_s_ctrl(NULL, isp->flash->ctrl_handler, > &ctrl); > /* When flash mode is changed we need to reset > - * flash state */ > + * flash state > + */ > if (ctrl.id == V4L2_CID_FLASH_MODE) { > asd->params.flash_state = > ATOMISP_FLASH_IDLE; > @@ -2560,7 +2563,8 @@ static int atomisp_s_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ > ret = atomisp_camera_s_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; Thanks, Mauro