From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE25C433F2 for ; Wed, 22 Jul 2020 17:06:17 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01DF3206F5; Wed, 22 Jul 2020 17:06:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="fYL79JDa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="j0CI3qo4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fo21+ikb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01DF3206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jyIC8-0008PK-LJ; Wed, 22 Jul 2020 17:06:16 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyIC7-0008P9-39 for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jul 2020 17:06:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=livU0pCa/qsmiUVAc6nFK7s7ABNUCWCuotAdUiOGYwg=; b=fYL79JDap6YOLXdOUOZ+2Efs2j EKNQUoqe+qRYCPejM3bTCj30+j6sTYazwhhrjNQh/tVkCSx2FJm9vmN7Wgvp853RKVzy6h/jGzi33 udnKC32LWywhvnr835D6Vd64Vcx4JnN2VE3oFJBgydQ/3TRyeJ2DAjYdir16LxoSjZcg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=livU0pCa/qsmiUVAc6nFK7s7ABNUCWCuotAdUiOGYwg=; b=j0CI3qo4SOm5CJJg3A9dIzGhoM SrQShSliIAGWEmoCQBpwyZsVRPqEF2DDIznaJsS1PqlSrjXjOkXtrnzZtnNuURorDEzR/SfzdEfoe m64UQ/gHm3Db8Y26KKrBiA1mmTZMZIpGQwwd+dWigiT3aBoPjqmVYJEs44NqccrsobVM=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jyIC2-00DlxV-Jp for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jul 2020 17:06:15 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77903207E8; Wed, 22 Jul 2020 17:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595437558; bh=OR5cu9ZiOnyEIuGOim8D0YhB42FI73IvAZzLYBaMrAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fo21+ikbWeaUKIlmQNUaTc7OWl1nlaenOWLBZXBwygMsnaX9HuJ9knbDk583vacjj YNS64Wb3BIoGLj8a7Y/fgPhNnSc5EFsxGH21pGPqhSDx3BY8knZVbnQw+puTpgdjIy f1s8m7QiEWgjc5Abrl8IzGXrbNwOtsHQ0SzVKdFg= Date: Wed, 22 Jul 2020 19:06:02 +0200 From: Greg KH To: Jaegeuk Kim Message-ID: <20200722170602.GA440171@kroah.com> References: <20200719054409.3050516-1-daeho43@gmail.com> <20200719151640.GA301791@kroah.com> <20200722164356.GA3912099@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200722164356.GA3912099@google.com> X-Headers-End: 1jyIC2-00DlxV-Jp Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gV2VkLCBKdWwgMjIsIDIwMjAgYXQgMDk6NDM6NTZBTSAtMDcwMCwgSmFlZ2V1ayBLaW0gd3Jv dGU6Cj4gT24gMDcvMTksIEdyZWcgS0ggd3JvdGU6Cj4gPiBPbiBTdW4sIEp1bCAxOSwgMjAyMCBh dCAwMjo0NDowOFBNICswOTAwLCBEYWVobyBKZW9uZyB3cm90ZToKPiA+ID4gRnJvbTogRGFlaG8g SmVvbmcgPGRhZWhvamVvbmdAZ29vZ2xlLmNvbT4KPiA+ID4gCj4gPiA+IEFkZGVkIGEgc3ltYm9s aWMgbGluayBkaXJlY3RvcnkgcG9pbnRpbmcgdG8gaXRzIGRldmljZSBuYW1lCj4gPiA+IGRpcmVj dG9yeSB1c2luZyB0aGUgdm9sdW1lIG5hbWUgb2YgdGhlIHBhcnRpdGlvbiBpbiBzeXNmcy4KPiA+ ID4gKGkuZS4sIC9zeXMvZnMvZjJmcy92b2xfI3ggLT4gL3N5cy9mcy9mMmZzL3NkYTEpCj4gPiAK PiA+IE5vLCBwbGVhc2Ugbm8uCj4gPiAKPiA+IFRoYXQgaXMgYWxyZWFkeSBjcmVhdGVkIHRvZGF5 IGZvciB5b3UgaW4gL2Rldi9kaXNrLyAgVGhlIGtlcm5lbCBkb2VzIG5vdAo+ID4gbmVlZCB0byBk byB0aGlzIGFnYWluLgo+ID4gCj4gPiBJZiB5b3VyIGRpc3Ryby9zeXN0ZW0vd2hhdGV2ZXIgZG9l cyBub3QgcHJvdmlkZSB5b3Ugd2l0aCAvZGV2L2Rpc2svIGFuZAo+ID4gYWxsIG9mIHRoZSBzeW1s aW5rcyBpbiB0aGVyZSwgdGhlbiB3b3JrIHdpdGggeW91ciBkaXN0cm8vc3lzdGVtL3doYXRldmVy Cj4gPiB0byBkbyBzby4KPiAKPiBJIGRvbid0IGdldCB0aGUgcG9pbnQsIHNpbmNlIC9kZXYvZGlz ayBwb2ludHMgZGV2aWNlIG5vZGUsIG5vdCBhbnkgc3lzZnMgZW50cnkuCj4gRG8geW91IG1lYW4g d2UgbmVlZCB0byBjcmVhdGUgc3ltbGluayB0byAvc3lzL2ZzL2YyZnMvZG0tWCBpbiAvZGV2L2Rp c2s/CgpIdWgsIG5vISAgSXQncyBhbGwgZG9uZSBmb3IgeW91IHRvZGF5IGF1dG9tYWdpY2FsbHkg YnkgdXNlcnNwYWNlOgoKJCB0cmVlIC9kZXYvZGlzay9ieS1sYWJlbC8KL2Rldi9kaXNrL2J5LWxh YmVsLwrilJzilIDilIAgYm9vdCAtPiAuLi8uLi9zZGExCuKUnOKUgOKUgCBmYXN0X2Rpc2sgLT4g Li4vLi4vbWQwCuKUnOKUgOKUgCByb290IC0+IC4uLy4uL3NkYTIK4pSU4pSA4pSAIHN0dWZmIC0+ IC4uLy4uL2RtLTAKCkxvb2sgb24geW91ciBsYXB0b3AvZGVza3RvcC9zZXJ2ZXIgdG9kYXkgZm9y IHRob3NlLCB0aGVyZSdzIGxvdHMgb2YKc3ltbGlua3MgaW4gL2Rldi9kaXNrLwoKPiA+IEFnYWlu LCBubyBuZWVkIHRvIGRvIHRoaXMgb24gYSBwZXItZmlsZXN5c3RlbS1iYXNpcyB3aGVuIHdlIGFs cmVhZHkgaGF2ZQo+ID4gdGhpcyBhcm91bmQgZm9yIGFsbCBmaWxlc3lzdGVtcywgYW5kIGhhdmUg aGFkIGl0IGZvciAxNSsgeWVhcnMgbm93Lgo+IAo+IENvdWxkIHlvdSBwb2ludCBvdXQgd2hlcmUg d2UgY2FuIGdldCB0aGlzPyBBbmQsIHRoZSBsYWJlbCBzdXBwb3J0IGRlcGVuZHMKPiBvbiBwZXIt ZmlsZXN5c3RlbSBkZXNpZ24uIEknbSBub3Qgc3VyZSBob3cgdGhpcyBjYW4gYmUgZ2VuZXJpYyBl bm91Z2guCgpVc2Vyc3BhY2Uga25vd3MgaG93IHRvIHJlYWQgbGFiZWxzIG9uIGEgcGVyLWZpbGVz eXN0ZW0tYmFzaXMgYW5kIGRvZXMgc28KanVzdCBmaW5lLiAgVGhhdCdzIGhvdyBpdCBjcmVhdGVz IHRob3NlIHN5bWxpbmtzLCBubyBrZXJuZWwgc3VwcG9ydCBpcwpuZWVkZWQuCgpUaGlzIGhhcyBi ZWVuIGltcGxlbWVudGVkIGZvciAxNSsgeWVhcnMgbm93LCBpdCdzIG5vdCBhIG5ldyB0aGluZy4u LgoKTm93IGlmIHlvdXIgZW1iZWRkZWQgc3lzdGVtIGRvZXNuJ3Qgc3VwcG9ydCBpdCwgdGhhdCdz IHRoZSB1c2Vyc3BhY2Ugb2YKdGhhdCBzeXN0ZW0ncyBmYXVsdCwgaXQncyBub3QgdGhlIGtlcm5l bCdzIGZhdWx0IGF0IGFsbC4gIEdvIGZpeCB5b3VyCnVzZXJzcGFjZSBpZiB5b3Ugd2FudCB0aG9z ZSB0aGluZ3MuCgp0aGFua3MsCgpncmVnIGstaAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4 LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9y Z2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20697C433EA for ; Wed, 22 Jul 2020 17:06:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9DA52065F for ; Wed, 22 Jul 2020 17:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595437564; bh=OR5cu9ZiOnyEIuGOim8D0YhB42FI73IvAZzLYBaMrAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fAPy8thBtnVK+5JTcg5NY933lAdsds+U3UkUDYaZsz9zxeLdjG24LNBV36ti6+H2J j8RRTeTO8g8NafXlXIuNlxeA0x/F8Jw/n9Ww7IoNzoLAmg+mc/ISsyPSwUqhzafnSC Rv8Y8ykdbEK8mzhgbT0cpHMf/wlOWPwF45UwanF4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731807AbgGVRGC (ORCPT ); Wed, 22 Jul 2020 13:06:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:59574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731701AbgGVRF6 (ORCPT ); Wed, 22 Jul 2020 13:05:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77903207E8; Wed, 22 Jul 2020 17:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595437558; bh=OR5cu9ZiOnyEIuGOim8D0YhB42FI73IvAZzLYBaMrAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fo21+ikbWeaUKIlmQNUaTc7OWl1nlaenOWLBZXBwygMsnaX9HuJ9knbDk583vacjj YNS64Wb3BIoGLj8a7Y/fgPhNnSc5EFsxGH21pGPqhSDx3BY8knZVbnQw+puTpgdjIy f1s8m7QiEWgjc5Abrl8IzGXrbNwOtsHQ0SzVKdFg= Date: Wed, 22 Jul 2020 19:06:02 +0200 From: Greg KH To: Jaegeuk Kim Cc: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name Message-ID: <20200722170602.GA440171@kroah.com> References: <20200719054409.3050516-1-daeho43@gmail.com> <20200719151640.GA301791@kroah.com> <20200722164356.GA3912099@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200722164356.GA3912099@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 09:43:56AM -0700, Jaegeuk Kim wrote: > On 07/19, Greg KH wrote: > > On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > Added a symbolic link directory pointing to its device name > > > directory using the volume name of the partition in sysfs. > > > (i.e., /sys/fs/f2fs/vol_#x -> /sys/fs/f2fs/sda1) > > > > No, please no. > > > > That is already created today for you in /dev/disk/ The kernel does not > > need to do this again. > > > > If your distro/system/whatever does not provide you with /dev/disk/ and > > all of the symlinks in there, then work with your distro/system/whatever > > to do so. > > I don't get the point, since /dev/disk points device node, not any sysfs entry. > Do you mean we need to create symlink to /sys/fs/f2fs/dm-X in /dev/disk? Huh, no! It's all done for you today automagically by userspace: $ tree /dev/disk/by-label/ /dev/disk/by-label/ ├── boot -> ../../sda1 ├── fast_disk -> ../../md0 ├── root -> ../../sda2 └── stuff -> ../../dm-0 Look on your laptop/desktop/server today for those, there's lots of symlinks in /dev/disk/ > > Again, no need to do this on a per-filesystem-basis when we already have > > this around for all filesystems, and have had it for 15+ years now. > > Could you point out where we can get this? And, the label support depends > on per-filesystem design. I'm not sure how this can be generic enough. Userspace knows how to read labels on a per-filesystem-basis and does so just fine. That's how it creates those symlinks, no kernel support is needed. This has been implemented for 15+ years now, it's not a new thing... Now if your embedded system doesn't support it, that's the userspace of that system's fault, it's not the kernel's fault at all. Go fix your userspace if you want those things. thanks, greg k-h