From: Vivek Goyal <vgoyal@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-fs@redhat.com, vromanso@redhat.com, qemu-devel@nongnu.org,
rmohr@redhat.com
Subject: Re: [Virtio-fs] [PATCH for-5.1 0/3] virtiofsd: allow virtiofsd to run in a container
Date: Wed, 22 Jul 2020 14:19:14 -0400 [thread overview]
Message-ID: <20200722181914.GB598987@redhat.com> (raw)
In-Reply-To: <20200722130206.224898-1-stefanha@redhat.com>
On Wed, Jul 22, 2020 at 02:02:03PM +0100, Stefan Hajnoczi wrote:
> Container runtimes handle namespace setup and remove privileges needed by
> virtiofsd to perform sandboxing. Luckily the container environment already
> provides most of the sandbox that virtiofsd needs for security.
>
> Introduce a new "virtiofsd -o chroot" option that uses chroot(2) instead of
> namespaces. This option allows virtiofsd to work inside a container.
>
> Please see the individual patches for details on the changes and security
> implications.
>
> Given that people are starting to attempt running virtiofsd in containers I
> think this should go into QEMU 5.1.
Hi Stefan,
I have written a document to help with testing virtiofs with any changes.
https://github.com/rhvgoyal/misc/blob/master/virtiofs-tests/virtio-fs-testing-requirement.txt
Will be good to run some of these tests to make sure there are no
regressions due to these changes.
Thanks
Vivek
>
> Stefan Hajnoczi (3):
> virtiofsd: drop CAP_DAC_READ_SEARCH
> virtiofsd: add container-friendly -o chroot sandboxing option
> virtiofsd: probe unshare(CLONE_FS) and print an error
>
> tools/virtiofsd/fuse_virtio.c | 13 +++++++++
> tools/virtiofsd/helper.c | 3 +++
> tools/virtiofsd/passthrough_ll.c | 45 +++++++++++++++++++++++++++++---
> 3 files changed, 58 insertions(+), 3 deletions(-)
>
> --
> 2.26.2
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
next prev parent reply other threads:[~2020-07-22 18:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 13:02 [Virtio-fs] [PATCH for-5.1 0/3] virtiofsd: allow virtiofsd to run in a container Stefan Hajnoczi
2020-07-22 13:02 ` Stefan Hajnoczi
2020-07-22 13:02 ` [Virtio-fs] [PATCH for-5.1 1/3] virtiofsd: drop CAP_DAC_READ_SEARCH Stefan Hajnoczi
2020-07-22 13:02 ` Stefan Hajnoczi
2020-07-22 16:51 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-22 16:51 ` Dr. David Alan Gilbert
2020-07-22 13:02 ` [Virtio-fs] [PATCH for-5.1 2/3] virtiofsd: add container-friendly -o chroot sandboxing option Stefan Hajnoczi
2020-07-22 13:02 ` Stefan Hajnoczi
2020-07-22 16:58 ` [Virtio-fs] " Daniel P. Berrangé
2020-07-22 16:58 ` Daniel P. Berrangé
2020-07-23 12:17 ` [Virtio-fs] " Stefan Hajnoczi
2020-07-23 12:17 ` Stefan Hajnoczi
2020-07-22 17:58 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-22 17:58 ` Dr. David Alan Gilbert
2020-07-23 12:28 ` [Virtio-fs] " Stefan Hajnoczi
2020-07-23 12:28 ` Stefan Hajnoczi
2020-07-23 13:47 ` [Virtio-fs] " Vivek Goyal
2020-07-23 13:47 ` Vivek Goyal
2020-07-23 15:36 ` Stefan Hajnoczi
2020-07-23 15:36 ` Stefan Hajnoczi
2020-07-22 18:17 ` Vivek Goyal
2020-07-23 12:29 ` Stefan Hajnoczi
2020-07-22 19:03 ` Dr. David Alan Gilbert
2020-07-22 19:03 ` Dr. David Alan Gilbert
2020-07-23 12:32 ` [Virtio-fs] " Stefan Hajnoczi
2020-07-23 12:32 ` Stefan Hajnoczi
2020-07-23 17:55 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-23 17:55 ` Dr. David Alan Gilbert
2020-07-24 12:22 ` [Virtio-fs] " Stefan Hajnoczi
2020-07-24 12:22 ` Stefan Hajnoczi
2020-07-22 13:02 ` [Virtio-fs] [PATCH for-5.1 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error Stefan Hajnoczi
2020-07-22 13:02 ` Stefan Hajnoczi
2020-07-22 17:03 ` [Virtio-fs] " Daniel P. Berrangé
2020-07-22 17:03 ` Daniel P. Berrangé
2020-07-23 12:46 ` [Virtio-fs] " Stefan Hajnoczi
2020-07-23 12:46 ` Stefan Hajnoczi
2020-07-23 12:50 ` [Virtio-fs] " Daniel P. Berrangé
2020-07-23 12:50 ` Daniel P. Berrangé
2020-07-23 13:56 ` [Virtio-fs] " Vivek Goyal
2020-07-23 13:56 ` Vivek Goyal
2020-07-23 15:19 ` Stefan Hajnoczi
2020-07-22 18:19 ` Vivek Goyal [this message]
2020-07-23 12:46 ` [Virtio-fs] [PATCH for-5.1 0/3] virtiofsd: allow virtiofsd to run in a container Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722181914.GB598987@redhat.com \
--to=vgoyal@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rmohr@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=vromanso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.