From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/3] tpm: Put the TCPA table buf after using it
Date: Thu, 23 Jul 2020 06:21:21 +0300 [thread overview]
Message-ID: <20200723031900.GA47866@linux.intel.com> (raw)
In-Reply-To: <1594986348-52258-1-git-send-email-guohanjun@huawei.com>
On Fri, Jul 17, 2020 at 07:45:46PM +0800, Hanjun Guo wrote:
> The acpi_get_table() should be coupled with acpi_put_table() if
> the mapped table is not used for runtime to release the table
> mapping, put the TCPA table buf after using it.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
In a commit message you should first describe the action taken and
then the rationale of doing that e.g. "Couple acpi_get_table() with
acpi_put_table() in order to prevent a memory leak."
In addition, please put a fixes tag.
Please read the section two from the submitting patches guide:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
Thank you.
/Jarkko
next prev parent reply other threads:[~2020-07-23 3:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 11:45 [PATCH 1/3] tpm: Put the TCPA table buf after using it Hanjun Guo
2020-07-17 11:45 ` [PATCH 2/3] tpm: tpm_crb: Put the TPM2 table " Hanjun Guo
2020-07-17 11:45 ` [PATCH 3/3] tpm: tpm_tis: " Hanjun Guo
2020-07-23 3:21 ` Jarkko Sakkinen [this message]
2020-07-23 3:43 ` [PATCH 1/3] tpm: Put the TCPA table buf " Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723031900.GA47866@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.