From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC6E1C433E3 for ; Thu, 23 Jul 2020 07:01:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8A8E20714 for ; Thu, 23 Jul 2020 07:01:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WnKXCssA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbgGWHBh (ORCPT ); Thu, 23 Jul 2020 03:01:37 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:38516 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725774AbgGWHBg (ORCPT ); Thu, 23 Jul 2020 03:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595487695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tCJ9HV/dQQNN/kdt2YO0dJshLcnXkw4jxhsX/ogpvnQ=; b=WnKXCssAkZoguoYnLUDQVc0TIXedvEVVcgRbFDJcxjPMov7gXMn1oHRTDJuzUtn6kjdMF+ fyQKLRQvFJ89PlSQb9FCSbevoJgd6xCwZioOdNFVUi5i3NfviTvkCIK63cFh2roRyytsQV p94zZRtxRNPid+Dwn0Sm7vfGqAYfeEo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-KzkHWC6xN2yqCVe1f7Qr1Q-1; Thu, 23 Jul 2020 03:01:31 -0400 X-MC-Unique: KzkHWC6xN2yqCVe1f7Qr1Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 333D71DE0; Thu, 23 Jul 2020 07:01:30 +0000 (UTC) Received: from gondolin (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 038A91000232; Thu, 23 Jul 2020 07:01:26 +0000 (UTC) Date: Thu, 23 Jul 2020 09:01:23 +0200 From: Cornelia Huck To: Alex Williamson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, prime.zeng@hisilicon.com Subject: Re: [PATCH] vfio/pci: Hold igate across releasing eventfd contexts Message-ID: <20200723090123.095159ed.cohuck@redhat.com> In-Reply-To: <159527934542.26615.503005826695043299.stgit@gimli.home> References: <159527934542.26615.503005826695043299.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 20 Jul 2020 15:09:27 -0600 Alex Williamson wrote: > No need to release and immediately re-acquire igate while clearing > out the eventfd ctxs. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/pci/vfio_pci.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index b0258b79bb5b..dabca0450e6d 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -523,14 +523,12 @@ static void vfio_pci_release(void *device_data) > vfio_pci_vf_token_user_add(vdev, -1); > vfio_spapr_pci_eeh_release(vdev->pdev); > vfio_pci_disable(vdev); > + > mutex_lock(&vdev->igate); > if (vdev->err_trigger) { > eventfd_ctx_put(vdev->err_trigger); > vdev->err_trigger = NULL; > } > - mutex_unlock(&vdev->igate); > - > - mutex_lock(&vdev->igate); > if (vdev->req_trigger) { > eventfd_ctx_put(vdev->req_trigger); > vdev->req_trigger = NULL; > Reviewed-by: Cornelia Huck